We go to a lot of trouble to return error codes, but
we never actually care about anything besides pass/fail.
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I8c0552246f1050813cca372a280b2302c701d617
Maciej Żenczykowskicommited 2025-08-01 14:53:18 -07:00
Sometimes *all* we see is the return code of the binary printed
out by init when we terminate with failure. Unique codes will
make debugging easier.
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Icc93813674af2855b2d9f378a1accac48b403aa3
Maciej Żenczykowskicommited 2025-08-01 14:53:06 -07:00
Since these are equivalent, search and replace...
Test: TreeHugger
Flag: EXEMPT mainline/noop
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I358220f5db70fcde671ce2560086fc7a220f49c7
Maciej Żenczykowskicommited 2025-07-31 17:19:10 -07:00
The field is actually just a compile time calculate index into pin_location.
We add a C++ only helper to return the ASCIIZ string at this offset.
Temporary abort() added to show this is equivalent.
Test: TreeHugger
Flag: EXEMPT mainline/noop
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: If57390b99f348ab03b277e8f68e7f38636c751fc
Maciej Żenczykowskicommited 2025-07-31 17:17:41 -07:00
it doesn't work due to lack of sepolicy for 'rename' operation
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ib660cbef2fc2dd0e3db8b842edefc6ad0c9a3018
Maciej Żenczykowskicommited 2025-07-31 13:01:12 -07:00
easy to do for maps now, but harder for programs
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I0aedef7a8f28d8cc60ca4912f2666f920b9dbeb5
Maciej Żenczykowskicommited 2025-07-31 12:31:56 -07:00
as the name is no longer really appropriate and I want to add another use...
Generated via:
sed -i 's@BPF_PIN_SUBDIR_CHAR_ARRAY_SIZE@BPF_DEF_CHAR_ARRAY_SIZE@' bpf/progs/include/bpf_map_def.h
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I972f8cababe79070aa62f728733c56f41e7a7a84
Maciej Żenczykowskicommited 2025-07-31 12:17:01 -07:00
Basically we can verify and precalculate this at build time.
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ie4e336c6dc82a0e93a3e62c88c313a32cb245861
Maciej Żenczykowskicommited 2025-07-30 15:27:49 -07:00
as it looks akward, and makes little sense once we fully generate
the path at compile time...
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I33a8015b787b41225ef8475accb68cea4467b21d
Maciej Żenczykowskicommited 2025-07-30 15:07:54 -07:00
No longer required now that we have compile time verification.
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I5b18727e8ebf820a06ba647bb7349ba755d5d798
Maciej Żenczykowskicommited 2025-07-30 15:02:07 -07:00
will allow us to store full pin location, longest we currently have is 64 + NULL:
$ adb shell find /sys/fs/bpf | egrep net | egrep '.{64}'
/sys/fs/bpf/netd_shared/prog_netd_cgroupsockrelease_inet_release
$ adb shell find /sys/fs/bpf | egrep net | egrep '.{65}'
<nothing>
Choose small value so we don't needlessly bloat the .o's.
This can be trivially increased on demand.
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I62015d2703fdee004fb7279d8f9ca83f7462a4df
Maciej Żenczykowskicommited 2025-07-30 12:49:04 -07:00
(prep work to eliminate a ton of NetBpfLoad complexity
wrt. map/program pin naming)
Test: TreeHugger
Flag: EXEMPT mainline/noop
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I9a3c452830b31593bfa1979193d6e823055faa1e
Maciej Żenczykowskicommited 2025-07-30 11:14:51 -07:00
Mocking the PackageManager while ConnectivityService is running
could throw an UnfinishedStubbingException. This change splits
the test into two distinct tests that don't need to change the
mocking value for PackageManager during testing.
Fix: 433600031
Test: atest ConnectivityServiceTest
Flag: TEST_ONLY
Change-Id: Ibcff2082d1e50e89c272573b4c719a7325c959fd
BPFLOADER_T_VERSION is not defined (and thus 0)
This was missed when BPFLOADER_*_VERSION was removed
as no longer needed (for non mainline versions) due
to not actually causing a compile error.
Restore it. Android S kernels might not support writing
into non-zero index of bpf map arrays (due to kernel bug).
Test: TreeHugger
Flag: EXEMPT mainline/noop
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I834d4a9f897ea1fa16435d8df709df8eeb69e7e8
Maciej Żenczykowskicommited 2025-07-29 23:08:11 -07:00
Instead of a weird error message about the variable being undeclared,
give a clear error message in the case of BPFLOADER_MIN_VER not being
defined.
Test: TreeHugger
Flag: EXEMPT mainline/noop
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ibad18b356c6b3171336834ea478c9c4c7d2540c1
Maciej Żenczykowskicommited 2025-07-29 23:04:05 -07:00
The genfscon rules only care about the directory, the precise
name is irrelevant and temporary since we immediately rename.
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I6307dc2f7f10d78026c3f798cb1d3027619cee4f
Maciej Żenczykowskicommited 2025-07-29 19:53:10 -07:00
The genfscon rules only care about the directory, the precise
name is irrelevant and temporary since we immediately rename.
Test: TreeHugger
Flag: EXEMPT mainline
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ic8cd316df6649b9bfd629694e32130ce7363afea
Maciej Żenczykowskicommited 2025-07-29 19:53:10 -07:00
No longer needed now that we have a single loader
which can support everything.
Test: TreeHugger
Flag: EXEMPT mainline/noop
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I74c24016265a2b41d818d55c98cbabde04687dd8
Maciej Żenczykowskicommited 2025-07-29 19:53:09 -07:00
Throw an IllegalArgumentException if the key or value sizes exceed the
limits supported by the BpfMap implementation. This prevents potential
file descriptor cache collisions and makes errors explicit.
Test: TreeHugger
Flag: EXEMPT mainline/noop
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I3b2b533e4217ee2ab8bfcd71e93b02ffcf9feba9
Maciej Żenczykowskicommited 2025-07-29 19:52:55 -07:00
Maciej Żenczykowski
commited 
Hao Liu
authored and
Android (Google) Code Review
commited 
Treehugger Robot
authored and
Paul Hu
authored and
Jimi Chen
authored and
Yihan Dong
commited 
Chen Wang
authored and