In most places the `@hide` doctag is treated as a block tag on its own
line. However, there are a few places where it is treated as an inline
doctag, e,g. `{@hide}`, and some places where it looks like a block
tag but is inline in the text, e.g. `Some text. @hide`. Dealing with
all the types increases the complexity of Metalava and makes it
slightly slower.
This change replaces the non-block tag forms with a block tag.
Flag: EXEMPT change the form of @hide does not change the API or behavior
Bug: 429965593
Test: m checkapi
Change-Id: I4ffe44a329dbcb7f0a7bd61af16c3bd99cacdac4
AServiceManager_waitForService sytem APIs currently only callable
via dlsym(): b/376759605. When built with sdk_version current,
the NDK stubs for "sdk" variants only include NDK APIs,
excluding #systemapi APIs.
Flag: EXEMPT Mechanical refactors
Test: atest ServiceManagerWrapperIntegrationTest
Change-Id: I48f690d771c7905e79e463617ded772f753cc854
Mark Chienauthored and Patrick Rohrcommited 2025-08-06 10:44:39 -07:00
Previously this wasn't explicitly set so it relies on other test classes to enable border router which causes flakiness.
Bug: 428628512
Flag: TEST_ONLY
Test: CI
Change-Id: I3bbb2e9fd6374019421b57e0d8d266cd20b5a244
This class can be used with ConnectivityManager#requestNetwork to
request connecting to a specific Thread network from system apps.
Bug: 377258309
Flag: com.android.net.thread.flags.thread_mobile_enabled
Change-Id: I80cb992380236b045e4e331b9861274d8cd10cfd
redactions
This class can be used with ConnectivityManager#requestNetwork to
request connecting to a specific Thread network.
Bug: 374037595
Flag: EXEMPT changes to code which is not used
Change-Id: I6d5ea54243751a0f1ca5760944c46ecb600deb89
This suggested change is automatically generated based on group
memberships and affiliations.
Please approve this change and vote the highest CR. This will keep the
OWNERS file tidy. We ask that you do not ignore this change and either
approve it if the OWNER is no longer active or deny it if the OWNER is
continuing to review CLs (including under a different affiliation).
This CL can always be reverted if the understanding changes.
If this change is in error, vote the lowest CR value (i.e. reject the
CL) and the bot will abandon it.
See the owner's recent review activity for context:
https://googleplex-android-review.googlesource.com/q/sunytt@google.com
To report an issue, file a bug in the Infra>Codereview component.
Change-Id: I69b62d1cb7cf7d41533fdecee69959c992b84269
The existing ActiveOperationalDataset#hashCode has an issue that it's
depending on the SparseArray#hasCode which doesn't override the
Object#hashCode method. The consequence is that when the
ActiveOperationalDataset is used as a key in a container, there will
be a miss even if two ActiveOperationalDataset objects have the same
content.
This commit fixes this issue by using a dedicated
byteArraySparseArrayHasCode() method which computes the content hashcode
with Arrays.deepHashCode(). Also fixes the issue that mUnknownTlvs is
not counted in hashCode().
Flag: EXEMPT trivial bugfix
Change-Id: I085d3bf0bdf4bb73bb995fc28dd3857437f9743e
This class doesn't actually serve a purpose, it only makes
TestableNetworkCallbck more complex.
Test: CtsNetTestCases ConnectivityCoverageTests
Flag: EXEMPT test-only
Change-Id: I39a598b82a3215384bdfe04980f4b280ab2c2716
Android TV U should have the `ThreadNetworkManager` only when the Thread
hardware feature is defined on the TV
Change-Id: I154fc7fadfda4c9c97653b25f3efaa87bf081052
1. allow OEMs to default the vendor and model name to system properties.
2. use the vendor & model name for net diag TLVs
Change-Id: I30e988ba3e9cb9f9c5dc3a096f162d5dbcdfbc11
Fix forward for b/405297285
Background: new / existing runtime permission is now used to guard
access to local networks. apps / tests now need to hold this permission
to do traffic with local devices.
Test: atest ThreadNetworkIntegrationTests
Bug: 405297285
Change-Id: I31aaf147a9f9bd8fab7640b935a163405d31e2b9
Some android devices call the API `setChannelMaxPowers()` to set the
Thread radio output power. Then there is no need for these devices
to set the Thread country code.
This commit adds an overlay configuration `config_thread_country_code_enabled`
to enable/disable setting the Thread country code.
Bug: b/402276117
Test: atest ThreadNetworkUnitTests:ThreadNetworkCountryCodeTest#initialize_countryCodeDisabled_defaultCountryCodeIsUsed
Change-Id: I215c64757d0277853f8d4625ace363a4d7bb974b
* changes:
[Thread] unregister all country code callbacks when CountryCode is not needed
[Thread] do not set the country code again if the co-processor doesn't support it
Zhanglong Xiaauthored and Gerrit Code Reviewcommited 2025-03-17 22:10:39 -07:00
This commit unregisters all country code callbacks (WiFi, Telephony and
Location) when the CountryCode module detects that the co-processor
doesn't support setting the country code.
Bug: b/402276117
Test: atest ThreadNetworkUnitTests:ThreadNetworkCountryCodeTest#setCountryCodeNotSupported_returnUnsupportedFeatureError_unregisterAllCallbacks
Change-Id: I65d57e0e826202ad696335200645bf6d78c8b87c
Some the co-processors do not support setting the country code. This
commit enables the CountryCode module doesn't set the country again
after it knows that the co-processor doesn't support setting the
country code.
Bug: b/402276117
Test: atest ThreadNetworkUnitTests:ThreadNetworkCountryCodeTest#setCountryCodeNotSupported_returnUnsupportedFeatureError_countryCodeNotSetAgain
Change-Id: I8ca1f7aed3774a086e114e91d8100fb7fe9e3664
Some previous setup steps were implemented in NsdManager test cases
hence we couldn't reuse them in Thread test cases. aosp/3377549
introduced more methods in TestableNetworkAgent class which we could use
to get unify the behavior and reduce redundant code.
Not sure if this can deflake the integration test cases.
Bug: 338061061
Change-Id: I6b4542505ec80bf06b736fecbbe7d6901d27cbc4
This is for reduce the overall time of the ThreadNetworkIntegrationTests
which now runs twice for both BR and non-BR cases
Bug: 403360961
Bug: 402480982
Change-Id: Ifa80b8e8885ed980064f92100ef817f9f62b4dc2
This is to avoid applications uses Aloc address for source address which
would cause issues when there are multiple devices sharing the same
Aloc.
Bug: 396019291
Change-Id: I287007ddecd9d0fa2ac8da92f4de691e7844b259
When checking for trel services published by a BR, we need to filter the
services by their service name, since there might be other devices
publishing trel service at the same time.
Bug: 399518677
Change-Id: I56518dbe6c79b48aa048073d8556a53e1261e8bd
1. We don't need to assert that ThreadNetworkManager is always null
when the Thread hardware features are not present. There can be more
useful Thread features which don't require the hardware
2. The getAllThreadNetworkControllers() API has no documentation says
the returned list is guaranteed not empty.
Change-Id: Ie77110067ff670053a2125b30b2791b9f54b2582
The current settings APIs have a few issues:
1. It doesn't support default value which is derived from resource
overlays
2. It exposes the default values of settings entries as public APIs
while they shouldn't be
Bug: 401654864
Change-Id: I1bbe3f14507a497320401f02fa6da512558fe385
This commit adds a resource overlay config for OEMs to disable the
Border Router feature by default. Also updates the tests to cover both
BR and non-BR use cases
Bug: 401654864
Change-Id: I7dd4363836269a08853b58304f62fe52f9021a9e
Wait for route to be added/removed from link properties in the tests
instead of checking immediately, as it takes time for the change to
propagate from ot.
Bug: 401815392
Change-Id: Ie95f4beaa370514d31875b9f2e926762a38bc99e
Setting country code is not a must support feature on all platforms.
This commit skips the country code related tests when the platform
doesn't support setting the country code.
Bug: b/401793629
Test: atest ThreadNetworkIntegrationTests
Change-Id: I6bb8444f70afb2635d7791af2128741bc02e8ff3
The leave() API can now correctly clear the in-memory state for the
Thread stack, it's better to use the leaveAndWait() API in the tests to
ensure timing sequences
Bug: 338061061
Change-Id: Ic91f8043cd5a35f19b9161c5778f83b83a713946
Now that python 2 is fully removed, there's no need for
version-specific properties. Remove them.
Also remove usages of embedded_launcher: true, as that
is the new default value.
Bug: 399954452
Test: Presubmits
Change-Id: I368416638bbf1f5e76f7756792d537f72f3c9714
These were added to allow tests to build against flagged off APIs, in
legacy downstream branches that did not support the flagging
infrastructure and stripped out flagged off APIs from the stubs.
Flagged off APIs are part of the regular stubs in branches used today,
so this is not needed anymore.
Bug: 399365344
Test: atest
Change-Id: Ica7df0c5c9be39d9dca49e0114711a7c43125c3d
Remi NGUYEN VANauthored and Paul Duffincommited 2025-02-28 10:47:40 +00:00
The bring up delay of SRP server is higher than before. In the integration test case we need to explicitly wait for the SRP server to show up in Network Data. Otherwise the test may be flaky.
Bug: 399263029
Change-Id: Id6346bcbfd55a34103ba8de0dcee75d3cacde446
All the 3 meshcop_xxx CTS tests in ThreadNetworkControllerTest are
flaky:
1. meshcopService_threadEnabledButNotJoined_discoveredButNoNetwork fails
if thread is disabled and then enabled
2. meshcopService_threadDisabled_notDiscovered fails if the discovery is
not specifically on the test network
3. meshcopService_joinedNetwork_discoveredHasNetwork is already flaky
Bug: 332195449
Bug: 333649897
Bug: 396311014
Change-Id: Ibd3f7b05bddb6b28408f9411350e364dd720b335
The flag is read-only, and is tested with flag filtering. The target
preparer was prepared for manual testing before the flag was rolled out
in M25-02.
Bug: 398553026
Change-Id: Id678a147e38b8b5454b37bf72cb66bdac24786f8
This test had an assumption that Thread is enabled which is not true. This CL enables Thread in the setUp().
Bug: 397583601
Change-Id: I9c4d5028a663c6fe1c581267ff7d172d0cba577c
Test: verified that when the config is set to `false`, thread won't start up after reboots:
```
➜ main-aosp-2 adb shell ot-ctl state
leader
Done
➜ main-aosp-2 adb reboot
➜ main-aosp-2 adb shell ot-ctl state
/system/bin/sh: ot-ctl: inaccessible or not found
➜ main-aosp-2 adb root
➜ main-aosp-2 adb shell ot-ctl state
disabled
Done
```
Bug: 378587036
Change-Id: I4d1c90ab3121f39219cbaf795879a7ba91db02a3
Treehugger Robot
authored and
Android (Google) Code Review
commited 
Kangping Dong
commited 
Paul Duffin
commited 
Mark Chien
authored and
Patrick Rohr
commited 
Yihan Dong
commited 
Handa Wang
commited 
Owner Cleanup Bot
authored and
Chalard Jean
commited 
Yang Sun
commited 
Gerrit Code Review
commited 
Zhanglong Xia
commited 
Maciej Żenczykowski
authored and
Cole Faust
commited 
Remi NGUYEN VAN
authored and