In patch.sh line 540:
if [ $(get_mb_ver) -lt 59 ] ; then
^-----------^ SC2046 (warning): Quote this to prevent word splitting.
Signed-off-by: Cuynu <cuynu@proton.me>
no frills
we probably have to redesign the UI, hence TMP
this patch clears out the last remaining shellcheck warning
Signed-off-by: fukiame <fukiame@proton.me>
In patch.sh line 261:
cd ~/mbbpatch/MBCPApp
^-------------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Signed-off-by: fukiame <fukiame@proton.me>
In patch.sh line 163:
if [ $(get_mb_ver) -lt 55 ] ; then
^-----------^ SC2046 (warning): Quote this to prevent word splitting.
In patch.sh line 234:
if [ $(get_mb_ver) -gt 56 ] ; then
^-----------^ SC2046 (warning): Quote this to prevent word splitting.
Signed-off-by: fukiame <fukiame@proton.me>
In patch.sh line 47:
echo $(bb_split "$a" '.' '2')
^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
^----------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
Signed-off-by: fukiame <fukiame@proton.me>
In patch.sh line 894:
rm -f 'mbapk/mbapk_unpacked/smali_classes4/com/vtap/MaintenanceActivity$1.smali'
^-- SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
since this behavior is intentional ($1 is part of the filename), silence it
Signed-off-by: fukiame <fukiame@proton.me>
In mbcpapp.sh line 78:
if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apk ]
^----------------------------^ SC2144 (error): -f doesn't work with globs. Use a for loop.
In mbcpapp.sh line 169:
if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apks ]
^-----------------------------^ SC2144 (error): -f doesn't work with globs. Use a for loop.
we do not care about the actual result,
we just need to know whether the files exist,
tis probably fine
Signed-off-by: fukiame <fukiame@proton.me>
fukiameauthored and Cuynucommited 2026-03-14 21:24:04 +07:00
command -v and or executing the binary itself is a good enough rudimentary check
"fix" "nonexistent" command on Termux
also drop redundant $JAVA
Signed-off-by: fukiame <fukiame@proton.me>
fukiameauthored and Cuynucommited 2026-03-14 20:29:12 +07:00
- the filepath is unnessecary and does not do anything as $2 is unused
- since sed_libapp already do both armeabi-v7a and arm64-v8a, only one
command is needed per sed operation
gotta apologize for the sudden commonizing
Signed-off-by: fukiame <fukiame@proton.me>
fukiameauthored and Cuynucommited 2026-03-14 20:24:38 +07:00
In patch.sh line 248:
rm -rf 'mbapk/mbapk_unpacked/smali/com/ay4
^-- SC1078 (warning): Did you forget to close this single quoted string?
Signed-off-by: fukiame <fukiame@proton.me>
fukiameauthored and Cuynucommited 2026-03-14 20:23:35 +07:00
