* It seems that an apostrophe is required for the command to be executed successfully
Test: update_results.sh && m cronet_aml_components_cronet_android_cronet
Change-Id: Ide44e8be9d7db6894cb5bf1bcf0c3e4d67c2a228
Mohannad Farragauthored and Motomu Utsumicommited 2022-12-05 12:09:49 +09:00
* This would help when creating a module for both java and c++. Where the java can get a different name depending on the Sanitizer used.
Test: update_results.sh
Change-Id: I9d1180b98a00c14d4c9851041801c6fd646d4739
* This is a copy of the JniGeneratorActionSanitizer class but supposed to be for the java version where it removes the .h files.
Test: update_results.sh
Change-Id: I9fd38e75b57a9a7a25cd2a9b6caea117f88a2f05
* Instead of going through creating `java_genrule` through `create_modules_from_target`. It's better to just create the genrules from `create_action_module` directly.
Test: update_results.sh
Change-Id: I35d1bf8854b5724390ea776c01e54452fcbaaba6
This shouldn't be exposed as it doesn't benefit the module in any way. The module can call `get_cmd` to generate a suitable `cmd`.
Test: update_results.sh
Change-Id: I671b176ca748fc2d956d738199f0d7390a29dea9
* Quotations escaping is a universal operation that would benefit every subclass. Moving this up in the BaseActionSanitizer to cover for the `java_genrule` errors.
Test: update_results.sh
Change-Id: If6a7296b85170294b596566da413332fe395913f
* jni_registration_generator action has extra cmds that needs to be appeneded to the original cmd like generation of the java files.
* Moved `NEWLINE` to the top of the file.
Test: update_results.sh
Change-Id: I92cec28786472ef31b514698422e100885714250
* Move the creation of cmd implementation to `BaseActionSanitizer`. This is important because we don't want to expose the target args as this will change the original target.
Test: update_results.sh
Change-Id: I4932408d8add345ed8e480b0dc2cd65e73d54b09
* This is already called in `create_action_module`. JniGenerator_Java will be added again in an upcoming CL.
[I think create_action_module shouldn't call that in the first place.]
Test: update_results.sh
Change-Id: I409fb37a135c2249f777d47b97c1565552d2b7ab
* This is a GN-specific flag that should live in gn_utils as it might be used in the future when converting to Bazel.
Test: update_results.sh
Change-Id: If870f757cf3ee57a00c571947a7ffea18a7db55d
* This was affecting the original target args as it was being executed after setting target.args . So this is a step in maintaining the original target as a read-only object.
Test: update_results.sh
Change-Id: I6852dbecbd1ce304af091f3e4d00e0d698cd53f8
* changes:
gn2bp: Move arg output from get_outputs to _sanitize_outputs
gn2bp: Move arg sanitizing from get_args to _sanitize_args
gn2bp: Add sanitize API to the BaseActionSanitizer
gn2bp: Update is_header_generated in the BaseActionSanitizer
gn2bp: Update is_header_generated of MakeDafsaSanitizer
gn2bp: Add MakeDafsaSanitizer
gn2bp: Add is_header_generated to the BaseActionSanitizer
gn2bp: Remove unrequired hack for action_with_pydeps
gn2bp: Use the result of get_outputs as module.out
gn2bp: Add get_outputs to JniGeneratorSanitizer
gn2bp: Fix to use set for target.outputs
gn2bp: Add get_outputs to the BaseActionSanitizer
gn2bp: Fix arg normalization and remove hack in the VersionSanitizer
gn2bp: Normalize args by for loop instead of comprehension
gn2bp: Update the comment for value args and list args
gn2bp: Update _is_value_arg
Mohannad Farragauthored and Gerrit Code Reviewcommited 2022-12-02 12:06:03 +00:00
Currently, Sanitizer modifies target attributes in the get APIs.
However, some sanitize methods are not idempotent (e.g.
_add_location_tag).
Also, get API could depends on the same target attributes, at this
point, get_srcs and get_tool_files will depends on target.sources and
target.inputs.
This could easily cause issue by calling non idempotent sanitize methods
multiple times.
This CL introduces sanitize API to prevent this issue.
sanitize API modifies all the required target attributes and other get
APIs only read the sanitized target attributes.
This makes it easy to guarantee that sanitization is done only once.
Test: ./update_results.sh
Change-Id: I1b4033ae161284ef07153b56e05217b8557b4cba
There are cmd diffs in Android.bp.swp but it is verified the updated
cmds works.
Test: ./update_results.sh
Change-Id: Iaf916f9de12b18b4e5402fcccd2b154f72a6ac8d
Upcoming CL will make this normalization a bit more complex, this CL is
a preparation for that.
Test: ./update_results.
Change-Id: I8248c68d30b21682f5521435f85cd555033b51c6
Currently, NET_CAPABILITY_TEMPORARILY_NOT_METERED traffic is
counted as unmetered data usage, and "mobile data usage"
settings screen shows metered data usage which means it doesn't
include TEMPORARILY_NOT_METERED traffic. However, some carriers
show TEMPORARILY_NOT_METERED data usage in customer's bill which
would be confusing if the data usage in the device shows different
results. Thus, revert the change to avoid confusing.
Bug: 183776809
Test: FrameworksNetTests
Change-Id: I4ef25095462adf30b1ecf82134996739f167930d
This is a preparation for breaking down EthernetTetheringTest into
CTS and MTS tests.
Changes:
1. Separate common variables from EthernetTetheringTest
to EthernetTetheringTestBase.
Before:
EthernetTetheringTest
After:
[base class] [derived class]
EthernetTetheringTestBase +--+ EthernetTetheringTest
2. Separate EthernetTetheringTest from aosp/2319857
Bug: 250552545
Bug: 258637850
Test atest EthernetTetheringTest
Change-Id: I9bccc558dc8b955055a2927a1a600afd399b264f
Hungming Chenauthored and Nucca Chencommited 2022-12-02 07:18:43 +00:00
* changes:
gn2bp: Generate a copy of 'cronet_jni_registration' for java
gn2bp: Fix args formatting for java_cpp_enum.py script
gn2bp: Move 'sanitize_version_filepath' to base class
gn2bp: Create `java_genrule` from java actions
gn2bp: Convert java_actions to `java_group`
gn2bp: Remove redundant checks
Patrick Rohrauthored and Gerrit Code Reviewcommited 2022-12-02 03:38:38 +00:00
cronet_jni_registration is a cc_genrule that produces both C++ header file and java jar. So this copies the cronet_jni_registration cc module and tweak it to fit the java_library
Test: m cronet_aml_components_cronet_android_cronet
Change-Id: I3ae20595c84ab32ae33268e2af79aead3f2d35c4
This method is needed for another subclass so it's better to move it to the base class and change the name.
Test: None
Change-Id: I763a5d30d9b35b585914f1c8dbb2d5989e1d55d6
Motomu Utsumi
commited 
Mohannad Farrag
authored and
Chiachang Wang
authored and
Gerrit Code Review
commited 
Treehugger Robot
authored and
Bill Yi
commited 
Cole Faust
authored and
Aaron Huang
commited 
Hungming Chen
authored and
Mark
authored and
Patrick Rohr
authored and
Paul Hu
authored and