gen_jarjar supported multi-valued arguments via space-separated lists,
like "--apistubs foo bar". This is unusual, as "bar" would generally be
interpreted as a positional argument instead.
Change the usage to "--apistubs foo --apistubs bar", which is more
conventional. Also remove the "--jars" switch to have the jars be
positional arguments instead, and change the "--unsupportedapi"
arguments to be a column-separated list (like java classpath), instead
of space-separated. For --unsupportedapi, this allows providing a list
of files via minimal modifications in the genrule usage.
Test: m
Change-Id: Id67ad16de2ea6682fee402540f464ed3b5b0cca9
* changes:
ethernet: remove callback from factory updateInterfaceLinkState
ethernet: updateConfiguration result should not rely on ip provisioning
ethernet: remove callback boilerplate from EthernetNetworkFactory
ethernet: add EthernetCallback class to wrap OutcomeReceiver
Patrick Rohrauthored and Gerrit Code Reviewcommited 2022-08-24 17:45:04 +00:00
updateInterfaceLinkState already returns true / false depending on the
success, so the EthernetCallback can be removed and sent from
EthernetTracker instead.
Test: atest EthernetManagerTest
Bug: 225317892
Change-Id: Id6ae7929097840ac5c9a4d244fdf669a06b94ed5
In addition, the result should always be success if the new
configuration is stored. This allows updating interfaces that are not
currently registered with ethernet service.
Bug: 236312641
Test: atest EthernetManagerTest
Change-Id: I70474ef5f046c65a6f74161137e25debd8dfe612
The internal issue of nullness suppression for mdns files has
been addressed. Update the bug number to track AOSP only work.
Bug: 242631897
Test: m
Change-Id: I41c072a4313a9668fe509f796ba2956d74397e5c
Now that everything uses EthernetCallback, there is no need for the
boilerplate code in EthernetNetworkFactory anymore.
The next step will be to pull the callbacks out of
EthernetNetworkFactory entirely.
Bug: 225317892
Test: atest EthernetNetworkFactory
Change-Id: I4958df658f7d5852660a5c03a8c9220532e42d3c
The OutcomeReceiver that gets passed into the EthernetServiceImpl is
hard to use (it is nullable and both onError and onResult can throw
RemoteExceptions).
Note: This is an intermediary state.
The next step will be to completely tear EthernetCallback out of
EthernetNetworkFactory, which will remove a lot of boilerplate code.
Bug: 225317892
Test: atest EthernetManagerTest
Change-Id: Ifc0e1ba29ded933c418e4b335cb731c3496d7e44
This change fixed two things:
1. start wifi tethering after airplane mode enabled.
2. run ConnectivityManager#factoryReset with TETHER_PRIVILEGED
permission, so it can sucessfully stop tethering.
Orignally testFactoryReset don't actually test stop tethering.
Tethering already be stopped while airplane mode enabled, but
enable airplane mode then doing factory reset would have race in
wifi stack which caused airplane mode don't take effect in wifi
side.
Bug: 240677322
Test: atest ConnectivityManagerTest#testFactoryReset --iterations 50
Change-Id: I3185401b10b798af744df5c3c7c21fee3d418939
Markauthored and Mark Chiencommited 2022-08-22 15:13:31 +00:00
The ArrayEquals, ArrayHashCode, ArrayToString, and
ArraysAsListPrimitiveArray errorprone findings were
demoted from errors to warnings. Fix existing
occurrences of them so they can be made errors again.
Bug: 242630963
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: I95b4d0f8d3dfa957285ca94e0846fd3da4734e57
Cole Faustauthored and Lorenzo Colitticommited 2022-08-22 00:30:47 +00:00
The DscpPolicyTest needs to be merged into CTS13 R2, so it cannot use
any APIs that were introduced after the T cutoff.
This slows the tests down *slightly*. These test are extremely slow to
begin with (20+ seconds), so the slowdown is negligible.
Test: atest DscpPolicyTest
Change-Id: I8b3eb0e1b72f5e77540adefcf53a6a6885126d4e
Adding this route before receiving the RA causes the kernel to complain
and fail adding the the global v6 address:
"ICMPv6 : RA: ndisc_router_discovery failed to add default route."
Test: atest DscpPolicyTest
Change-Id: I1d2bfd52e05c334f9808e60455c346b4dca18cf7
There are three configuration could affect tethering allowed:
1. user restriction
2. tether_supported settings
3. ro.tether.denied system properties
When user restricted or tether supported setting change, updating
supported downstreams.
ro.tether.denied is read only properties, so it won't be changed runtime.
Also correct the unit test that there is no TetheringConfiguration change when settings or user restriction change.
Bug: 184996041
Bug: 239500515
Test: atest TetheringTests
Change-Id: I8dfcc42de9787a5e9ba19b69db9444c14ace56f0
Setting IFF_MULTICAST in TestNetworkService when the interface is being
brought up elsewhere creates a race condition that might clear the
IFF_UP flag (if TestNetworkService loses the race).
Test: atest EthernetManagerTest --iterations 10
Bug: 242343156
Change-Id: I86e1c8afdb82beed5202f027d906bcce8f963c82
This is a preparation for testing SkDestroyListener that removes
cookieTagMap entry when socket is destroyed.
Bug: 217624062
Test: atest NetworkStatsServiceTest
Change-Id: Ia1091130101360e37557e6f00efe0f736134de05
aosp/2179274 adds fromBase64EncodedString to BpfDump.
This CL updates EthernetTetheringTest to use this function instead of
parseMapKeyValue in EthernetTetheringTest.
Bug: 217624062
Test: atest EthernetTetheringTest
Change-Id: I56b3cd875e16bee6174f0aacd468562ae482cef9
Also just use 'int' for ifindex. The kernel allocates these in order,
if we ever exceed 2 billion, we'll have other problems to worry about.
Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I33eb46185fde90cd4d158bb74f8f9c17b41434fb
Maciej Żenczykowskicommited 2022-08-18 01:07:20 +00:00
These are allocated in order by the kernel, if we go
over 2 billion, we've got other problems... besides
U32 to S32 conversion will work just fine anyway.
Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ifbb7139e9118dd2d0c52e83c5874132e03760b30
Maciej Żenczykowskicommited 2022-08-18 01:07:11 +00:00
* changes:
BpfCoordinator: dump IPv6 BPF downstream rules
BpfCoordinator: change function name and format for dumping IPv6 rules
add header on ipv6 forwarding rulesdump
add header on ipv6 upstream bpf map dump
Maciej Żenczykowskiauthored and Gerrit Code Reviewcommited 2022-08-18 00:49:54 +00:00
* changes:
UpstreamNetworkMonitor: add NOTIFY_TEST_NETWORK_AVAILABLE
EthernetTetheringTest: obtain the required permissions when needed
Use TetheredInterfaceRequester to check available tethering interface
Maciej Żenczykowskiauthored and Gerrit Code Reviewcommited 2022-08-17 17:50:40 +00:00
Remi NGUYEN VAN
commited 
Lucas Lin
authored and
Gerrit Code Review
commited 
Patrick Rohr
authored and
Jean Chalard
authored and
Nucca Chen
authored and
Paul Hu
authored and
Motomu Utsumi
authored and
Chiachang Wang
authored and
Xin Li
authored and
Treehugger Robot
authored and
Maciej Żenczykowski
authored and
Cole Faust
authored and
Mark Chien
authored and
Lorenzo Colitti
commited