Valentin Schneider
fba4c61e98
cpu/hotplug: Mute hotplug lockdep during init
[ Upstream commit ce48c457b95316b9a01b5aa9d4456ce820df94b4 ]
Since we've had:
commit cb538267ea1e ("jump_label/lockdep: Assert we hold the hotplug lock for _cpuslocked() operations")
we've been getting some lockdep warnings during init, such as on HiKey960:
[ 0.820495] WARNING: CPU: 4 PID: 0 at kernel/cpu.c:316 lockdep_assert_cpus_held+0x3c/0x48
[ 0.820498] Modules linked in:
[ 0.820509] CPU: 4 PID: 0 Comm: swapper/4 Tainted: G S 4.20.0-rc5-00051-g4cae42a #34
[ 0.820511] Hardware name: HiKey960 (DT)
[ 0.820516] pstate: 600001c5 (nZCv dAIF -PAN -UAO)
[ 0.820520] pc : lockdep_assert_cpus_held+0x3c/0x48
[ 0.820523] lr : lockdep_assert_cpus_held+0x38/0x48
[ 0.820526] sp : ffff00000a9cbe50
[ 0.820528] x29: ffff00000a9cbe50 x28: 0000000000000000
[ 0.820533] x27: 00008000b69e5000 x26: ffff8000bff4cfe0
[ 0.820537] x25: ffff000008ba69e0 x24: 0000000000000001
[ 0.820541] x23: ffff000008fce000 x22: ffff000008ba70c8
[ 0.820545] x21: 0000000000000001 x20: 0000000000000003
[ 0.820548] x19: ffff00000a35d628 x18: ffffffffffffffff
[ 0.820552] x17: 0000000000000000 x16: 0000000000000000
[ 0.820556] x15: ffff00000958f848 x14: 455f3052464d4d34
[ 0.820559] x13: 00000000769dde98 x12: ffff8000bf3f65a8
[ 0.820564] x11: 0000000000000000 x10: ffff00000958f848
[ 0.820567] x9 : ffff000009592000 x8 : ffff00000958f848
[ 0.820571] x7 : ffff00000818ffa0 x6 : 0000000000000000
[ 0.820574] x5 : 0000000000000000 x4 : 0000000000000001
[ 0.820578] x3 : 0000000000000000 x2 : 0000000000000001
[ 0.820582] x1 : 00000000ffffffff x0 : 0000000000000000
[ 0.820587] Call trace:
[ 0.820591] lockdep_assert_cpus_held+0x3c/0x48
[ 0.820598] static_key_enable_cpuslocked+0x28/0xd0
[ 0.820606] arch_timer_check_ool_workaround+0xe8/0x228
[ 0.820610] arch_timer_starting_cpu+0xe4/0x2d8
[ 0.820615] cpuhp_invoke_callback+0xe8/0xd08
[ 0.820619] notify_cpu_starting+0x80/0xb8
[ 0.820625] secondary_start_kernel+0x118/0x1d0
We've also had a similar warning in sched_init_smp() for every
asymmetric system that would enable the sched_asym_cpucapacity static
key, although that was singled out in:
commit 40fa3780bac2 ("sched/core: Take the hotplug lock in sched_init_smp()")
Those warnings are actually harmless, since we cannot have hotplug
operations at the time they appear. Instead of starting to sprinkle
useless hotplug lock operations in the init codepaths, mute the
warnings until they start warning about real problems.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will.deacon@arm.com>
Cc: cai@gmx.us
Cc: daniel.lezcano@linaro.org
Cc: dietmar.eggemann@arm.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: longman@redhat.com
Cc: marc.zyngier@arm.com
Cc: mark.rutland@arm.com
Link: https://lkml.kernel.org/r/1545243796-23224-2-git-send-email-valentin.schneider@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
|
2019-04-05 22:33:14 +02:00 |
| .. |
|
bpf
|
bpf: do not restore dst_reg when cur_state is freed
|
2019-04-03 06:26:30 +02:00 |
|
cgroup
|
cgroup/pids: turn cgroup_subsys->free() into cgroup_subsys->release() to fix the accounting
|
2019-04-05 22:33:13 +02:00 |
|
configs
|
kconfig: tinyconfig: remove stale stack protector fixups
|
2018-06-15 07:15:28 +09:00 |
|
debug
|
kdb: Don't back trace on a cpu that didn't round up
|
2019-02-12 19:47:19 +01:00 |
|
dma
|
dma-direct: do not include SME mask in the DMA supported check
|
2019-01-13 09:51:05 +01:00 |
|
events
|
perf/aux: Make perf_event accessible to setup_aux()
|
2019-04-05 22:33:11 +02:00 |
|
gcov
|
gcov: remove CONFIG_GCOV_FORMAT_AUTODETECT
|
2018-06-08 18:56:02 +09:00 |
|
irq
|
genirq: Avoid summation loops for /proc/stat
|
2019-04-05 22:33:09 +02:00 |
|
livepatch
|
Merge branch 'for-4.19/upstream' into for-linus
|
2018-08-20 18:33:50 +02:00 |
|
locking
|
locking/lockdep: Add debug_locks check in __lock_downgrade()
|
2019-03-27 14:14:43 +09:00 |
|
power
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
|
2018-10-12 12:35:02 +02:00 |
|
printk
|
printk: Fix panic caused by passing log_buf_len to command line
|
2018-11-13 11:08:48 -08:00 |
|
rcu
|
kprobes: Prohibit probing on RCU debug routine
|
2019-04-05 22:33:08 +02:00 |
|
sched
|
sched/core: Use READ_ONCE()/WRITE_ONCE() in move_queued_task()/task_rq_lock()
|
2019-04-05 22:33:12 +02:00 |
|
time
|
timekeeping: Use proper seqcount initializer
|
2019-02-12 19:47:05 +01:00 |
|
trace
|
tracing: kdb: Fix ftdump to not sleep
|
2019-04-05 22:32:56 +02:00 |
|
.gitignore
|
|
|
|
acct.c
|
|
|
|
async.c
|
kernel/async.c: revert "async: simplify lowest_in_progress()"
|
2018-02-06 18:32:44 -08:00 |
|
audit.c
|
audit: use ktime_get_coarse_real_ts64() for timestamps
|
2018-07-17 14:45:08 -04:00 |
|
audit.h
|
audit: track the owner of the command mutex ourselves
|
2018-02-23 11:22:22 -05:00 |
|
audit_fsnotify.c
|
fsnotify: add fsnotify_add_inode_mark() wrappers
|
2018-05-18 14:58:22 +02:00 |
|
audit_tree.c
|
\n
|
2018-08-17 09:41:28 -07:00 |
|
audit_watch.c
|
audit: fix use-after-free in audit_add_watch
|
2018-07-18 11:43:36 -04:00 |
|
auditfilter.c
|
audit: rename FILTER_TYPE to FILTER_EXCLUDE
|
2018-06-19 10:39:54 -04:00 |
|
auditsc.c
|
audit/stable-4.18 PR 20180814
|
2018-08-15 10:46:54 -07:00 |
|
backtracetest.c
|
|
|
|
bounds.c
|
kbuild: fix kernel/bounds.c 'W=1' warning
|
2018-11-13 11:08:47 -08:00 |
|
capability.c
|
|
|
|
compat.c
|
time: Enable get/put_compat_itimerspec64 always
|
2018-06-24 14:39:47 +02:00 |
|
configs.c
|
|
|
|
context_tracking.c
|
|
|
|
cpu.c
|
cpu/hotplug: Mute hotplug lockdep during init
|
2019-04-05 22:33:14 +02:00 |
|
cpu_pm.c
|
|
|
|
crash_core.c
|
kernel/crash_core.c: print timestamp using time64_t
|
2018-08-22 10:52:47 -07:00 |
|
crash_dump.c
|
|
|
|
cred.c
|
|
|
|
delayacct.c
|
delayacct: Use raw_spinlocks
|
2018-04-27 14:34:51 +02:00 |
|
dma.c
|
proc: introduce proc_create_single{,_data}
|
2018-05-16 07:23:35 +02:00 |
|
elfcore.c
|
|
|
|
exec_domain.c
|
proc: introduce proc_create_single{,_data}
|
2018-05-16 07:23:35 +02:00 |
|
exit.c
|
cgroup/pids: turn cgroup_subsys->free() into cgroup_subsys->release() to fix the accounting
|
2019-04-05 22:33:13 +02:00 |
|
extable.c
|
extable: Make init_kernel_text() global
|
2018-02-21 16:54:06 +01:00 |
|
fail_function.c
|
bpf/error-inject/kprobes: Clear current_kprobe and enable preempt in kprobe
|
2018-06-21 12:33:19 +02:00 |
|
fork.c
|
fork: record start_time late
|
2019-01-13 09:51:04 +01:00 |
|
freezer.c
|
PM / reboot: Eliminate race between reboot and suspend
|
2018-08-06 12:35:20 +02:00 |
|
futex.c
|
futex: Ensure that futex address is aligned in handle_futex_death()
|
2019-03-27 14:14:40 +09:00 |
|
futex_compat.c
|
|
|
|
groups.c
|
|
|
|
hung_task.c
|
kernel/hung_task.c: force console verbose before panic
|
2019-02-12 19:47:19 +01:00 |
|
iomem.c
|
memremap: split devm_memremap_pages() and memremap() infrastructure
|
2018-05-15 23:08:33 -07:00 |
|
irq_work.c
|
|
|
|
jump_label.c
|
jump_label: Fix typo in warning message
|
2018-09-10 10:15:48 +02:00 |
|
kallsyms.c
|
kallsyms, x86: Export addresses of PTI entry trampolines
|
2018-08-14 19:12:29 -03:00 |
|
kcmp.c
|
|
|
|
Kconfig.freezer
|
|
|
|
Kconfig.hz
|
|
|
|
Kconfig.locks
|
|
|
|
Kconfig.preempt
|
kconfig: include kernel/Kconfig.preempt from init/Kconfig
|
2018-08-02 08:06:54 +09:00 |
|
kcov.c
|
kernel/kcov.c: mark write_comp_data() as notrace
|
2019-02-12 19:47:20 +01:00 |
|
kexec.c
|
kexec: add call to LSM hook in original kexec_load syscall
|
2018-07-16 12:31:57 -07:00 |
|
kexec_core.c
|
kexec: yield to scheduler when loading kimage segments
|
2018-06-15 07:55:24 +09:00 |
|
kexec_file.c
|
treewide: Use array_size() in vzalloc()
|
2018-06-12 16:19:22 -07:00 |
|
kexec_internal.h
|
|
|
|
kmod.c
|
|
|
|
kprobes.c
|
kprobes: Return error if we fail to reuse kprobe instead of BUG_ON()
|
2018-11-13 11:08:28 -08:00 |
|
ksysfs.c
|
|
|
|
kthread.c
|
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
|
2018-08-13 11:25:07 -07:00 |
|
latencytop.c
|
|
|
|
Makefile
|
kbuild: move bin2c back to scripts/ from scripts/basic/
|
2018-07-18 01:18:05 +09:00 |
|
memremap.c
|
mm, devm_memremap_pages: add MEMORY_DEVICE_PRIVATE support
|
2019-01-13 09:51:04 +01:00 |
|
module-internal.h
|
modsign: log module name in the event of an error
|
2018-07-02 11:36:17 +02:00 |
|
module.c
|
kobject: return error code if writing /sys/.../uevent fails
|
2019-02-12 19:47:06 +01:00 |
|
module_signing.c
|
modsign: log module name in the event of an error
|
2018-07-02 11:36:17 +02:00 |
|
notifier.c
|
|
|
|
nsproxy.c
|
|
|
|
padata.c
|
|
|
|
panic.c
|
panic: avoid deadlocks in re-entrant console drivers
|
2018-12-29 13:37:57 +01:00 |
|
params.c
|
kernel/params.c: downgrade warning for unsafe parameters
|
2018-04-11 10:28:37 -07:00 |
|
pid.c
|
Fix failure path in alloc_pid()
|
2019-01-13 09:51:06 +01:00 |
|
pid_namespace.c
|
Merge branch 'userns-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
|
2018-04-03 19:15:32 -07:00 |
|
profile.c
|
|
|
|
ptrace.c
|
ptrace: Remove unused ptrace_may_access_sched() and MODE_IBRS
|
2018-12-05 19:32:03 +01:00 |
|
range.c
|
|
|
|
reboot.c
|
PM / reboot: Eliminate race between reboot and suspend
|
2018-08-06 12:35:20 +02:00 |
|
relay.c
|
relay: check return of create_buf_file() properly
|
2019-03-13 14:02:35 -07:00 |
|
resource.c
|
libnvdimm for 4.18
|
2018-06-08 17:21:52 -07:00 |
|
rseq.c
|
rseq: uapi: Declare rseq_cs field as union, update includes
|
2018-07-10 22:18:52 +02:00 |
|
seccomp.c
|
audit/stable-4.18 PR 20180605
|
2018-06-06 16:34:00 -07:00 |
|
signal.c
|
signal: Restore the stop PTRACE_EVENT_EXIT
|
2019-02-20 10:25:48 +01:00 |
|
smp.c
|
cpu/hotplug: Fix "SMT disabled by BIOS" detection for KVM
|
2019-02-12 19:47:25 +01:00 |
|
smpboot.c
|
smpboot: Remove cpumask from the API
|
2018-07-03 09:20:44 +02:00 |
|
smpboot.h
|
|
|
|
softirq.c
|
nohz: Fix missing tick reprogram when interrupting an inline softirq
|
2018-08-03 15:52:10 +02:00 |
|
stacktrace.c
|
|
|
|
stop_machine.c
|
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
|
2018-08-13 11:25:07 -07:00 |
|
sys.c
|
kernel/sys.c: remove duplicated include
|
2018-09-20 22:01:11 +02:00 |
|
sys_ni.c
|
Merge branch 'core-rseq-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
|
2018-06-10 10:17:09 -07:00 |
|
sysctl.c
|
sysctl: handle overflow for file-max
|
2019-04-05 22:32:57 +02:00 |
|
sysctl_binary.c
|
staging: irda: remove remaining remants of irda code removal
|
2018-04-16 11:26:49 +02:00 |
|
task_work.c
|
|
|
|
taskstats.c
|
pids: introduce find_get_task_by_vpid() helper
|
2018-02-06 18:32:46 -08:00 |
|
test_kprobes.c
|
kprobes: Remove jprobe API implementation
|
2018-06-21 12:33:05 +02:00 |
|
torture.c
|
torture: Keep old-school dmesg format
|
2018-06-25 11:30:10 -07:00 |
|
tracepoint.c
|
tracepoint: Fix tracepoint array element size mismatch
|
2018-10-17 15:35:29 -04:00 |
|
tsacct.c
|
|
|
|
ucount.c
|
headers: untangle kmemleak.h from mm.h
|
2018-04-05 21:36:27 -07:00 |
|
uid16.c
|
fs: add do_fchownat(), ksys_fchown() helpers and ksys_{,l}chown() wrappers
|
2018-04-02 20:15:59 +02:00 |
|
uid16.h
|
kernel: provide ksys_*() wrappers for syscalls called by kernel/uid16.c
|
2018-04-02 20:15:30 +02:00 |
|
umh.c
|
umh: fix race condition
|
2018-06-07 16:56:28 -04:00 |
|
up.c
|
|
|
|
user-return-notifier.c
|
|
|
|
user.c
|
userns: use irqsave variant of refcount_dec_and_lock()
|
2018-08-22 10:52:47 -07:00 |
|
user_namespace.c
|
userns: also map extents in the reverse map to kernel IDs
|
2018-11-13 11:09:00 -08:00 |
|
utsname.c
|
uts: create "struct uts_namespace" from kmem_cache
|
2018-04-11 10:28:35 -07:00 |
|
utsname_sysctl.c
|
sys: don't hold uts_sem while accessing userspace memory
|
2018-08-11 02:05:53 -05:00 |
|
watchdog.c
|
watchdog: Respect watchdog cpumask on CPU hotplug
|
2019-04-03 06:26:29 +02:00 |
|
watchdog_hld.c
|
watchdog: Mark watchdog touch functions as notrace
|
2018-08-30 12:56:40 +02:00 |
|
workqueue.c
|
watchdog: Mark watchdog touch functions as notrace
|
2018-08-30 12:56:40 +02:00 |
|
workqueue_internal.h
|
workqueue: Set worker->desc to workqueue name by default
|
2018-05-18 08:47:13 -07:00 |