Bharat Kumar Gogada
fc9c15c4e3
PCI: xilinx-nwl: Fix Multi MSI data programming ...
[ Upstream commit 181fa434d0514e40ebf6e9721f2b72700287b6e2 ]
According to the PCI Local Bus specification Revision 3.0,
section 6.8.1.3 (Message Control for MSI), endpoints that
are Multiple Message Capable as defined by bits [3:1] in
the Message Control for MSI can request a number of vectors
that is power of two aligned.
As specified in section 6.8.1.6 "Message data for MSI", the Multiple
Message Enable field (bits [6:4] of the Message Control register)
defines the number of low order message data bits the function is
permitted to modify to generate its system software allocated
vectors.
The MSI controller in the Xilinx NWL PCIe controller supports a number
of MSI vectors specified through a bitmap and the hwirq number for an
MSI, that is the value written in the MSI data TLP is determined by
the bitmap allocation.
For instance, in a situation where two endpoints sitting on
the PCI bus request the following MSI configuration, with
the current PCI Xilinx bitmap allocation code (that does not
align MSI vector allocation on a power of two boundary):
Endpoint #1 : Requesting 1 MSI vector - allocated bitmap bits 0
Endpoint #2 : Requesting 2 MSI vectors - allocated bitmap bits [1,2]
The bitmap value(s) corresponds to the hwirq number that is programmed
into the Message Data for MSI field in the endpoint MSI capability
and is detected by the root complex to fire the corresponding
MSI irqs. The value written in Message Data for MSI field corresponds
to the first bit allocated in the bitmap for Multi MSI vectors.
The current Xilinx NWL MSI allocation code allows a bitmap allocation
that is not a power of two boundaries, so endpoint #2 , is allowed to
toggle Message Data bit[0] to differentiate between its two vectors
(meaning that the MSI data will be respectively 0x0 and 0x1 for the two
vectors allocated to endpoint #2 ).
This clearly aliases with the Endpoint #1 vector allocation, resulting
in a broken Multi MSI implementation.
Update the code to allocate MSI bitmap ranges with a power of two
alignment, fixing the bug.
Fixes: ab597d35ef
2019-07-31 07:27:02 +02:00
ACPICA: Clear status of GPEs on first direct enable
2019-07-26 09:14:09 +02:00
binder: fix memory leak in error path
2019-07-14 08:11:21 +02:00
libata: don't request sense data on !ZAC ATA devices
2019-07-26 09:14:12 +02:00
atm: he: fix sign-extension overflow on large shift
2019-02-27 10:08:57 +01:00
auxdisplay: hd44780: Fix memory leak on ->remove()
2019-04-20 09:15:55 +02:00
regmap: fix bulk writes on paged registers
2019-07-26 09:14:06 +02:00
floppy: fix out-of-bounds read in copy_buffer
2019-07-26 09:14:18 +02:00
Bluetooth: Add new 13d3:3501 QCA_ROME device
2019-07-26 09:14:16 +02:00
cdrom: Fix race condition in cdrom_sysctl_register
2019-04-05 22:33:10 +02:00
hwrng: omap - Set default quality
2019-05-31 06:46:31 -07:00
clk: ti: clkctrl: Fix returning uninitialized data
2019-07-21 09:03:04 +02:00
clocksource/drivers/exynos_mct: Increase priority over ARM arch timer
2019-07-26 09:14:12 +02:00
connector: fix unsafe usage of ->real_parent
2019-03-19 13:12:38 +01:00
cpufreq: kirkwood: fix possible object reference leak
2019-05-31 06:46:24 -07:00
cpuidle: big.LITTLE: fix refcount leak
2019-02-12 19:47:08 +01:00
crypto: caam - limit output IV to CBC to work around CTR mode DMA issue
2019-07-26 09:14:29 +02:00
mm/huge_memory: fix vmf_insert_pfn_{pmd, pud}() crash, handle unaligned addresses
2019-05-22 07:37:40 +02:00
dmaengine: imx-sdma: fix use-after-free on probe error path
2019-07-26 09:13:56 +02:00
dma-buf: Discard old fence_excl on retrying get_fences_rcu for realloc
2019-07-28 08:29:28 +02:00
EDAC: Fix global-out-of-bounds write when setting edac_mc_poll_msec
2019-07-26 09:14:13 +02:00
extcon: arizona: Disable mic detect if running when driver is removed
2019-05-31 06:46:23 -07:00
efi/bgrt: Drop BGRT status field reserved bits check
2019-07-21 09:03:04 +02:00
fpga: dfl: Add lockdep classes for pdata->lock
2019-06-25 11:35:55 +08:00
fsi: master-ast-cf: select GENERIC_ALLOCATOR
2018-12-17 09:24:35 +01:00
gnss: sirf: fix premature wakeup interrupt enable
2019-03-10 07:17:21 +01:00
gpio: davinci: silence error prints in case of EPROBE_DEFER
2019-07-28 08:29:28 +02:00
drm/msm: Depopulate platform on probe failure
2019-07-31 07:27:01 +02:00
HID: wacom: correct touch resolution x/y typo
2019-07-26 09:14:27 +02:00
Drivers: hv: vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()
2019-05-10 17:54:04 +02:00
hwmon: (pmbus/core) Treat parameters as paged if on multiple pages
2019-06-25 11:35:59 +08:00
intel_th: msu: Fix single mode with disabled IOMMU
2019-07-26 09:14:30 +02:00
i2c: stm32f7: fix the get_irq error cases
2019-07-31 07:27:02 +02:00
ide: fix a typo in the settings proc file name
2019-01-31 08:14:42 +01:00
x86/cpu: Sanitize FAM6_ATOM naming
2019-05-14 19:17:53 +02:00
iio: adc: stm32-dfsdm: missing error case during probe
2019-07-31 07:26:56 +02:00
IB/mlx5: Report correctly tag matching rendezvous capability
2019-07-26 09:14:27 +02:00
Input: alps - fix a mismatch between a condition check and its comment
2019-07-26 09:14:22 +02:00
iommu: Fix a leak in iommu_insert_resv_region
2019-07-26 09:14:06 +02:00
irqchip/meson-gpio: Add support for Meson-G12A SoC
2019-07-26 09:14:06 +02:00
mISDN: make sure device name is NUL terminated
2019-06-22 08:15:16 +02:00
leds: trigger: netdev: use memcpy in device_name_store
2019-05-04 09:20:22 +02:00
lightnvm: pblk: fix freeing of merged pages
2019-07-26 09:14:09 +02:00
mailbox: stm32-ipcc: check invalid irq
2019-06-15 11:54:04 +02:00
dm bufio: fix deadlock with loop device
2019-07-26 09:14:31 +02:00
media: videobuf2-dma-sg: Prevent size from overflowing
2019-07-26 09:14:24 +02:00
memory: tegra: Fix integer overflow on tick value calculation
2019-05-25 18:23:32 +02:00
memstick: Fix error cleanup path of memstick_init
2019-07-31 07:26:59 +02:00
mfd: twl6040: Fix device init errors for ACCCTL register
2019-06-15 11:54:03 +02:00
VMCI: Fix integer overflow in VMCI handle arrays
2019-07-14 08:11:21 +02:00
mmc: sdhci: sdhci-pci-o2micro: Check if controller supports 8-bit width
2019-07-31 07:27:01 +02:00
mtd: spinand: read returns badly if the last page has bitflips
2019-07-26 09:14:30 +02:00
macsec: fix checksumming after decryption
2019-07-28 08:29:26 +02:00
spi: ST ST95HF NFC: declare missing of table
2019-05-16 19:41:25 +02:00
libnvdimm/pfn: fix fsdax-mode namespace info-block zero-fields
2019-07-26 09:14:27 +02:00
nvme-pci: set the errno on ctrl state change error
2019-07-26 09:14:09 +02:00
nvmem: sunxi_sid: Support SID on A83T and H5
2019-06-15 11:54:07 +02:00
of: overlay: set node fields from properties when add new overlay node
2019-06-09 09:17:24 +02:00
OPP: Use opp_table->regulators to verify no regulator case
2019-02-12 19:47:08 +01:00
parisc: Use implicit space register selection for loading the coherence index of I/O pdirs
2019-06-11 12:20:51 +02:00
parport: Fix mem leak in parport_register_dev_model
2019-06-25 11:35:55 +08:00
PCI: xilinx-nwl: Fix Multi MSI data programming
2019-07-31 07:27:02 +02:00
perf/arm-cci: Remove broken race mitigation
2019-05-31 06:46:17 -07:00
phy: renesas: rcar-gen2: Fix memory leak at error paths
2019-07-31 07:27:00 +02:00
pinctrl: rockchip: fix leaked of_node references
2019-07-31 07:26:57 +02:00
platform/mellanox: mlxreg-hotplug: Add devm_free_irq call to remove flow
2019-07-10 09:53:38 +02:00
power: supply: max14656: fix potential use-before-alloc
2019-06-15 11:54:09 +02:00
x86/cpu: Sanitize FAM6_ATOM naming
2019-05-14 19:17:53 +02:00
ptp: Fix pass zero to ERR_PTR() in ptp_clock_register
2019-02-12 19:47:01 +01:00
pwm: Fix deadlock warning when removing PWM device
2019-06-15 11:54:10 +02:00
rapidio: fix a NULL pointer dereference when create_workqueue() fails
2019-06-15 11:53:59 +02:00
RAS/CEC: Fix pfn insertion
2019-07-26 09:14:05 +02:00
regulator: s2mps11: Fix buck7 and buck8 wrong voltages
2019-07-26 09:14:22 +02:00
reset: meson-audio-arb: Fix missing .owner setting of reset_controller_dev
2019-05-08 07:21:47 +02:00
rtc: pcf8523: don't return invalid date when battery is low
2019-06-19 08:18:07 +02:00
s390/qdio: handle PENDING state for QEBSM devices
2019-07-26 09:14:04 +02:00
drivers/sbus/char: add of_node_put()
2018-12-21 14:15:17 +01:00
scsi: mac_scsi: Fix pseudo DMA implementation, take 2
2019-07-26 09:14:19 +02:00
slimbus: fix a potential NULL pointer dereference in of_qcom_slim_ngd_register
2019-05-31 06:46:14 -07:00
soc: bcm: brcmstb: biuctrl: Register writes require a barrier
2019-07-14 08:11:03 +02:00
soundwire: intel: set dai min and max channels correctly
2019-07-14 08:11:07 +02:00
spi: bitbang: Fix NULL pointer dereference in spi_unregister_master
2019-07-10 09:53:32 +02:00
ssb: Fix possible NULL pointer dereference in ssb_host_pcmcia_exit
2019-05-31 06:46:04 -07:00
staging: vt6656: use meaningful error code during buffer allocation
2019-07-31 07:26:57 +02:00
scsi: iscsi: set auth_protocol back to NULL if CHAP_A value is not supported
2019-07-26 09:13:56 +02:00
tee: optee: avoid possible double list_del()
2019-02-12 19:47:08 +01:00
drivers: thermal: tsens: Don't print error message on -EPROBE_DEFER
2019-06-15 11:54:02 +02:00
thunderbolt: property: Fix a NULL pointer dereference
2019-05-31 06:46:31 -07:00
serial: mctrl_gpio: Check if GPIO property exisits before requesting it
2019-07-31 07:27:01 +02:00
usb: gadget: Zero ffs_io_data
2019-07-31 07:27:01 +02:00
vfio: Fix WARNING "do not call blocking ops when !TASK_RUNNING"
2019-06-15 11:54:07 +02:00
vhost_net: disable zerocopy by default
2019-07-26 09:14:08 +02:00
video: imsttfb: fix potential NULL pointer dereferences
2019-06-15 11:54:10 +02:00
drivers/virt/fsl_hypervisor.c: prevent integer overflow in ioctl
2019-05-16 19:41:31 +02:00
virtio_pci: fix a NULL pointer reference in vp_del_vqs
2019-05-10 17:54:08 +02:00
w1: fix the resume command API
2019-05-31 06:46:14 -07:00
watchdog: fix compile time error of pretimeout governors
2019-06-15 11:54:06 +02:00
xen/events: fix binding user event channels to cpus
2019-07-26 09:14:25 +02:00
fc9c15c4e3