Jens Axboe
55cbeea76e
blk-mq: punt failed direct issue to dispatch list ...
commit c616cbee97aed4bc6178f148a7240206dcdb85a6 upstream.
After the direct dispatch corruption fix, we permanently disallow direct
dispatch of non read/write requests. This works fine off the normal IO
path, as they will be retried like any other failed direct dispatch
request. But for the blk_insert_cloned_request() that only DM uses to
bypass the bottom level scheduler, we always first attempt direct
dispatch. For some types of requests, that's now a permanent failure,
and no amount of retrying will make that succeed. This results in a
livelock.
Instead of making special cases for what we can direct issue, and now
having to deal with DM solving the livelock while still retaining a BUSY
condition feedback loop, always just add a request that has been through
->queue_rq() to the hardware queue dispatch list. These are safe to use
as no merging can take place there. Additionally, if requests do have
prepped data from drivers, we aren't dependent on them not sharing space
in the request structure to safely add them to the IO scheduler lists.
This basically reverts ffe81d45322c and is based on a patch from Ming,
but with the list insert case covered as well.
Fixes: ffe81d45322c ("blk-mq: fix corruption with direct issue")
Cc: stable@vger.kernel.org
Suggested-by: Ming Lei <ming.lei@redhat.com>
Reported-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-12-08 12:59:10 +01:00
partitions/aix: append null character to print data from disk
2018-07-27 09:17:41 -06:00
badblocks: fix wrong return value in badblocks_set if badblocks are disabled
2017-11-03 11:29:50 -07:00
block: bfq: swap puts in bfqg_and_blkg_put
2018-09-06 11:32:58 -06:00
block, bfq: reduce write overcharge
2018-08-16 13:08:13 -06:00
block, bfq: add/remove entity weights correctly
2018-07-09 09:07:52 -06:00
block, bfq: correctly charge and reset entity service in all cases
2018-11-13 11:08:28 -08:00
block: move bio_integrity_{intervals,bytes} into blkdev.h
2018-07-26 15:49:41 -06:00
block: copy ioprio in __bio_clone_fast() and bounce
2018-12-01 09:37:32 +01:00
blk-cgroup: increase number of supported policies
2018-09-11 10:59:53 -06:00
SCSI: fix queue cleanup race before queue initialization is done
2018-11-21 09:19:18 +01:00
blk-mq-sched: remove unused 'can_block' arg from blk_mq_sched_insert_request
2018-01-17 09:49:21 -07:00
block: fix use-after-free in block flush handling
2018-06-09 06:37:14 -06:00
block drivers/block: Use octal not symbolic permissions
2018-05-24 13:38:59 -06:00
block, mm: remove unnecessary __GFP_HIGH flag
2018-07-09 09:07:54 -06:00
block: make iolatency avg_lat exponentially decay
2018-08-02 09:58:14 -06:00
block: make sure writesame bio is aligned with logical block size
2018-11-13 11:08:16 -08:00
Merge branch 'for-4.16/block' of git://git.kernel.dk/linux-block
2018-01-29 11:51:49 -08:00
block: make sure discard bio is aligned with logical block size
2018-11-13 11:08:16 -08:00
blk-mq: don't keep offline CPUs mapped to hctx 0
2018-04-10 08:38:46 -06:00
block: Make struct request_queue smaller for CONFIG_BLK_DEV_ZONED=n
2018-07-09 09:07:52 -06:00
blk-mq: dequeue request one by one from sw queue if hctx is busy
2018-07-09 09:07:53 -06:00
block: Make struct request_queue smaller for CONFIG_BLK_DEV_ZONED=n
2018-07-09 09:07:52 -06:00
blk-mq: code clean-up by adding an API to clear set->mq_map
2018-07-09 09:07:53 -06:00
block: Add rdma affinity based queue mapping helper
2017-08-08 14:58:03 -04:00
blk-mq: init hctx sched after update ctx and hctx mapping
2018-08-21 09:02:55 -06:00
blk-mq: init hctx sched after update ctx and hctx mapping
2018-08-21 09:02:55 -06:00
block drivers/block: Use octal not symbolic permissions
2018-05-24 13:38:59 -06:00
blk-mq: Allow blocking queue tag iter callbacks
2018-09-25 20:17:59 -06:00
Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block
2017-11-14 15:32:19 -08:00
blk-mq: provide a default queue mapping for virtio device
2017-02-27 20:54:05 +02:00
blk-mq: punt failed direct issue to dispatch list
2018-12-08 12:59:10 +01:00
blk-mq: issue directly if hw queue isn't busy in case of 'none'
2018-07-17 16:04:00 -06:00
blk-rq-qos: make depth comparisons unsigned
2018-07-22 11:30:53 -06:00
blk-rq-qos: make depth comparisons unsigned
2018-07-22 11:30:53 -06:00
block: allow max_discard_segments to be stacked
2018-07-24 14:46:39 -06:00
block: fix timeout changes for legacy request drivers
2018-06-19 11:27:18 -06:00
blk-stat: export helpers for modifying blk_rq_stat
2018-07-09 09:07:54 -06:00
blk-stat: export helpers for modifying blk_rq_stat
2018-07-09 09:07:54 -06:00
blk-wbt: don't maintain inflight counts if disabled
2018-08-23 09:34:46 -06:00
for-linus-20180616
2018-06-17 05:37:55 +09:00
blkcg: use tryget logic when associating a blkg with a bio
2018-08-31 14:48:58 -06:00
blk-mq: Fix timeout handling in case the timeout handler returns BLK_EH_DONE
2018-06-23 10:25:45 -06:00
blk-wbt: wake up all when we scale up, not down
2018-10-11 13:31:28 -06:00
block: remove external dependency on wbt_flags
2018-07-09 09:07:54 -06:00
block: Remove a superfluous cast from blkdev_report_zones()
2018-07-09 09:07:52 -06:00
block: make sure discard bio is aligned with logical block size
2018-11-13 11:08:16 -08:00
block: copy ioprio in __bio_clone_fast() and bounce
2018-12-01 09:37:32 +01:00
block/bsg-lib: use PTR_ERR_OR_ZERO to simplify the flow path
2018-08-01 09:13:03 -06:00
block: bsg: move atomic_t ref_count variable to refcount API
2018-08-27 19:17:02 -06:00
cfq: Suppress compiler warnings about comparisons
2018-08-07 17:57:13 -06:00
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
block drivers/block: Use octal not symbolic permissions
2018-05-24 13:38:59 -06:00
block: fix deadline elevator drain for zoned block devices
2018-09-26 19:57:24 -06:00
block: use nanosecond resolution for iostat
2018-09-21 20:26:59 -06:00
block: pass inclusive 'lend' parameter to truncate_inode_pages_range
2018-02-23 15:20:19 -07:00
block: add ioprio_check_cap function
2018-05-31 10:50:54 -04:00
block: introduce blk-iolatency io controller
2018-07-09 09:07:54 -06:00
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
block: kyber: make kyber more friendly with merging
2018-05-30 10:47:40 -06:00
block: introduce blk-iolatency io controller
2018-07-09 09:07:54 -06:00
block drivers/block: Use octal not symbolic permissions
2018-05-24 13:38:59 -06:00
block: move existing elevator ops to union
2017-01-17 10:03:33 -07:00
block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled
2017-09-11 09:45:52 -06:00
block: use nanosecond resolution for iostat
2018-09-21 20:26:59 -06:00
block: consistently use GFP_NOIO instead of __GFP_NORECLAIM
2018-05-14 08:55:18 -06:00
block: sed-opal: Fix a couple off by one bugs
2018-06-20 12:04:06 -06:00
block: move dif_prepare/dif_complete functions to block layer
2018-07-30 08:27:02 -06:00
55cbeea76e