Kees Cook
646e5c77b4
exec: load_script: Do not exec truncated interpreter path ...
[ Upstream commit b5372fe5dc84235dbe04998efdede3c4daa866a9 ]
Commit 8099b047ecc4 ("exec: load_script: don't blindly truncate
shebang string") was trying to protect against a confused exec of a
truncated interpreter path. However, it was overeager and also refused
to truncate arguments as well, which broke userspace, and it was
reverted. This attempts the protection again, but allows arguments to
remain truncated. In an effort to improve readability, helper functions
and comments have been added.
Co-developed-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Samuel Dionne-Riel <samuel@dionne-riel.com>
Cc: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Graham Christensen <graham@grahamc.com>
Cc: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-11-06 13:05:37 +01:00
9p: avoid attaching writeback_fid on mmap with type PRIVATE
2019-10-11 18:21:13 +02:00
fs/adfs: super: fix use-after-free bug
2019-08-06 19:06:49 +02:00
afs: Fix leak in afs_lookup_cell_rcu()
2019-09-10 10:33:52 +01:00
autofs: fix error return in autofs_fill_super()
2019-03-13 14:02:32 -07:00
fix a series of Documentation/ broken file name references
2018-06-15 18:10:01 -03:00
bfs: add sanity check at bfs_fill_super()
2018-12-01 09:37:27 +01:00
Btrfs: fix deadlock on tree root leaf when finding free extent
2019-11-06 13:05:22 +01:00
fscache, cachefiles: remove redundant variable 'cache'
2018-12-17 09:24:40 +01:00
ceph: reconnect connection if session hang in opening state
2019-10-11 18:21:15 +02:00
cifs: add credits from unmatched responses/messages
2019-11-06 13:05:36 +01:00
coda: add error handling for fget
2019-08-06 19:06:51 +02:00
configfs: Fix use-after-free when accessing sd->s_dentry
2019-06-22 08:15:17 +02:00
Cramfs: fix abad comparison when wrap-arounds occur
2018-11-13 11:08:55 -08:00
fscrypt: clean up some BUG_ON()s in block encryption/decryption
2019-07-26 09:14:02 +02:00
debugfs: fix use-after-free on symlink traversal
2019-05-08 07:21:48 +02:00
fs/devpts: always delete dcache dentry-s in dput()
2019-03-23 20:09:59 +01:00
dlm: check if workqueues are NULL before flushing/destroying
2019-07-31 07:27:07 +02:00
eCryptfs: fix a couple type promotion bugs
2019-07-26 09:14:29 +02:00
efivars: Call guid_parse() against guid_t type of variable
2018-07-22 14:13:44 +02:00
fs/exofs: fix potential memory leak in mount option parsing
2018-11-27 16:13:00 +01:00
exportfs: do not read dentry after free
2018-12-17 09:24:35 +01:00
ext2: Fix underflow in ext2_max_size()
2019-03-23 20:10:03 +01:00
ext4: disallow files with EXT4_JOURNAL_DATA_FL from EXT4_IOC_SWAP_BOOT
2019-11-06 13:05:37 +01:00
f2fs: fix to recover inode->i_flags of inode block during POR
2019-11-06 13:05:17 +01:00
fat: work around race with userspace's read via blockdev while mounting
2019-10-07 18:57:14 +02:00
fscache: fix race between enablement and dropping of object
2018-12-17 09:24:40 +01:00
fuse: fix memleak in cuse_channel_open
2019-10-11 18:21:20 +02:00
gfs2: clear buf_in_tr when ending a transaction in sweep_bh_for_rgrps
2019-10-05 13:10:07 +02:00
hfs: do not free node before using
2018-12-17 09:24:41 +01:00
hfsplus: do not free node before using
2018-12-17 09:24:41 +01:00
vfs: discard ATTR_ATTR_FLAG
2018-08-17 16:20:28 -07:00
hpfs: remove unnecessary checks on the value of r when assigning error code
2018-08-25 12:42:33 -07:00
hugetlb: use same fault hash key for shared and private mappings
2019-05-22 07:37:40 +02:00
isofs: reject hardware sector size > 2048 bytes
2018-08-21 11:37:41 +02:00
jbd2: introduce jbd2_inode dirty range scoping
2019-07-28 08:29:29 +02:00
jffs2: fix use-after-free on symlink traversal
2019-05-08 07:21:48 +02:00
Just one jfs patch for 4.19
2018-08-15 22:47:23 -07:00
kernfs: fix barrier usage in __kernfs_new_node()
2019-05-16 19:41:18 +02:00
Revert "lockd: Show pid of lockd for remote locks"
2019-06-09 09:17:22 +02:00
NFSv4: Ensure that the state manager exits the loop on SIGKILL
2019-11-06 13:05:29 +01:00
nfsd: Fix overflow causing non-working mounts on 1 TB machines
2019-07-10 09:53:47 +02:00
nilfs2: convert to SPDX license tags
2018-09-04 16:45:02 -07:00
memcg, fsnotify: no oom-kill for remote memcg charging
2019-07-31 07:27:08 +02:00
ntfs: mft: remove VLA usage
2018-08-17 16:20:27 -07:00
ocfs2: fix panic due to ocfs2_wq is null
2019-10-29 09:19:38 +01:00
orangefs: remove redundant pointer orangefs_inode
2018-08-14 12:07:14 -04:00
ovl: filter of trusted xattr results in audit
2019-10-05 13:10:08 +02:00
fs/proc/page.c: don't access uninitialized memmaps in fs/proc/page.c
2019-10-29 09:19:56 +01:00
pstore: fs superblock limits
2019-10-07 18:56:59 +02:00
quota: fix a problem about transfer quota
2019-07-14 08:11:15 +02:00
reiserfs: propagate errors from fill_with_dentries() properly
2018-11-27 16:12:59 +01:00
Squashfs: Compute expected length from inode size rather than block length
2018-08-02 09:34:02 -07:00
Driver core patches for 4.19-rc1
2018-08-18 11:44:53 -07:00
sysv: return 'err' instead of 0 in __sysv_write_inode
2018-12-17 09:24:30 +01:00
tracefs: Annotate tracefs_ops with __ro_after_init
2018-07-31 11:32:44 -04:00
ubifs: Correctly use tnc_next() in search_dh_cookie()
2019-09-19 09:09:37 +02:00
udf: Fix incorrect final NOT_ALLOCATED (hole) extent length
2019-07-14 08:11:16 +02:00
ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour
2019-05-25 18:23:46 +02:00
xfs: don't crash on null attr fork xfs_bmapi_read
2019-10-01 08:26:12 +02:00
Fix aio_poll() races
2019-05-02 09:58:59 +02:00
anon_inode_getfile(): switch to alloc_file_pseudo()
2018-07-12 10:04:27 -04:00
fs: Fix attr.c kernel-doc
2018-07-03 16:44:45 -04:00
get rid of 'opened' argument of ->atomic_open() - part 3
2018-07-12 10:04:20 -04:00
binfmt_elf: Do not move brk for INTERP-less ET_EXEC
2019-10-05 13:10:06 +02:00
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
fs/binfmt_flat.c: make load_flat_shared_library() work
2019-07-03 13:14:44 +02:00
turn filp_clone_open() into inline wrapper for dentry_open()
2018-07-10 23:29:03 -04:00
exec: load_script: Do not exec truncated interpreter path
2019-11-06 13:05:37 +01:00
block: fix the return errno for direct IO
2019-04-17 08:38:52 +02:00
fs: fix guard_bio_eod to check for real EOD errors
2019-04-05 22:33:00 +02:00
chardev: add additional check for minor range overlap
2019-05-31 06:46:27 -07:00
ncpfs: remove compat functionality
2018-06-05 19:23:26 +02:00
compat_ioctl: pppoe: fix PPPOEIOCSFWD handling
2019-08-09 17:52:34 +02:00
dax: dax_layout_busy_page() should not unmap cow pages
2019-08-16 10:12:52 +02:00
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
direct-io: allow direct writes to empty inodes
2019-03-05 17:58:50 +01:00
fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()
2019-03-13 14:02:32 -07:00
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
fs/epoll: drop ovflist branch prediction
2019-02-12 19:47:19 +01:00
sched/fair: Don't free p->numa_faults with concurrent readers
2019-08-04 09:30:56 +02:00
signal: Don't send signals to tasks that don't exist
2018-08-15 23:03:20 -05:00
fs/file.c: initialize init_files.resize_wait
2019-04-05 22:32:59 +02:00
overlayfs update for 4.19
2018-08-21 18:19:09 -07:00
blkcg, writeback: dead memcgs shouldn't contribute to writeback ownership arbitration
2019-07-26 09:14:08 +02:00
Abort file_remove_privs() for non-reg. files
2019-06-22 08:15:21 +02:00
acct_on(): don't mess with freeze protection
2019-05-31 06:46:05 -07:00
vfs: fix FIGETBSZ ioctl on an overlayfs file
2018-11-21 09:19:14 +01:00
iomap: fix a use after free in iomap_dio_rw
2019-03-13 14:02:29 -07:00
autofs: remove left-over autofs4 stubs
2018-06-11 08:22:34 -07:00
kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt
2018-08-02 08:06:55 +09:00
Fix the locking in dcache_readdir() and friends
2019-10-17 13:45:35 -07:00
overlayfs update for 4.19
2018-08-21 18:19:09 -07:00
autofs: remove left-over autofs4 stubs
2018-06-11 08:22:34 -07:00
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
mpage: mpage_readpages() should submit IO as read-ahead
2018-08-17 16:20:29 -07:00
Revert "vfs: Allow userns root to call mknod on owned filesystems."
2018-12-29 13:37:54 +01:00
mnt: fix __detach_mounts infinite loop
2018-11-21 09:19:22 +01:00
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
access: avoid the RCU grace period for the temporary subjective credentials
2019-07-31 07:27:11 +02:00
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:20:11 +02:00
vfs: fix page locking deadlocks when deduping files
2019-09-10 10:33:47 +01:00
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
seq_file: fix problem when seeking mid-record
2019-08-25 10:47:43 +02:00
Merge branch 'work.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-06-16 16:21:50 +09:00
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:20:11 +02:00
vfs: Fix EOVERFLOW testing in put_compat_statfs64
2019-10-11 18:21:39 +02:00
Merge branch 'ida-4.19' of git://git.infradead.org/users/willy/linux-dax
2018-08-26 11:48:42 -07:00
Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-08-13 20:56:23 -07:00
userfaultfd_release: always remove uffd flags and clear vm_userfaultfd_ctx
2019-08-29 08:28:52 +02:00
sysfs: Do not return POSIX ACL xattrs via listxattr
2018-09-18 07:30:48 -04:00
646e5c77b4