Miquel Raynal
5cad883fd6
mtd: rawnand: marvell: prevent timeouts on a loaded machine
...
commit cafb56dd741e61c99709bcd2b193a9a1d36def3b upstream.
marvell_nfc_wait_op() waits for completion during 'timeout_ms'
milliseconds before throwing an error. While the logic is fine, the
value of 'timeout_ms' is given by the core and actually correspond to
the maximum time the NAND chip will take to complete the
operation. Assuming there is no overhead in the propagation of the
interrupt signal to the the NAND controller (through the Ready/Busy
line), this delay does not take into account the latency of the
operating system. For instance, for a page write, the delay given by
the core is rounded up to 1ms. Hence, when the machine is over loaded,
there is chances that this timeout will be reached.
There are two ways to solve this issue that are not incompatible:
1/ Enlarge the timeout value (if so, how much?).
2/ Check after the waiting method if we did not miss any interrupt
because of the OS latency (an interrupt is still pending). In this
case, we assume the operation exited successfully.
We choose the second approach that is a must in all cases, with the
possibility to also modify the timeout value to be, e.g. at least 1
second in all cases.
Fixes: 02f26ecf8c ("mtd: nand: add reworked Marvell NAND controller driver")
Cc: stable@vger.kernel.org
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-01-09 17:38:37 +01:00
..
atmel
mtd: rawnand: atmel: fix OF child-node lookup
2018-11-27 16:13:10 +01:00
bcm47xxnflash
brcmnand
Char/Misc driver patches for 4.19-rc1
2018-08-18 11:04:51 -07:00
gpmi-nand
mtd: rawnand: gpmi: convert driver to nand_scan()
2018-07-31 09:45:58 +02:00
ams-delta.c
au1550nd.c
mtd: rawnand: au1550nd: Remove unneeded gpio.h inclusion
2018-07-31 09:45:54 +02:00
cafe_nand.c
mtd: rawnand: cafe: convert driver to nand_scan()
2018-07-31 09:46:07 +02:00
cmx270_nand.c
mtd: rawnand: use mtd_device_register() where applicable
2018-07-19 23:14:12 +02:00
cs553x_nand.c
mtd: rawnand: use mtd_device_register() where applicable
2018-07-19 23:14:12 +02:00
davinci_nand.c
mtd: rawnand: davinci: convert driver to nand_scan()
2018-07-31 09:45:55 +02:00
denali.c
mtd: rawnand: denali: set SPARE_AREA_SKIP_BYTES register to 8 if unset
2018-11-13 11:08:23 -08:00
denali.h
mtd: rawnand: denali: optimize timing parameters for data interface
2018-07-18 09:24:14 +02:00
denali_dt.c
mtd: rawnand: denali: optimize timing parameters for data interface
2018-07-18 09:24:14 +02:00
denali_pci.c
mtd: rawnand: denali: optimize timing parameters for data interface
2018-07-18 09:24:14 +02:00
diskonchip.c
mtd: rawnand: Kill the chip->scan_bbt() hook
2018-07-18 10:10:12 +02:00
docg4.c
mtd: rawnand: docg4: Remove wrong __init annotations
2018-08-27 10:16:56 +02:00
fsl_elbc_nand.c
mtd: rawnand: fsl_elbc: convert driver to nand_scan()
2018-07-31 09:45:57 +02:00
fsl_ifc_nand.c
mtd: rawnand: fsl_ifc: convert driver to nand_scan()
2018-07-31 09:45:57 +02:00
fsl_upm.c
fsmc_nand.c
mtd: rawnand: fsmc: convert driver to nand_scan()
2018-07-31 09:45:57 +02:00
gpio.c
hisi504_nand.c
mtd: rawnand: hisi504: convert driver to nand_scan()
2018-07-31 09:45:58 +02:00
jz4740_nand.c
mtd: rawnand: jz4740: convert driver to nand_scan()
2018-07-31 09:46:11 +02:00
jz4780_bch.c
jz4780_bch.h
jz4780_nand.c
mtd: rawnand: jz4780: convert driver to nand_scan()
2018-07-31 09:45:59 +02:00
Kconfig
mtd: rawnand: atmel: Select GENERIC_ALLOCATOR
2018-08-11 18:07:44 +02:00
lpc32xx_mlc.c
mtd: rawnand: lpc32xx_mlc: convert driver to nand_scan()
2018-07-31 09:46:07 +02:00
lpc32xx_slc.c
mtd: rawnand: lpc32xx_slc: convert driver to nand_scan()
2018-07-31 09:45:59 +02:00
Makefile
mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver
2018-07-02 09:02:06 +02:00
marvell_nand.c
mtd: rawnand: marvell: prevent timeouts on a loaded machine
2019-01-09 17:38:37 +01:00
mpc5121_nfc.c
mtk_ecc.c
mtd: rawnand: mtk: use of_device_get_match_data()
2018-04-29 08:56:41 +02:00
mtk_ecc.h
mtk_nand.c
mtd: rawnand: mtk: convert driver to nand_scan()
2018-07-31 09:46:00 +02:00
mxc_nand.c
mtd: rawnand: mxc: convert driver to nand_scan()
2018-07-31 09:46:01 +02:00
nand_amd.c
nand_base.c
mtd: rawnand: allocate dynamically ONFI parameters during detection
2018-08-01 09:45:59 +02:00
nand_bbt.c
mtd: rawnand: Rename nand_default_bbt() into nand_create_bbt()
2018-07-18 09:34:22 +02:00
nand_bch.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
nand_ecc.c
nand_hynix.c
mtd: rawnand: hynix: Use ->exec_op() in hynix_nand_reg_write_op()
2018-07-18 10:10:15 +02:00
nand_ids.c
nand_macronix.c
mtd: rawnand: All AC chips have a broken GET_FEATURES(TIMINGS).
2018-06-22 00:31:22 +02:00
nand_micron.c
mtd: rawnand: allocate dynamically ONFI parameters during detection
2018-08-01 09:45:59 +02:00
nand_samsung.c
nand_timings.c
mtd: rawnand: allocate dynamically ONFI parameters during detection
2018-08-01 09:45:59 +02:00
nand_toshiba.c
nandsim.c
mtd: rawnand: nandsim: convert driver to nand_scan()
2018-07-31 09:46:01 +02:00
ndfc.c
mtd: rawnand: better name for the controller structure
2018-07-31 09:45:52 +02:00
nuc900_nand.c
omap2.c
mtd: rawnand: omap2: convert driver to nand_scan()
2018-07-31 09:46:08 +02:00
omap_elm.c
orion_nand.c
mtd: rawnand: orion: Handle cases where __LINUX_ARM_ARCH__ is not defined
2018-07-31 09:45:51 +02:00
oxnas_nand.c
mtd: rawnand: better name for the controller structure
2018-07-31 09:45:52 +02:00
pasemi_nand.c
plat_nand.c
mtd: rawnand: plat_nand: Kill pdata->ctrl.{hwcontrol, read_byte}()
2018-07-18 10:10:12 +02:00
qcom_nandc.c
mtd: rawnand: qcom: Namespace prefix some commands
2018-12-13 09:16:13 +01:00
r852.c
r852.h
s3c2410.c
mtd: rawnand: s3c2410: convert driver to nand_scan()
2018-07-31 09:46:01 +02:00
sh_flctl.c
mtd: rawnand: sh_flctl: convert driver to nand_scan()
2018-07-31 09:46:02 +02:00
sharpsl.c
mtd: rawnand: sharpsl: Remove inclusion of mach and asm headers
2018-07-18 09:34:16 +02:00
sm_common.c
mtd: rawnand: sm_common: convert driver to nand_scan_with_ids()
2018-07-31 09:46:04 +02:00
sm_common.h
socrates_nand.c
sunxi_nand.c
mtd: rawnand: sunxi: convert driver to nand_scan()
2018-07-31 09:46:02 +02:00
tango_nand.c
mtd: rawnand: tango: convert driver to nand_scan()
2018-07-31 09:46:03 +02:00
tegra_nand.c
mtd: rawnand: tegra: convert driver to nand_scan()
2018-07-31 09:46:12 +02:00
tmio_nand.c
txx9ndfmc.c
mtd: rawnand: txx9ndfmc: convert driver to nand_scan()
2018-07-31 09:46:13 +02:00
vf610_nfc.c
mtd: rawnand: vf610: convert driver to nand_scan()
2018-07-31 09:46:04 +02:00
xway_nand.c