Hans Verkuil
0595e0d173
media: vb2: add waiting_in_dqbuf flag ...
commit d65842f7126aa1a87fb44b7c9980c12630ed4f33 upstream.
Calling VIDIOC_DQBUF can release the core serialization lock pointed to
by vb2_queue->lock if it has to wait for a new buffer to arrive.
However, if userspace dup()ped the video device filehandle, then it is
possible to read or call DQBUF from two filehandles at the same time.
It is also possible to call REQBUFS from one filehandle while the other
is waiting for a buffer. This will remove all the buffers and reallocate
new ones. Removing all the buffers isn't the problem here (that's already
handled correctly by DQBUF), but the reallocating part is: DQBUF isn't
aware that the buffers have changed.
This is fixed by setting a flag whenever the lock is released while waiting
for a buffer to arrive. And checking the flag where needed so we can return
-EBUSY.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Reported-by: Syzbot <syzbot+4180ff9ca6810b06c1e9@syzkaller.appspotmail.com>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-05-31 06:46:04 -07:00
media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS
2017-07-26 06:14:33 -04:00
media: include: media: Add Renesas CEU driver interface
2018-02-26 08:59:41 -05:00
media: i2c: lm3560: add support for lm3559 chip
2018-06-28 07:10:01 -04:00
media: include/(uapi/)media: add SPDX license info
2018-02-14 13:23:51 -05:00
media: cec-notifier: Get notifier by device and connector name
2018-07-13 08:44:16 +01:00
media: cec: add support for 5V signal testing
2018-07-25 07:11:48 -04:00
media: cec: keep track of outstanding transmits
2019-01-09 17:38:46 +01:00
media: dvb: update buffer mmaped flags and frame counter
2018-02-23 11:44:08 -05:00
media: dmxdev: Fix the logic that enables DMA mmap support
2018-02-23 05:27:10 -05:00
media: dvb: add alternative USB PID for Hauppauge WinTV-soloHD
2018-05-04 14:20:55 -04:00
media: move dvb kAPI headers to include/media
2017-12-28 13:16:01 -05:00
media: dvb: update buffer mmaped flags and frame counter
2018-02-23 11:44:08 -05:00
media: dvb: represent min/max/step/tolerance freqs in Hz
2018-08-02 18:10:48 -04:00
media: move dvb kAPI headers to include/media
2017-12-28 13:16:01 -05:00
media: move dvb kAPI headers to include/media
2017-12-28 13:16:01 -05:00
media: move dvb kAPI headers to include/media
2017-12-28 13:16:01 -05:00
media: dvb: update buffer mmaped flags and frame counter
2018-02-23 11:44:08 -05:00
media: dvbdev: add a mutex protecting the "mdev" pointer
2018-05-11 12:09:59 -04:00
[media] media: Add i.MX media core driver
2017-06-20 07:30:38 -03:00
media: media-device: remove driver_version
2017-08-08 06:02:22 -04:00
->poll() methods should return __poll_t
2017-11-27 16:19:52 -05:00
media: entity: fix spelling for media_entity_get_fwnode_pad()
2018-05-09 15:49:41 -04:00
media: rc: default to idle on at startup or after reset
2018-05-14 07:14:51 -04:00
media: rc: add new imon protocol decoder and encoder
2018-03-21 11:12:29 -04:00
v4l: rcar-fcp: Add an API to retrieve the FCP device
2017-06-09 12:25:36 +01:00
->poll() methods should return __poll_t
2017-11-27 16:19:52 -05:00
media: tuner-types: add kernel-doc markups for struct tunertype
2017-12-18 09:06:40 -05:00
[media] v4l2-mc.h: move tuner PAD definitions to this new header
2016-02-01 07:19:44 -02:00
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
media: fix usage of whitespaces and on indentation
2018-01-04 13:12:01 -05:00
media: Convert to using %pOF instead of full_name
2017-08-20 08:20:20 -04:00
media: v4l-common: Make v4l2_find_nearest_size more sparse-friendly
2018-06-28 09:23:56 -04:00
media: v4l2-ctrls.h: fix v4l2_ctrl field description typos
2018-07-25 08:36:05 -04:00
media: v4l2-core: push taking ioctl mutex down to ioctl handler
2018-05-28 16:31:44 -04:00
media: v4l2-device.h: always expose mdev
2018-05-11 11:26:56 -04:00
media: v4l2-dv-timings: add v4l2_hdmi_colorimetry()
2018-02-22 12:41:09 -05:00
media: fix usage of whitespaces and on indentation
2018-01-04 13:12:01 -05:00
media: v4l: event: Prevent freeing event subscriptions while accessed
2018-10-03 06:32:51 -04:00
media: v4l2-flash-led-class.h: add kernel-doc to two helper funcs
2017-12-18 10:40:41 -05:00
media: v4l: fwnode: Fix comment incorrectly mentioning v4l2_fwnode_parse_endpoint
2018-04-23 17:20:07 -04:00
[media] media: v4l2-image-sizes.h: correct the SVGA height definition
2014-12-04 13:56:56 -02:00
media: v4l2-ioctl: create helper to fill in v4l2_standard for ENUMSTD
2018-06-28 07:29:24 -04:00
[media] get rid of a number of problems at the cross references
2016-09-22 10:00:23 -03:00
media: v4l2-fwnode: parse 'data-enable-active' prop
2018-07-24 14:57:38 -04:00
media: v4l2-mem2mem: add v4l2_m2m_last_buf()
2018-07-25 08:10:31 -04:00
media: include/(uapi/)media: add SPDX license info
2018-02-14 13:23:51 -05:00
media: add tuner standby op, use where needed
2018-03-21 12:05:39 -04:00
MAINTAINERS & files: Canonize the e-mails I use at files
2018-05-04 06:21:06 -04:00
[media] videobuf-dma-contig: remove support for cached mem
2013-04-25 09:50:19 -03:00
MAINTAINERS & files: Canonize the e-mails I use at files
2018-05-04 06:21:06 -04:00
MAINTAINERS & files: Canonize the e-mails I use at files
2018-05-04 06:21:06 -04:00
media: vb2: add waiting_in_dqbuf flag
2019-05-31 06:46:04 -07:00
dma-mapping: use unsigned long for dma_attrs
2016-08-04 08:50:07 -04:00
[media] vb2: replace void *alloc_ctxs by struct device *alloc_devs
2016-07-08 14:45:07 -03:00
media: move dvb kAPI headers to include/media
2017-12-28 13:16:01 -05:00
media: vb2: add cross references at memops and v4l2 kernel-doc markups
2017-12-18 12:27:41 -05:00
media updates for v4.16-rc1
2018-02-06 11:27:48 -08:00
[media] media: videobuf2: Replace videobuf2-core with videobuf2-v4l2
2015-10-01 08:48:18 -03:00
media: vsp1: Support Interlaced display pipelines
2018-08-03 16:02:27 -04:00
0595e0d173