Al Viro
c939121b54
dcache: sort the freeing-without-RCU-delay mess for good.
...
commit 5467a68cbf6884c9a9d91e2a89140afb1839c835 upstream.
For lockless accesses to dentries we don't have pinned we rely
(among other things) upon having an RCU delay between dropping
the last reference and actually freeing the memory.
On the other hand, for things like pipes and sockets we neither
do that kind of lockless access, nor want to deal with the
overhead of an RCU delay every time a socket gets closed.
So delay was made optional - setting DCACHE_RCUACCESS in ->d_flags
made sure it would happen. We tried to avoid setting it unless
we knew we need it. Unfortunately, that had led to recurring
class of bugs, in which we missed the need to set it.
We only really need it for dentries that are created by
d_alloc_pseudo(), so let's not bother with trying to be smart -
just make having an RCU delay the default. The ones that do
*not* get it set the replacement flag (DCACHE_NORCU) and we'd
better use that sparingly. d_alloc_pseudo() is the only
such user right now.
FWIW, the race that finally prompted that switch had been
between __lock_parent() of immediate subdirectory of what's
currently the root of a disconnected tree (e.g. from
open-by-handle in progress) racing with d_splice_alias()
elsewhere picking another alias for the same inode, either
on outright corrupted fs image, or (in case of open-by-handle
on NFS) that subdirectory having been just moved on server.
It's not easy to hit, so the sky is not falling, but that's
not the first race on similar missed cases and the logics
for settinf DCACHE_RCUACCESS has gotten ridiculously
convoluted.
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-05-25 18:23:26 +02:00
..
caching
fscache: Pass object size in rather than calling back for it
2018-04-06 14:05:14 +01:00
cifs
smb3: update readme to correct information about /proc/fs/cifs/Stats
2018-08-07 14:20:23 -05:00
configfs
fs: configfs: don't return anything from drop_link
2016-12-01 10:50:49 +01:00
ext4
docs: fix up the obviously obsolete bits in the new ext4 documentation
2018-07-29 16:35:23 -04:00
nfs
ipconfig: Write NTP server IPs to /proc/net/ipconfig/ntp_servers
2018-04-24 13:40:42 -04:00
pohmelfs
Documentation: fix common spelling mistakes
2016-04-28 07:51:59 -06:00
00-INDEX
Staging/IIO patches for 4.18-rc1
2018-06-09 10:32:39 -07:00
9p.txt
9p: update documentation
2014-01-24 10:55:21 -06:00
adfs.txt
affs.txt
affs: add mount option to avoid filename truncates
2014-04-07 16:36:08 -07:00
afs.txt
afs: Implement @sys substitution handling
2018-04-09 21:12:31 +01:00
autofs-mount-control.txt
autofs: use autofs instead of autofs4 in documentation
2018-06-07 17:34:39 -07:00
autofs.txt
autofs: use autofs instead of autofs4 in documentation
2018-06-07 17:34:39 -07:00
automount-support.txt
autofs: use autofs instead of autofs4 in documentation
2018-06-07 17:34:39 -07:00
befs.txt
bfs.txt
Tigran has moved
2017-05-12 15:57:15 -07:00
btrfs.txt
Documentation: btrfs: remove usage specific information
2016-03-11 17:02:09 +01:00
ceph.txt
ceph: update description of some mount options
2018-06-04 20:46:02 +02:00
coda.txt
conf.py
docs-rst: convert filesystems book to ReST
2017-05-16 08:44:08 -03:00
cramfs.txt
cramfs: rehabilitate it
2017-10-15 00:47:23 -04:00
dax.txt
powerpc/cell: Remove axonram driver
2018-01-28 17:00:36 +11:00
debugfs.txt
debugfs: Pass bool pointer to debugfs_create_bool()
2015-10-04 11:36:07 +01:00
devpts.txt
devpts: Make each mount of devpts an independent filesystem.
2016-06-05 10:36:01 -07:00
directory-locking
vfs: remove unused i_op->rename
2016-09-27 11:03:58 +02:00
dlmfs.txt
ocfs2: update web page + git tree in documentation
2015-02-28 09:57:50 -08:00
dnotify.txt
Documentation: fix selftests related file refs
2017-10-19 12:58:21 -06:00
ecryptfs.txt
efivarfs.txt
efi: Make efivarfs entries immutable by default
2016-02-10 16:25:52 +00:00
exofs.txt
ext2.txt
fs/*/Kconfig: drop links to 404-compliant http://acl.bestbits.at
2018-01-01 12:45:37 -07:00
ext3.txt
fs: Remove ext3 filesystem driver
2015-07-23 20:59:40 +02:00
f2fs.txt
f2fs: support fault_type mount option
2018-08-13 10:48:17 -07:00
fiemap.txt
fsioctl.c: make generic_block_fiemap() signal-tolerant
2015-02-10 14:30:30 -08:00
files.txt
fscrypt.rst
crypto: speck - remove Speck
2018-11-13 11:08:46 -08:00
fuse-io.txt
fuse: add writeback documentation
2018-03-20 17:11:45 +01:00
fuse.txt
gfs2-glocks.txt
GFS2: Minor improvements to comments and documentation
2018-04-12 10:07:51 -07:00
gfs2-uevents.txt
gfs2.txt
hfs.txt
hfsplus.txt
Documentation: update URL to hfsplus Technote 1150
2014-02-20 14:48:51 +01:00
hpfs.txt
index.rst
docs: create filesystem internal section
2018-07-29 16:14:02 -04:00
inotify.txt
inotify: update documentation to reflect code changes
2015-02-10 14:30:28 -08:00
isofs.txt
jfs.txt
doc: fix misspellings with 'codespell' tool
2013-05-28 12:02:12 +02:00
Locking
overlayfs update for 4.19
2018-08-21 18:19:09 -07:00
locks.txt
docs: fix locations of several documents that got moved
2016-10-24 08:12:35 -02:00
mandatory-locking.txt
nilfs2.txt
MAINTAINERS, nilfs2: change project home URLs
2018-01-13 10:42:48 -08:00
ntfs.txt
NTFS: Remove changelog from Documentation/filesystems/ntfs.txt.
2014-10-16 12:43:57 +01:00
ocfs2-online-filecheck.txt
Doc: ocfs: Fix typo in filesystems/ocfs2-online-filecheck.txt
2016-07-01 16:17:15 -06:00
ocfs2.txt
ocfs2: update web page + git tree in documentation
2015-02-28 09:57:50 -08:00
omfs.txt
orangefs.txt
Orangefs: documentation updates
2018-04-04 14:05:48 -04:00
overlayfs.txt
ovl: automatically enable redirect_dir on metacopy=on
2018-11-21 09:19:13 +01:00
path-lookup.md
autofs: use autofs instead of autofs4 in documentation
2018-06-07 17:34:39 -07:00
path-lookup.txt
Documentation: add new description of path-name lookup.
2015-11-02 18:18:25 -07:00
porting
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
proc.txt
mm, proc: be more verbose about unstable VMA flags in /proc/<pid>/smaps
2019-01-26 09:32:44 +01:00
qnx6.txt
Documentation: fix common spelling mistakes
2016-04-28 07:51:59 -06:00
quota.txt
scripts/spelling.txt: add "an user" pattern and fix typo instances
2017-02-27 18:43:46 -08:00
ramfs-rootfs-initramfs.txt
initramfs: move gen_initramfs_list.sh from scripts/ to usr/
2018-08-22 23:21:44 +09:00
relay.txt
Documentation : Update relay function types
2018-07-10 15:11:00 -06:00
romfs.txt
seq_file.txt
fs/seq_file.c: simplify seq_file iteration code and interface
2018-08-17 16:20:28 -07:00
sharedsubtree.txt
doc: fix grammar
2016-03-09 15:33:06 -07:00
spufs.txt
squashfs.txt
Squashfs: Add LZ4 compression configuration option
2014-11-27 18:48:44 +00:00
sysfs-pci.txt
PCI: Add pci_mmap_resource_range() and use it for ARM64
2017-04-20 08:47:47 -05:00
sysfs-tagging.txt
sysfs-tagging.txt: fix pre-kernfs references
2015-09-13 14:38:51 -06:00
sysfs.txt
kallsyms: remove print_symbol() function
2018-01-16 16:59:55 +01:00
sysv-fs.txt
tmpfs.txt
docs/vm: move numa_memory_policy.rst to Documentation/admin-guide/mm
2018-05-08 09:31:31 -06:00
ubifs.txt
udf.txt
udf: Remove never implemented mount options
2018-02-27 10:25:33 +01:00
ufs.txt
vfat.txt
Documentation/filesystems/vfat.txt: fix a remark that implies UCS2
2017-12-21 13:39:28 -07:00
vfs.txt
vfs: add the fadvise() file operation
2018-08-30 17:08:35 +02:00
xfs-delayed-logging-design.txt
xfs-self-describing-metadata.txt
xfs: add metadata CRC documentation
2013-04-27 13:27:43 -05:00
xfs.txt
xfs: remove deprecated barrier/nobarrier mount
2018-07-26 10:15:17 -07:00