Eric Dumazet
00b13445f9
rcu: Avoid data-race in rcu_gp_fqs_check_wake() ...
commit 6935c3983b246d5fbfebd3b891c825e65c118f2d upstream.
The rcu_gp_fqs_check_wake() function uses rcu_preempt_blocked_readers_cgp()
to read ->gp_tasks while other cpus might overwrite this field.
We need READ_ONCE()/WRITE_ONCE() pairs to avoid compiler
tricks and KCSAN splats like the following :
BUG: KCSAN: data-race in rcu_gp_fqs_check_wake / rcu_preempt_deferred_qs_irqrestore
write to 0xffffffff85a7f190 of 8 bytes by task 7317 on cpu 0:
rcu_preempt_deferred_qs_irqrestore+0x43d/0x580 kernel/rcu/tree_plugin.h:507
rcu_read_unlock_special+0xec/0x370 kernel/rcu/tree_plugin.h:659
__rcu_read_unlock+0xcf/0xe0 kernel/rcu/tree_plugin.h:394
rcu_read_unlock include/linux/rcupdate.h:645 [inline]
__ip_queue_xmit+0x3b0/0xa40 net/ipv4/ip_output.c:533
ip_queue_xmit+0x45/0x60 include/net/ip.h:236
__tcp_transmit_skb+0xdeb/0x1cd0 net/ipv4/tcp_output.c:1158
__tcp_send_ack+0x246/0x300 net/ipv4/tcp_output.c:3685
tcp_send_ack+0x34/0x40 net/ipv4/tcp_output.c:3691
tcp_cleanup_rbuf+0x130/0x360 net/ipv4/tcp.c:1575
tcp_recvmsg+0x633/0x1a30 net/ipv4/tcp.c:2179
inet_recvmsg+0xbb/0x250 net/ipv4/af_inet.c:838
sock_recvmsg_nosec net/socket.c:871 [inline]
sock_recvmsg net/socket.c:889 [inline]
sock_recvmsg+0x92/0xb0 net/socket.c:885
sock_read_iter+0x15f/0x1e0 net/socket.c:967
call_read_iter include/linux/fs.h:1864 [inline]
new_sync_read+0x389/0x4f0 fs/read_write.c:414
read to 0xffffffff85a7f190 of 8 bytes by task 10 on cpu 1:
rcu_gp_fqs_check_wake kernel/rcu/tree.c:1556 [inline]
rcu_gp_fqs_check_wake+0x93/0xd0 kernel/rcu/tree.c:1546
rcu_gp_fqs_loop+0x36c/0x580 kernel/rcu/tree.c:1611
rcu_gp_kthread+0x143/0x220 kernel/rcu/tree.c:1768
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 10 Comm: rcu_preempt Not tainted 5.3.0+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
[ paulmck: Added another READ_ONCE() for RCU CPU stall warnings. ]
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-02-11 04:33:55 -08:00
bpf, offload: Unlock on error in bpf_offload_dev_create()
2020-01-27 14:51:20 +01:00
cgroup: Prevent double killing of css when enabling threaded cgroup
2020-02-05 14:43:39 +00:00
kconfig: tinyconfig: remove stale stack protector fixups
2018-06-15 07:15:28 +09:00
kdb: do a sanity check on the cpu in kdb_per_cpu()
2020-01-27 14:50:48 +01:00
dma-debug: add a schedule point in debug_dma_dump_mappings()
2020-01-04 19:12:43 +01:00
perf/ioctl: Add check for the sample_period value
2020-01-27 14:50:57 +01:00
gcov: remove CONFIG_GCOV_FORMAT_AUTODETECT
2018-06-08 18:56:02 +09:00
irqdomain: Add the missing assignment of domain->fwnode for named fwnode
2020-01-27 14:51:09 +01:00
livepatch: Nullify obj->mod in klp_module_coming()'s error path
2019-10-07 18:57:10 +02:00
locking/spinlock/debug: Fix various data races
2020-01-12 12:17:05 +01:00
PM / hibernate: memory_bm_find_bit(): Tighten node optimisation
2020-01-09 10:18:58 +01:00
printk: fix exclusive_console replaying
2020-02-11 04:33:51 -08:00
rcu: Avoid data-race in rcu_gp_fqs_check_wake()
2020-02-11 04:33:55 -08:00
sched/fair: Fix insertion in rq->leaf_cfs_rq_list
2020-02-01 09:37:10 +00:00
tick/sched: Annotate lockless access to last_jiffies_update
2020-01-23 08:21:37 +01:00
tracing: Fix sched switch start/stop refcount racy updates
2020-02-11 04:33:55 -08:00
acct_on(): don't mess with freeze protection
2019-05-31 06:46:05 -07:00
kernel/async.c: revert "async: simplify lowest_in_progress()"
2018-02-06 18:32:44 -08:00
audit: use ktime_get_coarse_real_ts64() for timestamps
2018-07-17 14:45:08 -04:00
audit: track the owner of the command mutex ourselves
2018-02-23 11:22:22 -05:00
fsnotify: add fsnotify_add_inode_mark() wrappers
2018-05-18 14:58:22 +02:00
audit: Embed key into chunk
2019-12-13 08:51:11 +01:00
audit_get_nd(): don't unlock parent too early
2019-12-13 08:51:02 +01:00
audit: fix a memory leak bug
2019-05-31 06:46:17 -07:00
audit: print empty EXECVE args
2019-12-01 09:17:17 +01:00
kbuild: fix kernel/bounds.c 'W=1' warning
2018-11-13 11:08:47 -08:00
LSM: generalize flag passing to security_capable
2020-01-23 08:21:29 +01:00
time: Enable get/put_compat_itimerspec64 always
2018-06-24 14:39:47 +02:00
cpu/SMT: State SMT is disabled even with nosmt and without "=force"
2019-11-24 08:20:18 +01:00
kernel/crash_core.c: print timestamp using time64_t
2018-08-22 10:52:47 -07:00
memcg: account security cred as well to kmemcg
2020-01-09 10:19:00 +01:00
delayacct: Use raw_spinlocks
2018-04-27 14:34:51 +02:00
proc: introduce proc_create_single{,_data}
2018-05-16 07:23:35 +02:00
kernel/elfcore.c: include proper prototypes
2019-10-11 18:21:23 +02:00
proc: introduce proc_create_single{,_data}
2018-05-16 07:23:35 +02:00
exit: panic before exit_mm() on global init exit
2020-01-09 10:19:02 +01:00
extable: Make init_kernel_text() global
2018-02-21 16:54:06 +01:00
bpf/error-inject/kprobes: Clear current_kprobe and enable preempt in kprobe
2018-06-21 12:33:19 +02:00
fork,memcg: alloc_thread_stack_node needs to set tsk->stack
2020-01-27 14:50:58 +01:00
PM / reboot: Eliminate race between reboot and suspend
2018-08-06 12:35:20 +02:00
futex: Prevent robust futex exit race
2019-12-01 09:17:38 +01:00
kernel: make groups_sort calling a responsibility group_info allocators
2017-12-14 16:00:49 -08:00
kernel: hung_task.c: disable on suspend
2019-04-20 09:16:02 +02:00
memremap: split devm_memremap_pages() and memremap() infrastructure
2018-05-15 23:08:33 -07:00
irq_work: Do not raise an IPI when queueing work on the local CPU
2019-05-31 06:46:19 -07:00
jump_label: move 'asm goto' support test to Kconfig
2019-06-04 08:02:34 +02:00
kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol
2019-09-21 07:17:02 +02:00
kconfig: include kernel/Kconfig.preempt from init/Kconfig
2018-08-02 08:06:54 +09:00
kernel/kcov.c: mark write_comp_data() as notrace
2019-02-12 19:47:20 +01:00
kexec: add call to LSM hook in original kexec_load syscall
2018-07-16 12:31:57 -07:00
kexec: Allocate decrypted control pages for kdump if SME is enabled
2019-11-24 08:20:29 +01:00
treewide: Use array_size() in vzalloc()
2018-06-12 16:19:22 -07:00
kprobes: Blacklist symbols in arch-defined prohibited area
2019-12-05 09:20:26 +01:00
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2018-08-13 11:25:07 -07:00
y2038: futex: Move compat implementation into futex.c
2019-12-01 09:17:38 +01:00
mm/memory_hotplug: shrink zones when offlining memory
2020-01-29 16:43:27 +01:00
modsign: log module name in the event of an error
2018-07-02 11:36:17 +02:00
kernel/module: Fix memleak in module_add_modinfo_attrs()
2020-02-11 04:33:50 -08:00
modsign: log module name in the event of an error
2018-07-02 11:36:17 +02:00
padata: use smp_mb in padata_reorder to avoid orphaned padata jobs
2019-07-26 09:14:25 +02:00
kernel/panic.c: do not append newline to the stack protector panic string
2019-12-01 09:17:10 +01:00
kernel/params.c: downgrade warning for unsafe parameters
2018-04-11 10:28:37 -07:00
Fix failure path in alloc_pid()
2019-01-13 09:51:06 +01:00
signal/pid_namespace: Fix reboot_pid_ns to use send_sig not force_sig
2019-07-26 09:14:01 +02:00
ptrace: reintroduce usage of subjective credentials in ptrace_has_cap()
2020-01-23 08:21:29 +01:00
PM / reboot: Eliminate race between reboot and suspend
2018-08-06 12:35:20 +02:00
relay: check return of create_buf_file() properly
2019-03-13 14:02:35 -07:00
resource: fix locking in find_next_iomem_res()
2019-09-16 08:22:20 +02:00
rseq: uapi: Declare rseq_cs field as union, update includes
2018-07-10 22:18:52 +02:00
LSM: generalize flag passing to security_capable
2020-01-23 08:21:29 +01:00
signal: Allow cifs and drbd to receive their terminating signals
2020-01-27 14:51:05 +01:00
cpu/hotplug: Fix "SMT disabled by BIOS" detection for KVM
2019-02-12 19:47:25 +01:00
smpboot: Remove cpumask from the API
2018-07-03 09:20:44 +02:00
nohz: Fix missing tick reprogram when interrupting an inline softirq
2018-08-03 15:52:10 +02:00
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2018-08-13 11:25:07 -07:00
kernel/sys.c: prctl: fix false positive in validate_prctl_map()
2019-06-15 11:54:01 +02:00
Merge branch 'core-rseq-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2018-06-10 10:17:09 -07:00
kernel: sysctl: make drop_caches write-only
2020-01-04 19:13:17 +01:00
staging: irda: remove remaining remants of irda code removal
2018-04-16 11:26:49 +02:00
locking/barriers: Convert users of lockless_dereference() to READ_ONCE()
2017-12-17 13:57:15 +01:00
taskstats: fix data-race
2020-01-09 10:18:59 +01:00
kprobes: Remove jprobe API implementation
2018-06-21 12:33:05 +02:00
torture: Keep old-school dmesg format
2018-06-25 11:30:10 -07:00
tracepoint: Fix tracepoint array element size mismatch
2018-10-17 15:35:29 -04:00
headers: untangle kmemleak.h from mm.h
2018-04-05 21:36:27 -07:00
fs: add do_fchownat(), ksys_fchown() helpers and ksys_{,l}chown() wrappers
2018-04-02 20:15:59 +02:00
kernel: provide ksys_*() wrappers for syscalls called by kernel/uid16.c
2018-04-02 20:15:30 +02:00
umh: fix race condition
2018-06-07 16:56:28 -04:00
userns: use irqsave variant of refcount_dec_and_lock()
2018-08-22 10:52:47 -07:00
userns: also map extents in the reverse map to kernel IDs
2018-11-13 11:09:00 -08:00
uts: create "struct uts_namespace" from kmem_cache
2018-04-11 10:28:35 -07:00
sys: don't hold uts_sem while accessing userspace memory
2018-08-11 02:05:53 -05:00
watchdog: Respect watchdog cpumask on CPU hotplug
2019-04-03 06:26:29 +02:00
watchdog: Mark watchdog touch functions as notrace
2018-08-30 12:56:40 +02:00
workqueue: Fix missing kfree(rescuer) in destroy_workqueue()
2019-12-17 20:35:50 +01:00
workqueue: Set worker->desc to workqueue name by default
2018-05-18 08:47:13 -07:00
00b13445f9