Message	SHA1
hwrng: Make explicit that max >= 32 always ... As hw_random core calls ->read with max > 32 or more, make it explicit. Also remove checks involving 'max' being less than 8. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> PrasannaKumar Muralidharan   authored and   Herbert Xu   commited 2016-11-21 22:50:45 +08:00	ed424bb368
hwrng: core - Improve description of the ->read() interface ... Currently, very few RNG drivers support single byte reads using the ->read() interface. Of the 14 drivers in drivers/char/hw_random that support this interface only three of these actually support max == 1. The other behaviours vary between return 0, return 2, return 4 and return -EIO). This is not a problem in practice because the core hw_random code never performs a read shorter than 16 bytes. The documentation for this function already contrains the alignment of the buffer pointer, so let's also guarantee that the buffer is at least as large as its alignment. This constraint is intended to be the weakest guarantee neccessary to allow driver writers to safely simplify their code. Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Daniel Thompson   authored and   Herbert Xu   commited 2016-08-24 21:04:48 +08:00	ed0bd721c9
hwrng: add devm_* interfaces ... This change adds devm_hwrng_register and devm_hwrng_unregister which use can simplify error unwinding and unbinding code paths in device drivers. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Dmitry Torokhov   authored and   Herbert Xu   commited 2015-03-16 21:45:54 +11:00	4d9b519c9b
hwrng: core - Use struct completion for cleanup_done ... There is no point in doing a manual completion for cleanup_done when struct completion fits in perfectly. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Herbert Xu   commited 2014-12-26 08:33:34 +11:00	77584ee574
hwrng: fix unregister race. ... The previous patch added one potential problem: we can still be reading from a hwrng when it's unregistered. Add a wait for zero in the hwrng_unregister path. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Amos Kong <akong@redhat.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Rusty Russell   authored and   Herbert Xu   commited 2014-12-22 23:02:40 +11:00	a027f30d72
hwrng: use reference counts on each struct hwrng. ... current_rng holds one reference, and we bump it every time we want to do a read from it. This means we only hold the rng_mutex to grab or drop a reference, so accessing /sys/devices/virtual/misc/hw_random/rng_current doesn't block on read of /dev/hwrng. Using a kref is overkill (we're always under the rng_mutex), but a standard pattern. This also solves the problem that the hwrng_fillfn thread was accessing current_rng without a lock, which could change (eg. to NULL) underneath it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Amos Kong <akong@redhat.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Rusty Russell   authored and   Herbert Xu   commited 2014-12-22 23:02:39 +11:00	3a2c0ba5ad
hwrng: add per-device entropy derating ... This patch introduces a derating factor to struct hwrng for the random bits going into the kernel input pool, and a common default derating for drivers which do not specify one. Signed-off-by: Torsten Duwe <duwe@suse.de> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Acked-by: H. Peter Anvin <hpa@zytor.com> Torsten Duwe   authored and   Theodore Ts'o   commited 2014-07-15 04:49:40 -04:00	0f734e6e76
random: add_hwgenerator_randomness() for feeding entropy from devices ... This patch adds an interface to the random pool for feeding entropy in-kernel. Signed-off-by: Torsten Duwe <duwe@suse.de> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Acked-by: H. Peter Anvin <hpa@zytor.com> Torsten Duwe   authored and   Theodore Ts'o   commited 2014-07-15 04:49:40 -04:00	c84dbf61a7
hwrng: fix spelling mistake in header comment ... Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Matt Mackall <mpm@selenic.com> Signed-off-by: Sasha Levin <levinsasha928@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Sasha Levin   authored and   Jiri Kosina   commited 2011-05-25 14:15:12 +02:00	988acec9ee
hwrng: core - Replace u32 in driver API with byte array ... This patch implements a new method by which hw_random hardware drivers can pass data to the core more efficiently, using a shared buffer. The old methods have been retained as a compatability layer until all the drivers have been updated. Signed-off-by: Ian Molton <ian.molton@collabora.co.uk> Acked-by: Matt Mackall <mpm@selenic.com> Acked-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Ian Molton   authored and   Herbert Xu   commited 2009-12-01 14:47:32 +08:00	9996508b33
Remove "#ifdef __KERNEL__" checks from unexported headers ... Remove the "#ifdef __KERNEL__" tests from unexported header files in linux/include whose entire contents are wrapped in that preprocessor test. Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> Cc: David Woodhouse <dwmw2@infradead.org> Cc: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Robert P. J. Day   authored and   Linus Torvalds   commited 2008-04-30 08:29:54 -07:00	735643ee6c
PM: Remove destroy_suspended_device() ... After 2.6.24 there was a plan to make the PM core acquire all device semaphores during a suspend/hibernation to protect itself from concurrent operations involving device objects. That proved to be too heavy-handed and we found a better way to achieve the goal, but before it happened, we had introduced the functions device_pm_schedule_removal() and destroy_suspended_device() to allow drivers to "safely" destroy a suspended device and we had adapted some drivers to use them. Now that these functions are no longer necessary, it seems reasonable to remove them and modify their users to use the normal device unregistration instead. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Rafael J. Wysocki   authored and   Greg Kroah-Hartman   commited 2008-04-19 19:10:28 -07:00	b844eba292
HWRNG: add possibility to remove hwrng devices during suspend/resume ... Make it possible to unregister a Hardware Random Number Generator device object in a safe way during a suspend/resume cycle. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Acked-by: Michael Buesch <mb@bu3sch.de> Cc: Michael Buesch <mb@bu3sch.de> Cc: Pavel Machek <pavel@ucw.cz> Cc: "John W. Linville" <linville@tuxdriver.com> Cc: Alan Stern <stern@rowland.harvard.edu> Cc: Len Brown <lenb@kernel.org> Cc: Greg KH <greg@kroah.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Richard Purdie <rpurdie@rpsys.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Rafael J. Wysocki   authored and   Linus Torvalds   commited 2008-02-05 09:44:23 -08:00	a41e3dc406
[HWRNG]: move status polling loop to data_present callbacks ... Handle waiting for new random within the drivers themselves, this allows to use better suited timeouts for the individual rngs. Signed-off-by: Patrick McHardy <kaber@trash.net> Acked-by: Michael Buesch <mb@bu3sch.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Patrick McHardy   authored and   Herbert Xu   commited 2008-01-11 08:16:16 +11:00	984e976f53
[PATCH] Add new generic HW RNG core ... Signed-off-by: Michael Buesch <mb@bu3sch.de> Cc: Jeff Garzik <jeff@garzik.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> Michael Buesch   authored and   Linus Torvalds   commited 2006-06-26 09:58:19 -07:00	844dd05fec