From e1b4f0e88b8b9920aca490495b6a88845b21eef7 Mon Sep 17 00:00:00 2001 From: fukiame Date: Wed, 23 Jul 2025 02:24:49 +0700 Subject: [PATCH] fix: mbcpapp.sh: use ls for glob existence checking In mbcpapp.sh line 78: if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apk ] ^----------------------------^ SC2144 (error): -f doesn't work with globs. Use a for loop. In mbcpapp.sh line 169: if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apks ] ^-----------------------------^ SC2144 (error): -f doesn't work with globs. Use a for loop. we do not care about the actual result, we just need to know whether the files exist, tis probably fine Signed-off-by: fukiame --- MBCPApp/mbcpapp.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MBCPApp/mbcpapp.sh b/MBCPApp/mbcpapp.sh index 41eee3f..38e440c 100755 --- a/MBCPApp/mbcpapp.sh +++ b/MBCPApp/mbcpapp.sh @@ -69,7 +69,7 @@ do elif [ "$opt" == 'Unpack APK' ]; then # Check if *.apk exists - if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apk ] + if ls ~/mbbpatch/MBCPApp/mbapk/*.apk >/dev/null 2>&1 then # Check if apk is unpacked or not if [ -d ~/mbbpatch/MBCPApp/mbapk/mbapk_unpacked ] @@ -162,7 +162,7 @@ fi elif [ "$opt" == 'Convert apks to apk' ]; then - if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apks ] + if ls ~/mbbpatch/MBCPApp/mbapk/*.apks >/dev/null 2>&1 then echo "Converting apks to apk..." java -jar tools/APKEditor-1.4.3.jar m -i mbapk/*.apks