From 428843de55db4c91c64437e29cb0ec1c347b33b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20=C5=BBenczykowski?= Date: Thu, 23 Apr 2020 12:43:44 -0700 Subject: [PATCH] libbpf_android/Loader - fixes performance-faster-string-find warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: system/bpf/libbpf_android/Loader.cpp:557:49: warning: 'find_last_of' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find] name = name.substr(0, name.find_last_of("$")); ^~~ '$' Test: builds Bug: 153035880 Signed-off-by: Maciej Żenczykowski Change-Id: Iea62a59380c155796a7fa2ac4ca3352f9236ba98 --- libbpf_android/Loader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libbpf_android/Loader.cpp b/libbpf_android/Loader.cpp index d2a502d..7431fa2 100644 --- a/libbpf_android/Loader.cpp +++ b/libbpf_android/Loader.cpp @@ -554,7 +554,7 @@ static int loadCodeSections(const char* elfPath, vector& cs, const // strip any potential $foo suffix // this can be used to provide duplicate programs // conditionally loaded based on running kernel version - name = name.substr(0, name.find_last_of("$")); + name = name.substr(0, name.find_last_of('$')); bool reuse = false; // Format of pin location is