No description. Add one?
  • Java 78%
  • Kotlin 11.8%
  • AIDL 4.4%
  • C++ 3.7%
  • C 1.5%
  • Other 0.5%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Lorenzo Colitti d2bd9db36a Don't check validation state in waitForAvailable(..., Network).
The version of ConnectivityManagerTest#waitForAvailable that
takes a callback and a Network implicitly requires that the
network be validated, because it calls expectAvailableCallbacks
with validated=true.

This is incorrect because a network can become available without
being validated. In particular, testMobileDataPreferredUids is
flaky due to this problem, because it calls connectToCell, which
does not wait for validation, and then calls waitForAvailable,
which expects that the network is already validated.

Fix it by not requiring any particular validation state. This
method is only used by a few tests and they should not be
affected by this change:
- The first two calls in testSetOemNetworkPreferenceForTestPref
  happen after waiting for validation, so the network is
  validated already. The third call waits for a test network,
  and test networks are always validated.
- The first call in testSetOemNetworkPreferenceForTestOnlyPref
  waits for a test network, which is always validated. The
  second is incorrect because ensureWifiConnected does not
  wait for validation, and is fixed by this CL.
- The calls in testMobileDataPreferredUids similarly incorrectly
  assume that wifi is validated and are fixed by this CL.

Test: atest CtsNetTestCases:android.net.cts.ConnectivityManagerTest#testMobileDataPreferredUids
Change-Id: I614d0ba87c3931fcbe4011fed379e1736f5c4a44
2022-02-17 18:29:11 +09:00
bpf_progs Change gid of cgroupskb/<ingress|egress>/stats 2022-02-09 10:53:50 +08:00
framework Merge "Add new methods to redact NetworkCapabilities & LinkProperties" 2022-02-12 11:56:36 +00:00
framework-t Fix tab by replacing it with spaces 2022-02-11 13:52:29 +08:00
nearby Add OWNERS for Nearby code 2022-02-10 15:27:29 +09:00
netd [LSC] Add LOCAL_LICENSE_KINDS to packages/modules/Connectivity 2022-02-10 10:57:23 -08:00
service Merge "Add new methods to redact NetworkCapabilities & LinkProperties" 2022-02-12 11:56:36 +00:00
service-t Move IpSec APIs to Connectivity module 2022-02-10 14:25:04 +08:00
tests Don't check validation state in waitForAvailable(..., Network). 2022-02-17 18:29:11 +09:00
Tethering Merge "Move IpSec APIs to Connectivity module" 2022-02-10 11:45:21 +00:00
.gitignore Add a .gitignore in packages/modules/Connectivity. 2020-11-27 18:09:21 +09:00
OWNERS Add additional IPsec owners 2021-12-08 06:57:51 +00:00
OWNERS_core_networking add prohr to OWNERS_core_networking 2022-01-11 18:54:31 +00:00
OWNERS_core_networking_xts Add an OWNERS_core_networking_xts for CTS/GTS/... and use it. 2022-01-18 01:42:39 +00:00
PREUPLOAD.cfg Enable tethering to perform its own hidden API processing 2021-06-28 23:41:38 +01:00
TEST_MAPPING [NETD-BPF#19] Mainline part of bpf code from netd 2022-01-30 09:51:25 +08:00