No description. Add one?
  • Java 78%
  • Kotlin 11.8%
  • AIDL 4.4%
  • C++ 3.7%
  • C 1.5%
  • Other 0.5%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Maciej Żenczykowski bdccc50824 allow ingress TCP FINs in doze mode
I don't know if this will truly help:

We'll still drop the expected egress TCP ACK (or FIN-ACK) reply
to the newly allowed ingress TCP FIN...

However: I don't think this will make things worse.

The presence of an ingress packet is proof the hardware already woke up to receive it.  This behaviour doesn't change when allowing ingress *anything*.

ie. the main reason we don't allow ingress packets is
that it would be illogical to be asymmetrical.

So even if we do immediately send back a reply (I think a RST is the only real possibility at the moment, since ACK would still be dropped).  Worst case we're waking the hardware up from RX processing to full blown TX processing.

Furthermore if an inbound FIN causes an outbound RST, then that
RST will most likely prevent receiving future FIN retransmits.

So we're trading an RX->TX hardware wake up now,
for less RX wakeups in the (near) future.

This *might* just be an overall win.

I think a true solution likely needs to be smarter still
and allow skb->sk state != BPF_TCP_ESTABLISHED (or something)

Bug: 259199087
Bug: 264903985
Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I143f12342f72d89f9450560c8d60dad4c79ffe64
2023-04-18 07:05:00 +00:00
bpf_progs allow ingress TCP FINs in doze mode 2023-04-18 07:05:00 +00:00
common Fix errorprone warnings that should be errors 2022-11-02 10:13:14 -07:00
Cronet Merge "Cronet: enable CronetInputStreamTests" 2023-04-17 10:46:14 +00:00
framework Merge "Separate events usage for starting socket keepalives" 2023-04-17 02:32:00 +00:00
framework-t Merge changes from topic "statsaccess" 2023-04-14 09:54:49 +00:00
nearby Merge "Tests: update suite_name.py to latest mobly" 2023-03-29 03:18:06 +00:00
netd enforce 4.14+ instead of program being present 2023-02-22 22:10:48 +00:00
service Merge "clat: make sure the tun device doesn't yet exist" 2023-04-17 19:41:20 +00:00
service-t Merge changes from topic "revert-2535219-TAMNEZLAHT" 2023-04-18 02:53:21 +00:00
tests Merge changes from topic "revert-2535219-TAMNEZLAHT" 2023-04-18 02:53:21 +00:00
Tethering Merge "Address comment from aosp/2335004" 2023-04-18 05:45:42 +00:00
tools gn2bp: delete obsolete version in p/m/C 2023-03-29 16:23:45 -07:00
.gitignore Add a .gitignore in packages/modules/Connectivity. 2020-11-27 18:09:21 +09:00
OWNERS Add additional IPsec owners 2021-12-08 06:57:51 +00:00
OWNERS_core_networking Cleanup OWNERS 2023-01-23 15:55:23 +00:00
OWNERS_core_networking_xts Allow jchalard@, maze@ and reminv@ to approve fixes for flaky tests. 2022-10-06 09:06:20 +00:00
PREUPLOAD.cfg Enable tethering to perform its own hidden API processing 2021-06-28 23:41:38 +01:00
TEST_MAPPING [Cronet] Filter out large tests from presubmit 2023-04-03 18:10:01 +00:00