No description. Add one?
- Java 78%
- Kotlin 11.8%
- AIDL 4.4%
- C++ 3.7%
- C 1.5%
- Other 0.5%
| Filename | Latest commit message | Latest commit date |
|---|---|---|
6bd25b5fd4
Uses 16KiB ram, only caches ifindex < 1024, but in practice that should usually be the case, as these are assigned in sequential order by the kernel. Note that in progs/netd.c:86 we have: DEFINE_BPF_MAP_NO_NETD(iface_index_name_map, HASH, uint32_t, IfaceValue, 1000) so stuff doesn't really work right once we go past 1000-ish tracked interfaces... (and worst case we're no worse off then we are now...) Benefit should be significant as all our bpf map stats dumping logic has to convert from ifindex to ifname in order to strcmp against the interface we're trying to match, ie. that's the first thing 3 of the 4 cases we support do at the very top of their innermost loop. This effectively eliminates 1 bpf() lookup systemcall, thus getting us down to 2 (getNextKey + readValue/readValueAndDelete) Note: the tests work because they're consistent in how they map ifindex/ifname so they do not require cache clearing. I believe we don't have to worry about threading, as we're being called while traversing/consuming maps. Thus I believe there must be locking external to us. Also writes should be *super* uncommon, so even if this were to run multithreaded, races should happen very rarely. If they did, we'd just write in the same value twice (since the mapping from ifindex->ifname should rarely if ever change) Worst case once in a blue moon we'd fail to match an interface that had *just* shown up (because of reading only half the name), and we'd lose some stats... (and since the entire value fits in 16 bytes, and thus in a single cache line, in practice most cpus will probably write combine and thus avoid a half write/read anyway, both x86-64 and aarch64 can potentially even do a 16-byte read/write in 1 instruction... although unclear if that will happen, but worst case should be 2) Test: TreeHugger, atest libnetworkstats_test Flag: EXEMPT mainline Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: I0d3ea6c5f1f2945adccd479af6c65008bf7d7c51 |
||
| bpf | ||
| clatd | ||
| common | ||
| framework | ||
| framework-t | ||
| nearby | ||
| networksecurity | ||
| remoteauth | ||
| service | ||
| service-b | ||
| service-t | ||
| staticlibs | ||
| tests | ||
| Tethering | ||
| thread | ||
| tools | ||
| .clang-format | ||
| .gitignore | ||
| OWNERS | ||
| OWNERS_core_networking | ||
| OWNERS_core_networking_xts | ||
| PREUPLOAD.cfg | ||
| preupload_hook_script.py | ||
| rustfmt.toml | ||
| TEST_MAPPING | ||