chiachangwang
c51a705a45
Correct nullability and add extra check for underpinnedNetwork
...
As the review feedback, this commits address below concern.
1. The TCP keepalive code doesn't use the network parameter
at all. This parameter doesn't seem meaningful for TCP
keepalives. Starting a TCP keepalive with a non-null underpinned
network should throw IllegalArgumentException.
2. The feedback mention that the start version which takes a
@NonNull network should throw NPE if the network is null. But
Starting a NATT keepalive does not always require a underpinned
network. A new IkeSession started from Vpn will also not assign
the underpinned network at the initial stage which means
underpinned will be null until setNetwork() is called. Thus,
the underpinned network should be @Nullable instead.
Fix: 271797087
Test: atest FrameworksNetTests
Change-Id: Ieb57a7b15a06b2ccd94358b65cc00768c4f62e7d
2023-03-13 09:00:43 +00:00
..
apf
trivialize apf property accessor dead code
2022-11-04 11:43:22 +00:00
connectivity
Check network slicing declaration for network request
2023-02-28 17:38:30 +09:00
util
Move MultinetworkPolicyTracker to services, where it belongs.
2022-09-27 14:10:41 +09:00
CaptivePortal.java
[CS05]Remove the hidden API usage of MetricsLogger
2021-03-03 10:17:52 +00:00
CaptivePortalData.java
Use String in CaptivePortalData underlying types
2021-04-08 08:23:20 +00:00
ConnectionInfo.aidl
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
ConnectionInfo.java
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
ConnectivityDiagnosticsManager.java
Check location permission for ConnDiags last.
2021-05-21 16:22:50 +00:00
ConnectivityFrameworkInitializer.java
Don't expose raw IBinder APIs.
2021-04-15 18:47:21 +09:00
ConnectivityManager.java
Merge "Update ConnectivityManager javadoc"
2023-03-07 16:50:15 +00:00
ConnectivityResources.java
Migrate framework-connectivity internal resources
2021-03-20 22:35:16 +09:00
ConnectivitySettingsManager.java
Fix rate limit API review comments
2022-02-18 09:47:49 +00:00
ConnectivityThread.java
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
DhcpInfo.java
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
DhcpOption.java
Address API review comments for DhcpOption object
2022-02-07 19:42:40 -08:00
DnsResolver.java
Revert^2 "[ST02.2] Use the getters of DnsHeader"
2022-09-16 07:41:27 +00:00
DnsResolverServiceManager.java
Use jarjar rule generator for connectivity rules
2022-07-20 19:57:11 +09:00
DscpPolicy.java
Move the DscpPolicy status constants and IntDef to NetworkAgent.
2022-03-25 01:06:46 +09:00
ICaptivePortal.aidl
[CS05]Remove the hidden API usage of MetricsLogger
2021-03-03 10:17:52 +00:00
IConnectivityDiagnosticsCallback.aidl
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
IConnectivityManager.aidl
Merge "Add getUidFirewallRule to ConnectivityManager"
2023-02-17 01:53:00 +00:00
InetAddresses.java
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
INetworkActivityListener.aidl
[IT06]Move INetworkActivityListener into connectivity module
2021-02-18 12:03:21 +08:00
INetworkAgent.aidl
Process DSCP QoS events for policies
2022-01-27 10:19:27 +00:00
INetworkAgentRegistry.aidl
Rename destroyAndAwaitReplacement to unregisterAfterReplacement.
2022-03-24 01:12:26 +09:00
INetworkOfferCallback.aidl
[NS05] Feed network offer callbacks
2021-06-07 10:57:48 +00:00
InvalidPacketException.java
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
IOnCompleteListener.aidl
Move network selection utils to Connectivity
2021-03-18 23:57:26 +09:00
IpConfiguration.java
Expose public APIs for IP & static IP configuration
2022-02-07 19:57:07 +00:00
IpPrefix.java
Revert "Revert "Unhide IpPrefix(InetAddress, int)""
2021-12-19 11:54:56 +00:00
IQosCallback.aidl
Add 5G/NR QOS support
2021-03-23 19:14:21 -07:00
ISocketKeepaliveCallback.aidl
[DK3] Send onPause/onResume keepalive callbacks
2023-02-06 13:23:13 +00:00
ITestNetworkManager.aidl
TestNetworkService: add support to disable DAD on test interfaces
2022-07-21 10:20:16 -07:00
KeepalivePacketData.java
Add KeepalivePacketData toString()
2022-02-11 19:17:10 +00:00
LinkAddress.java
Replace InetAddress#parseNumericAddress
2021-03-12 19:57:40 +08:00
LinkProperties.java
Moves all compatibility flags to ConnectivityCompatChanges.java
2023-02-09 19:51:37 +09:00
MacAddress.java
Revert "Revert "Remove connectivity dependency on Preconditions""
2021-03-22 00:01:43 +00:00
NattKeepalivePacketData.java
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
NattSocketKeepalive.java
Add underpinned Network parameter in SocketKeepalive.start()
2023-02-14 10:29:19 +00:00
Network.java
Ensure created fd being closed
2021-12-01 14:46:29 +08:00
NetworkAgent.java
Use the binder to identify keepalive in IConnectivityManager
2023-02-06 13:22:53 +00:00
NetworkAgentConfig.java
Straighten out NetworkAgentConfig's equals()
2022-09-01 08:14:49 +00:00
NetworkCapabilities.java
Improve doc for NetCaps and NetRequest, and add slice XML docs
2023-03-03 16:10:37 +09:00
NetworkConfig.java
Move module sources to packages/Connectivity
2021-02-01 11:52:14 +09:00
NetworkInfo.java
S- not to crash on NetworkInfo(null) or setDetailedState(null)
2021-11-15 21:18:25 +09:00
NetworkProvider.java
NetworkProvider: improve documentation of unregisterNetworkOffer
2022-07-25 13:31:14 -07:00
NetworkReleasedException.java
Expose constructor of Exceptions.
2022-03-17 18:05:56 +00:00
NetworkRequest.java
Improve doc for NetCaps and NetRequest, and add slice XML docs
2023-03-03 16:10:37 +09:00
NetworkScore.java
Remove the legacy int from FullScore.
2022-08-04 06:45:39 +00:00
NetworkState.java
Remove Slog usage in NetworkState
2021-03-11 21:01:30 +09:00
NetworkUtils.java
Remove dependency on libnetd_client
2021-06-01 18:40:06 +09:00
OemNetworkPreferences.java
Adding OEM Network Preferences for testing
2021-04-05 21:51:09 -07:00
ParseException.java
Set ParseException constructors as public
2021-04-08 15:57:31 +09:00
ProfileNetworkPreference.java
Correct javadoc usage
2022-07-15 03:44:46 +00:00
ProxyInfo.java
Remove EXTRA_PROXY_INFO.
2021-04-27 20:01:22 +09:00
QosCallback.java
Move QoS API classes to Connectivity
2021-03-01 18:09:30 +09:00
QosCallbackConnection.java
Use jarjar rule generator for connectivity rules
2022-07-20 19:57:11 +09:00
QosCallbackException.java
Use jarjar rule generator for connectivity rules
2022-07-20 19:57:11 +09:00
QosFilter.java
Support QosCallback for UDP socket: Expose API&CTS
2022-09-29 08:54:08 +00:00
QosFilterParcelable.java
Support QosCallback for UDP socket -Filter
2022-04-20 22:46:21 +00:00
QosSession.java
API review: Additional comment for QosSession.
2022-03-10 22:28:15 +00:00
QosSessionAttributes.java
Move QoS API classes to Connectivity
2021-03-01 18:09:30 +09:00
QosSocketFilter.java
Support QosCallback for UDP socket -Filter
2022-04-20 22:46:21 +00:00
QosSocketInfo.java
Support QosCallback for UDP socket: Expose API&CTS
2022-09-29 08:54:08 +00:00
RouteInfo.java
Revert "Revert "Unhide RouteInfo#getType and related fields""
2021-12-19 11:51:39 +00:00
SocketKeepalive.java
Correct nullability and add extra check for underpinnedNetwork
2023-03-13 09:00:43 +00:00
SocketLocalAddressChangedException.java
Expose constructor of Exceptions.
2022-03-17 18:05:56 +00:00
SocketNotBoundException.java
Expose constructor of Exceptions.
2022-03-17 18:05:56 +00:00
SocketNotConnectedException.java
Support QosCallback for UDP socket: Expose API&CTS
2022-09-29 08:54:08 +00:00
SocketRemoteAddressChangedException.java
Support QosCallback for UDP socket: Expose API&CTS
2022-09-29 08:54:08 +00:00
StaticIpConfiguration.java
Expose public APIs for IP & static IP configuration
2022-02-07 19:57:07 +00:00
TcpKeepalivePacketData.java
Replace fields with getters in keepalive API
2021-04-08 14:06:53 +09:00
TcpRepairWindow.java
Remove TcpRepairWindow from module-lib API
2021-04-12 14:26:55 +08:00
TcpSocketKeepalive.java
Correct nullability and add extra check for underpinnedNetwork
2023-03-13 09:00:43 +00:00
TestNetworkInterface.java
TestNetworkInterface: improve documentation of newly added methods
2022-11-18 09:44:30 -08:00
TestNetworkManager.java
TestNetworkService: add support to disable DAD on test interfaces
2022-07-21 10:20:16 -07:00
TestNetworkSpecifier.java
Remove Preconditions usage in TestNetworkSpecifier
2021-03-22 00:02:10 +00:00
TransportInfo.java
resolve merge conflicts of 403b7fd0b0a6736bcee1817fb5c774f8c8a040de to stage-aosp-master
2021-03-21 19:16:33 +00:00
UidRange.aidl
Move UidRange to connectivity
2021-03-02 15:35:36 +09:00
UidRange.java
Genericize NC#hasSameUids
2021-12-16 23:03:42 +09:00
VpnTransportInfo.java
Rename getBypassable to isBypassable
2022-12-15 04:22:43 +00:00