android_packages_modules_Co.../tests/unit/java/com/android/server
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Motomu Utsumi 0a50c65f75 Use isTetheringFeatureNotChickenedOut for kill switch
Following CLs remove the default value from isFeatureEnabled since the
default value was difficult to use correctly.
For example, there was a code that use isAtLeastT() as default value and
expect feature is always enabled on T+ devices.
However, default value is used only when the device does not have the
flag value or flag value is 0.
So the expectation that the feature is always enabled on T+ devices is
not correct if flag is pushed to the device by mistake or the device is
upgraded from S to T but the flag value is not cleared.
If the feature should be always enabled on T+ devices, `isAtleastT() ||
isFeatureEnabled()` should be used instead of `isFeatureEnabled(
isAtleastT() /* defaultValue*/ )`

After the default value argument is removed from isFeatureEnabled,
isFeatureEnabled is used for default false flag and
isTetheringFeatureNotChickenedOut is used for default true kill switch flag.

automatic_on_off_keepalive_version flag is not configured and devices
don't have this flag value.
So updating to use isTetheringFeatureNotChickenedOut should not have any
behavior change.

Test: m
Bug: 279108992
Change-Id: I43ceab6cc5234bd5a43af3acbd7bd7344844c5a6
2023-08-16 20:15:52 +09:00
..
connectivity Use isTetheringFeatureNotChickenedOut for kill switch 2023-08-16 20:15:52 +09:00
ethernet Connectivity Tests: join handler thread after calling quitSafely 2023-03-17 01:01:09 -07:00
net Fix flaky test: testDataMigration_differentFromFallback 2023-08-09 14:44:23 +08:00
BpfNetMapsTest.java Close sockets from ConnectivityService#setFirewallChainEnabled 2023-05-11 12:22:09 +09:00
ConnectivityServiceTest.java Use isTetheringFeatureNotChickenedOut for kill switch 2023-08-16 20:15:52 +09:00
IpSecServiceParameterizedTest.java Require IPSEC_TUNNEL_MIGRATION feature flag to migrate transforms 2022-12-21 23:12:48 +00:00
IpSecServiceRefcountedResourceTest.java Add some non-connectivity-module-test back to ConnectivityCoverageTests 2022-05-27 07:16:46 +00:00
IpSecServiceTest.java Experimental support for IPv6 UDP encap. 2023-02-08 15:05:07 +09:00
LegacyTypeTrackerTest.kt Build ethernet framework source into framework-connectivity-tiramisu 2022-03-14 14:06:35 +00:00
NetIdManagerTest.kt Address comments on aosp/1781202 2022-08-17 07:11:55 +00:00
NsdServiceTest.java Fix NullPointerException on NsdService 2023-08-10 14:19:01 +08:00
VpnManagerServiceTest.java Update VPN tests to mock out createAttributionContext 2023-06-12 18:06:47 +00:00
VpnTestBase.java Test VPN app exclusion 2022-06-29 06:15:41 +00:00