No description. Add one?
  • Java 78%
  • Kotlin 11.8%
  • AIDL 4.4%
  • C++ 3.7%
  • C 1.5%
  • Other 0.5%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Maciej Żenczykowski 04fb3862a9 Add BPF_MAP_LOCKLESS_FOR_TEST hack for root resolver tests
Per commit description of https://android-review.git.corp.google.com/c/platform/packages/modules/Connectivity/+/3109108 "Use SingleWriterBpfMap in BpfNetMaps":

- firewall.cpp writes to sConfigurationMap, sUidOwnerMap, and
  sDataSaverEnabledMap, but that code only runs in tests because
  it requires root privileges.

So either those maps need to not use SingleWriterBpfMap
in the BpfNetMaps (which would affect performance),
or we need to prevent the tests from grabbing the locks,
or the tests will (presumably) fail.

This avoids grabbing the locks from the test, even though
this is absolutely terrible and likely breaks things...
But in general the entire firewall.cpp file (and libconnectivity_native_test_utils target) are just one
large modularization violation in need of major escalation...

Test via:
  atest resolv_{gold,stress,integration,unit}_test

Without this patch:
  resolv_gold_test: Passed: 16
  resolv_integration_test: Passed: 53, Failed: 2, Ignored: 118, Assumption Failed: 0 (Completed With ERRORS)
  resolv_stress_test: Passed: 2
  resolv_unit_test: Passed: 124, Failed: 2

  4 tests failed
  --------------
  ResolverMultinetworkTest#DnsWithVpn
  PrivateDns/TransportParameterizedTest#BlockDnsQuery/DoT
  CallbackTest#tagSocketCallback
  ResolvGetAddrInfoTest#InvalidParameters

With this patch:
  resolv_gold_test: Passed: 16
  resolv_integration_test: Passed: 178
  resolv_stress_test: Passed: 2
  resolv_unit_test: Passed: 126

Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ie97d015ef66c3864a23484e7ed190fe7d091af5c
2024-06-14 17:35:29 -07:00
bpf_progs NetBpfLoad: gently enable mainline 2024-06-14 15:09:41 -07:00
clatd [DON'T BLOCK] Test ownership migration rules 2024-01-31 12:34:50 +00:00
common Introduce NET_CAPABILITY_NOT_BANDWIDTH_CONSTRAINED 2024-06-06 15:49:21 +09:00
Cronet Move Cronet's MTS/CTS to external/cronet 2024-05-02 11:54:56 +00:00
DnsResolver Add firewall chains for HAPPY_BOX and user/admin PENALTY_BOX 2024-04-23 15:04:28 +09:00
framework Update document for ApfCapabilities.hashCode() 2024-06-13 20:44:46 +09:00
framework-t [mdns] simplify the validation check 2024-05-28 10:58:23 +00:00
nearby NearbyManagerTest: Put static classRule as public 2024-06-06 17:02:53 -07:00
netbpfload NetBpfLoad: gently enable mainline 2024-06-14 15:09:41 -07:00
netd make mapRetrieveWO take exclusive lock 2024-06-14 15:56:01 -07:00
remoteauth Switch to libjni_legacy 2024-05-15 23:47:49 +00:00
service NetBpfLoad: change condition for when we execute platform bpfloader 2024-06-14 05:48:49 -07:00
service-t Enable some mdns features as default 2024-06-13 08:53:42 +00:00
staticlibs Add BPF_MAP_LOCKLESS_FOR_TEST hack for root resolver tests 2024-06-14 17:35:29 -07:00
tests Add BPF_MAP_LOCKLESS_FOR_TEST hack for root resolver tests 2024-06-14 17:35:29 -07:00
Tethering rename netbpfload.mainline.rc to netbpfload.33rc 2024-06-13 15:26:55 -07:00
thread [Thread] add the "vgh" TXT entry 2024-06-12 23:19:34 +08:00
tools Update aospify_device for T device 2024-05-22 13:10:19 +09:00
.gitignore Ignores vim temporary files from git 2023-12-23 17:45:32 +08:00
OWNERS Move the owner of xfrm netlink source code to its own directory. 2023-11-22 18:50:00 +09:00
OWNERS_core_networking Update OWNERS to reflect reorg. 2024-04-10 23:24:14 +00:00
OWNERS_core_networking_xts xTS OWNERS: allow maze to +2 APF fw CTS tests 2024-03-12 02:42:59 +00:00
PREUPLOAD.cfg Enable tethering to perform its own hidden API processing 2021-06-28 23:41:38 +01:00
TEST_MAPPING Move NetHttpCoverageTest to external/cronet TEST_MAPPING 2024-05-21 12:45:56 +00:00