| SHA1 | ||
|---|---|---|
In fact the test already passes, because addSuppressed contains an explicit test that if this === argument, then it doesn't add it. But otherwise that's a bug in tryCleanup Test: NetworkStaticLibTests Change-Id: I202790bbe8d82445c5affdd9076561c2c6ea9b59 
Chalard Jean
commited |
bfbcacef6d | |
A common pattern in tests is to use try-finally to make sure
cleanup is executed. This is necessary in CTS in particular to
make sure the test does not leave the device in a bad state.
The problem with using try-finally in this manner is that any
exception thrown in the finally{} block will override any thrown
in the try{} block. If the exception in finally{} is caused by
the one from try{}, then the stack trace reported by the tools
is the consequence and not the cause, making it difficult to
interpret the stack trace of automated tests.
So today, code has to make sure that either the code in
finally{} can't throw, or can't be affected by any code in
try{}, and both of these are really difficult to ensure in
presence in finally{} of code the tester does not control.
What we'd want ideally is a structure like try-finally, that
guaratees the code in finally{} is executed in all cases,
but that bubbles up the exception from try{} if any, and
will still bubble up any exception from finally{} if the
try{} block hasn't thrown.
That's what this new tool does.
Usage from Kotlin is like try-finally :
tryTest {
testing code
} cleanup {
cleanup code
}
Usage from Java can't be made as nice, but it's relatively okay :
testAndCleanup(() -> {
testing code
}, () -> {
cleanup code
});
Bugs listed below are some tests that have been affected by
this issue and have unhelpful traces.
Test: new test for this code
Bug: 198586720
Bug: 198998862
Change-Id: I54b30a7d53772feeade99274b6120a79707ad1c9
Chalard Jean
commited |
5872cb8dbd | |
The annotation will be used to mark tests cases that are part of MTS modules used by multiple modules, to indicate that the test case should only be run if the MTS suite should cover an updated Connectivity (tethering) module. This allows tests to verify new behavior in the Connectivity module, without failing if that module is not updated. Bug: 196755836 Test: mts-tradefed run mts-network with exclude-annotation in the config Change-Id: I05d2200c7ab68042e4e48029e045f164c26b8037 
Remi NGUYEN VAN
commited |
843740592c | |
Test: atest NetworkStaticLibTests Bug: 174123988 Change-Id: I72a33a3c6ba849666e9f892745be3175aeb34b0e 
junyulai
commited |
4a73a9f08f | |
Having the test targets in a different directory allows setting visibility rules for tests only, which is necessary for access to targets that should not be used for device builds. Bug: 182859030 Test: m Change-Id: Iaf426cf339a97833acf80c941db692329c6e2dcb
Remi NGUYEN VAN
commited |
be2a07fce3 |