Android 16 introduces restrictions on the DeviceConfig flags that
can be modified by the shell user by removing the WRITE_DEVICE_CONFIG
permission from this user and replacing it with the
WRITE_ALLOWLISTED_DEVICE_CONFIG permission; with this permission,
only those flags that have been allowlisted can be modified. This
commit adds the ALLOWLISTED permission to any test that explicitly
adopts the shell permission identity with the WRITE_DEVICE_CONFIG
permission; the WRITE_DEVICE_CONFIG permission is not removed to
ensure tests do not break when run on previous platform releases
without the ALLOWLISTED permission.
Bug: 364083026
Flag: TEST_ONLY
Test: Manually ran all modified tests
Change-Id: I01124581b122b34d45b22a8bd5cb89867ad086a6
Michael Groovercommited 2024-11-25 15:44:42 -06:00
secondary_user_on_secondary_display is for background users that have
access to UI on assigned displays (a.k.a. visible background users) on devices that have config_multiuserVisibleBackgroundUsers enabled. The main use case is Automotive's multi-display configuration where passengers (modeled as visible background users) can interact with the display in front of them concurrently with the driver (modeled as the the current user) interacting with the driver's display.
The fix is to pass in the user id to appops commands so that appops permissions can be properly granted or denied to a visible background user (non current user).
Bug: 374210153
Flag: EXEMPT test fix
Test: Tested on Automotive reference hardware with Multi Display
Test: atest android.net.cts.IpSecManagerTunnelTest
Test: atest --user-type secondary_user_on_secondary_display android.net.cts.IpSecManagerTunnelTest
Test: atest android.net.cts.Ikev2VpnTest
Test: atest --user-type secondary_user_on_secondary_display android.net.cts.Ikev2VpnTest
Test: atest android.net.cts.NetworkStatsManagerTest
Test: atest --user-type secondary_user_on_secondary_display android.net.cts.NetworkStatsManagerTest
Change-Id: I02ae287a926e0bce69ed11fa7e0ef78b288b6b76
SoftApConfiguration.Builder.setWifiSsid(WifiSsid) is only available in
T. Make sure to add an SDK level check to use setSsid if the SDK is
pre-T.
Bug: 380352930
Test: atest TetheringManagerTest
Change-Id: I07a6d9d89ff8c26b2fcd6589b88d8385b223e9bf
Quang Anh Luongcommited 2024-11-25 14:38:13 +09:00
Enhanced testOpenConnection() to include a fallback mechanism that
verifies the current IPv6 address via a DNS query if the initial HTTP
query check fails. This improves test reliability, particularly in
userdebug environments.
Bug: 325894686
Test: TH
Change-Id: I21a496eefd2b2c3d581755c363fedb6c5f9ca4a6
When the test fails, retry it 10 times, and an extra time on the
original source port. Report results in the connectivity diagnostics
file header so they can be parsed across tests.
This should help investigate issues possibly linked to UDP packets not
being routed properly depending on the port.
Test: atest
Bug: 375477810
Bug: 253698734
Bug: 324389407
Bug: 338090529
Change-Id: I8400b40257aa25a373c5a3ec96868d6877e0afb1
Create a helper class in Java to provide easy access to timerfd
JNI methods.
Bug: 366373064
Test: atest NetworkStaticLibTests
Change-Id: Iea09cd29e2a6ed837ece30c512393be2e27e8c2e
* changes:
Clean up TetheringRequest#toString()
Send TetheringRequest to restart Tethering from IpServer
Add hostside CTS tests for SoftApConfig redaction
Include SoftAP config in TetheringEventCallback
Quang Luongauthored and Gerrit Code Reviewcommited 2024-11-19 12:26:34 +00:00
Clean up TetheringRequest#toString() by printing the TetheringType and
ConnectivityScope in a human-readable form and only printing the values
of fields that have been set.
Bug: 216524590
Test: atest TetheringManagerTest
Change-Id: Ie2c35190a09605e3018b9d2d1f1d00cdc7bbb977
Quang Anh Luongcommited 2024-11-19 21:24:47 +09:00
Add hostside CTS tests to test for SoftApConfiguration being redacted
from TetheringInterface for apps that don't own that config.
Bug: 216524590
Test: atest CtsHostsideNetworkTests
Change-Id: I823c8e94cc6fe10c6118e7a694da368e585bbd69
Quang Anh Luongcommited 2024-11-19 19:32:19 +09:00
Android 16 introduces restrictions on the DeviceConfig flags that
can be modified by the shell user by removing the WRITE_DEVICE_CONFIG
permission from this user and replacing it with the
WRITE_ALLOWLISTED_DEVICE_CONFIG permission; with this permission,
only those flags that have been allowlisted can be modified. This
commit adds the ALLOWLISTED permission to any test that explicitly
adopts the shell permission identity with the WRITE_DEVICE_CONFIG
permission; the WRITE_DEVICE_CONFIG permission is not removed to
ensure tests do not break when run on previous platform releases
without the ALLOWLISTED permission.
Bug: 364083026
Flag: TEST_ONLY
Test: Manually ran all modified tests
Change-Id: Iad68063550f99f3dc78ac2f0483dad98a8a93f2e
Michael Groovercommited 2024-11-18 23:28:24 -06:00
Previously, setEthernetEnabled(false) untracks all interfaces and
ignores future RTM_NEWLINK callbacks, which means that the ethernet
module loses all knowledge of existing interfaces.
This change now properly toggles IFF_UP on all interfaces including
those in server mode when setEthernetEnabled API is called, and returns
on error on callback when trying to enable an interface when ethernet is
disabled.
Test: atest EthernetManagerTest
Bug: 316268558
Bug: 225315248
Change-Id: Ic7785e7e0c87c1437627661401e66201dd60802a
Include SoftApConfiguration in TetheringEventCallback via
TetheringInterface, to allow apps to know which interfaces are created
with their SoftApConfigurations.
API-Coverage-Bug: 371133403
Bug: 216524590
Test: atest TetheringTest CtsTetheringTest
Change-Id: I1b4868ba8327bee3b03c0f21e5b4f0845f2f24a8
Quang Anh Luongcommited 2024-11-18 13:37:39 +09:00
This reverts commit 5714031dcc.
Reason for revert: breaks MCTS as tests are run with older tradefed that does not have the option: b/378710131
This can be rolled forward after cherry-picking the tradefed change to older branches.
Change-Id: Ib9b4fe3b1c5393cd6e802eee4899457497d79ca7
Remi NGUYEN VANauthored and Gerrit Code Reviewcommited 2024-11-18 00:57:58 +00:00
secondary_user_on_secondary_display is for background users that have
access to UI on assigned displays (a.k.a. visible background users) on
devices that have config_multiuserVisibleBackgroundUsers enabled.
The main use case is Automotive's multi-display Whole Cabin experience
where passengers (modeled as visible background users) can interact
with the display in front of them concurrently with the driver
(modeled as the the current user) interacting with driver's display.
The AndroidTest.xml file is shared by several modules, including
CtsNetTestCasesMaxTargetSdk33. Now all modules can pass now.
Fixes: 365184699
Test: atest CtsNetTestCasesMaxTargetSdk33
Test: atest --user-type secondary_user CtsNetTestCasesMaxTargetSdk33
Test: atest --user-type secondary_user_on_secondary_display CtsNetTestCasesMaxTargetSdk33
Flag: TEST_ONLY
Change-Id: I905646aca1a3d3ed2a80bbe3a8c67ec0139e7562
This commit removes the redundant type and caller uid
checks in TrafficStats to address the review feedback at
aosp/3313055.
Test: TH
Bug: 343260158
Change-Id: I0ed6e850835136c9a324efd7271dd80a34160aa6
secondary_user_on_secondary_display is for background users that have
access to UI on assigned displays (a.k.a. visible background users) on
devices that have config_multiuserVisibleBackgroundUsers enabled.
The main use case is Automotive's multi-display Whole Cabin experience
where passengers (modeled as visible background users) can interact
with the display in front of them concurrently with the driver
(modeled as the the current user) interacting with driver's display.
Fixes: 364636108
Test: atest CtsNetTestCasesInternetPermission
Test: atest --user-type secondary_user CtsNetTestCasesInternetPermission
Test: atest --user-type secondary_user_on_secondary_display CtsNetTestCasesInternetPermission
Flag: TEST_ONLY
Change-Id: Ib559c8465846f687a725b85c330f398e81cbe567
Similar to ag/19534833, this CL ensured that CtsNetTestCasesInternetPermission builds its helper apks.
Bug: 364636108
Test: atest CtsNetTestCasesInternetPermission
Flag: TEST_ONLY
Change-Id: I989126cc027e317e228fad197b6e9f752e8e4acb
Enable error-prone checking for CtsNetTestCasesDefaults to
catch NullablePrimitive errors during build time. This is
to address review feedback at aosp/3292201
Test: m CtsNetTestCases
Bug: N/A
Change-Id: I009f0e4ede02a933570cfcc8c563808dbf436193
This adds tests for bugs that were introduced when we enabled
early native network creation. The tests pass on current builds
because the feature is disabled, but break if the feature is
re-enabled without fixing the races.
Specifically:
- Add a test that registers/unregister/registers agents in a
loop. This checks for a race between unregister() and
register() which exists because unlike register(),
unregister() has to wait for the agent channel to be
connected.
- Add a test for calling unregisterAfterReplacement multiple
times on the same interface. This tests for the race seen
in b/286649301#comment6 , where calling
unregisterAfterReplacement twice and then registering a third
agent will cause the second agent to be torn down after the
third is registered.
Bug: 296355968
Test: test-only change
Change-Id: I3d798209740273e5ce59b278af41dd2ad9470916
Lorenzo Colitticommited 2024-10-31 16:26:14 +09:00
This is a no-op change since the config is not used yet, and
the feature flag will be gradually rolled out instead of enabled
by default.
However, this change is necessary for follow-up changes to enable
toggling the feature and configuring its behavior through device
configuration flags.
This change includes:
1. Disable the service-side cache flag if the client-side flag
is enabled.
2. Since the apps don't have enough permission to check the
feature flag from DeviceConfig. Provides a binder interface
for returning per-UID config,
which only returns cache enabled if the SDK level is V+
or the app's target SDK is V+.
Test: atest FrameworksNetTests:android.net.connectivity.android.net.TrafficStatsTest \
FrameworksNetTests:android.net.connectivity.com.android.server.net.NetworkStatsServiceTest \
CtsNetTestCases:android.net.cts.NetworkStatsBinderTest \
FrameworksNetIntegrationTests:com.android.server.net.integrationtests.NetworkStatsIntegrationTest
Bug: 343260158
Change-Id: Id9761e4aea65fabe6466c875b787e178317a1da2
Paul Hu
authored and
Gerrit Code Review
commited 
Quang Luong
authored and
Treehugger Robot
authored and
Michael Groover
commited 
Xiang Wang
authored and
Yuyang Huang
authored and
Remi NGUYEN VAN
commited 
Chuwei He
authored and
Tongbo Liu
authored and
Automerger Merge Worker
commited 
Lorenzo Colitti
commited 
Yabin Huang
authored and
Mayank Garg
commited 
Junyu Lai
commited 
Oscar Shu
commited 
Maciej Żenczykowski
authored and
Patrick Rohr
authored and