| SHA1 | ||
|---|---|---|
Treehugger Robot
authored and
 Gerrit Code Review
commited |
6258c4482f | |
This commit removes the redundant type and caller uid checks in TrafficStats to address the review feedback at aosp/3313055. Test: TH Bug: 343260158 Change-Id: I0ed6e850835136c9a324efd7271dd80a34160aa6 
Junyu Lai
commited |
739d200d35 | |
Jaewan Kim
authored and
Gerrit Code Review
commited |
555bbc4844 | |
Follow-up from aosp/3249945. If the system caller queries stats for other UIDs, the caller would get UNSUPPORTED. This follows the official documentation, where the API would not return stats for all other UIDs. However, partners or other legacy callers might already depend on this undocumented behavior. Changing this behavior might damage existing apps. Thus, this change reverts the behavior change introduced at aosp/3249945 and allows a system caller to query stats for other UIDs. Test: atest ConnectivityCoverageTests:android.net.connectivity.android.net.TrafficStatsTest Bug: 372851500 Change-Id: Ia7ea051f7b0b6349ffcb890c300362bbfbdee3dc
Junyu Lai
commited |
e51bae6bdc | |
This change includes:
1. Rename binder interfaces.
2. Use a dedicated class to pass the result of
get{Total|Iface|Uid}Stats, as it is 25% faster than passing
a NetworkStats object through the binder interface.
3. Remove the binder interface only used by the test.
4. Remove NetworkStatsBinderTest on R and S, since the binder
interface is removed, the mainlined service does not run on
those versions and the chance of breaking these tests on
R and S is low.
5. Remove useless TODO comments.
Test: atest FrameworksNetTests:android.net.connectivity.com.android.server.net.NetworkStatsServiceTest \
CtsNetTestCases:android.net.cts.NetworkStatsBinderTest \
FrameworksNetIntegrationTests:com.android.server.net.integrationtests.NetworkStatsIntegrationTest
Bug: 372851500
Bug: 343260158
Change-Id: Ibd79a17218f54f0117d8ef5d7b9ec6073356f923
Junyu Lai
commited |
9fb574d0c3 | |
Prevent verbose log (15k logs in 3s) by default Change-Id: I13fdd0ecfcff8f9f5de59ba91fd9f0b4abf02f7f
Jaewan Kim
commited |
531a9f0a9b | |
Prepare for implementation of client side TrafficStats rate limit cache. 1. Write Typeless versions of getIfaceStats, getUidStats, getTotalStats in INetworkStatsService.aidl that returns NetworkStats instead of Long. This is needed because in follow-up changes, the NetworkStats instead of indiviual numbers will be stored as a cache entry 2. Move some utils from NetworkStatsService to TrafficStats. This is needed because in the follow-up changes, these utils would be both accessed by TrafficStats and NetworkStatsService. Test: CtsNetTestCases:android.net.cts.TrafficStatsTest Test: CtsNetTestCases:android.net.cts.NetworkStatsBinderTest Test: FrameworksNetIntegrationTests:com.android.server.net.\ integrationtests.NetworkStatsIntegrationTest Test: FrameworksNetTests:android.net.connectivity.com.android.\ server.net.NetworkStatsServiceTest Test: FrameworksNetTests:android.net.connectivity.\ android.net.TrafficStatsTest Test: ConnectivityCoverageTests:android.net.connectivity.\ android.net.TrafficStatsTest Bug: 343260158 Change-Id: Iace251e1495fd3b81e072526e92ca97cbc7246eb 
Yun-Chen Cheng
commited |
69b83606ca | |
This change put a rate-limit on TrafficStats getter APIs to reduce the need of accessing bpf map. For any caller who calls this method within 1 second, a stale result will be returned. One expected outcome is this change would break any test which relies on immediate change of the result of TrafficStats after making network traffic. Thus, related tests are fixed in the counter part CL accordingly. Test: atest CtsNetTestCases:android.net.cts.TrafficStatsTest --rerun-until-failure 100 Test: atest CtsNetTestCases:android.net.cts.NetworkStatsManagerTest Test: atest NetworkStackIntegrationTests:android.net.NetworkStatsIntegrationTest Test: atest ConnectivityCoverageTests:android.net.connectivity.com.android.server.net.NetworkStatsServiceTest Bug: N/A Change-Id: Ibd6ae92d7c806481bb8a5124dd231f8f5aa206f2
Junyu Lai
commited |
3c9089c1d1 | |
(is this a valid change from hiddenapi perspective?) Test: TreeHugger Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: I2dc1c54c56a628770149382f1e25b90a71f62167 
Maciej Żenczykowski
commited |
6f0ec43200 | |
On T+ this is mainline code, and the bpf program (netd.c) does not support collecting tcp specific stats. (note: this *is* a behaviour change, as it currently just always returns 0, but UNSUPPORTED/-1 seems to make more sense) Test: TreeHugger Bug: 294604315 Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: Ifda15e67d9167a2be98ab6f4e3817ff7c0bb3fea
Maciej Żenczykowski
commited |
66645a8d68 | |
Some of the internal classes are not available for priv-apps. Thus, make them module-lib instead. This change also adds some nullability annotations for existing APIs according to go/android-api-guidelines. Test: m Test: m frameworks-base-api-system-current-compat Fix: 217479745 (cherry-picked from ag/17117903) Change-Id: I18de46b11df7232ab82b9465856fdde621283156 Merged-In: I18de46b11df7232ab82b9465856fdde621283156 Merged-In: Ief3f2304f11b7940a18b98b8533fbca85ffa4dc1
junyulai
commited |
44e61e2140 | |
Currently, socket tagging is implemented in the framework. The Java code is in NetworkManagmentSocketTagger.java and the JNI is in libandroid and loaded by the general framework JNI loader. - Move the Java implementation to TrafficStats, which is the only caller of NetworkManagmentSocketTagger. This simplifies the code a bit because a number of methods can be deleted. - Move the JNI code to a new JNI library in the APEX. The library depends only on the NDK and statically links the NDK-only version of libnativehelper. Its size is only 5k on ARM and 10k on ARM64. - Temporarily make the framework depend on this library until the rest of the T connectivity code moves to the APEX. Test: atest NetworkUsageStatsTest CtsNetTestCases:TrafficStatsTest Change-Id: I050c7c515237f68b78d08987bc443f50a7949c06 
Lorenzo Colitti
commited |
d2ae7390f5 | |
Supplemental apps has limited capabilities and service discovery is restricted. Hence, calling TrafficStats.init would result in crash. This change includes: 1. Print log instead of crashing process when running into any unexpected cases. Test: atest SupplementalProcessManagerTests Bug: 216062904 Change-Id: I7f827ccc485c997745779053b5936a6cb30e8219
Junyu Lai
commited |
3355c400b7 | |
Expose TrafficStats#attachSocketTagger and use it instead. Test: atest TrafficStatsTest Bug: 204830222 CTS-Coverage-Bug: 214979748 Change-Id: I1748d349b499053ad08bd62202325fa759ad8da5
Junyu Lai
authored and
junyulai
commited |
8e58c82591 | |
TrafficStats has static methods created in API level 8 that need access to NetworkStatsManager but doesn't take a context. Previously this was achieved by using ServiceManager, but with TrafficStats moving to the connectivity module, this is no longer possible. Instead, make sure TrafficStats has an appropriate context by the time any client code can call the relevant methods. • In app code, this achieved by passing the application context from ActivityThread#handleBindApplication, before any app code can run. • In the system server, this is achieved by passing the context right after creating service. Test: atest TrafficStatsTest CtsWebkitTestCases Bug: 204830222 Change-Id: I251bb8a4431ad12ff61929879ef1363cf06b9244
Junyu Lai
authored and
junyulai
commited |
92d5b4cbc2 | |
Replace with system Api. Test: TH Bug: 204830222 CTS-Coverage-Bug: 215043101 Change-Id: Ic14b26d2862f6fe8bee18fe0c9eaf183052452ee
Junyu Lai
commited |
ab2c35e440 | |
Since TrafficStats is moving into the mainline module, ServiceManager#getService can no longer be accessed. This change use reflection to access getService, since there is no offical way to get the service binder, and TrafficStats is a static utility that doesn't have the context to invoke Context#getSystemService. This change also fixes minor lint errors. Test: atest CtsNetTestCases:TrafficStatsTest Bug: 204830222 Change-Id: I5caec42a71431b39f747fc791b8511d92e5cf7cc
Junyu Lai
commited |
3f7bb338bd | |
DataUnit is a hidden class, remove the references to it from files that about to be moved into the module. Test: TH Bug: 204830222 Change-Id: Ibfb82ab74f283686fb2af6c3a550d541440c890d
Junyu Lai
commited |
1d3ce85882 | |
NetworkStatsService is going to be moved into ConnectivityService module. Move all related files to packages/ConnectivityT so that it can be easily migrate these files to connectivity module after clearing the hidden API usages. Bug: 197717846 Test: TH Change-Id: Iead00832b5eb7b1dc40a92027c5a14ae8316b16c
Junyu Lai
commited |
ad166b43df |
Renamed from core/java/android/net/TrafficStats.java (Browse further)