Commit graph android_packages_modules_Co.../Tethering/common/TetheringLib
Message SHA1
Move cronet to framework-connectivity
aosp/2384137 added cronet to framework-tethering.
But framework-connectivity is a better place to put cronet since
cronet does not work on R devices (b/270049141) and
framework-tethering is R+, framework-connectivity is S+.

Followup CLs will move some modules (e.g. CronetJavaPrejarjarDefaults)
that use the branch dependent soong variables to framework/Android.bp

Test: TH
Bug: 278070640
Change-Id: I6bc10116759fb9e083c02147908e53022dab740a

Motomu Utsumi   commited 2023-04-19 11:32:12 +09:00
73e2e87d56
Revert "Fix symbol not found error for hidden apis used by MTS"
This reverts commit 5f44ed3e7e.

Reason for revert: The symbol not found error was a transient build failure.

Change-Id: Iada1a0bc9c2282286c1e3b972de42e6387c901d6

Chidera Olibie   commited 2023-04-13 09:38:39 +00:00
ef0074143d
Fix symbol not found error for hidden apis used by MTS
This fails to build on git_master when
depending on `sdk_version:module-current` and
`libs:["framework-tethering-pre-jarjar"].

AIUI, some builds use sdk prebuilts that have compiled out
some of the hidden apis. And thus fails with symbol not found.

So we depend on the impl version of frame-tethering so we always
have access to these hidden apis for MTS.

Test: atestNetHttpCoverageTests
Change-Id: Id68a9051b9f8566f9ca42142669150a6db8b0925

Chidera Olibie   commited 2023-03-23 15:53:11 +00:00
5f44ed3e7e
Revert^2 "gn2bp: Remove soong_namespace"
8484ec4dcd

Change-Id: I490c09179ea6a20ca5fba83c314b552d360be688

Mohannad Farrag   commited 2023-03-23 12:47:47 +00:00
9c6801f81b
Revert "gn2bp: Remove soong_namespace"
Revert submission 2502135-remove_soong_namespace

Reason for revert: Missing line needs to be added

Reverted changes: /q/submissionid:2502135-remove_soong_namespace

Change-Id: I780a21cf7031e04eb368fda4f93ed16ea032ca8d

Mohannad Farrag   authored and   Gerrit Code Review   commited 2023-03-23 12:36:48 +00:00
8484ec4dcd
gn2bp: Remove soong_namespace
* This was causing the infra to ignore the modules and masking build errors.

Test: TH
Change-Id: Ic5aa3557353488d5370f4d9c4240954820bfe52b

Mohannad Farrag   commited 2023-03-23 12:14:04 +00:00
16ba062336
Merge "Reland "Bundle Cronet's boringssl""
Stefano Duo   authored and   Gerrit Code Review   commited 2023-03-20 13:10:30 +00:00
a5e1029101
Reland "Bundle Cronet's boringssl"
This relands commit 2cd4ac8725

Merged-In: I903369dbad37b663a39e80149e25b0634386df6d
Change-Id: I018121bf4d02ccc59c89de39e3d1598deb9cf67b
Bug: 274094720

Stefano Duo   commited 2023-03-17 13:46:25 +00:00
43d89f659f
cronet: Update APIs naming
Bug: 265674359
Bug: 273937039
Test: TH
Change-Id: I5fc149396511effdfabd462eba80d1a010ee205a

Motomu Utsumi   commited 2023-03-17 09:04:56 +00:00
2441e4aea6
Merge "cronet: Fix AutoBoxing API linter issue"
Dan Stahr   authored and   Gerrit Code Review   commited 2023-03-16 15:03:55 +00:00
9ed7a339a1
cronet: Fix AutoBoxing API linter issue
Bug: 265674359
Test: TH
Change-Id: Id2489a2337ff4d0fd0c30929f9e56d8d027dbbc6

Motomu Utsumi   authored and   Dan Stahr   commited 2023-03-15 13:54:17 +00:00
5cdd07aa26
Use filegroup defaults for framework sources
There's now a shared defaults module for this kind of filegroup. Use
that and remove the previously duplicated prop.

Bug: 271816210
Test: m
Change-Id: Ia4547984a73179fdfc98c427482dd10246f9722c

Anton Hansson   commited 2023-03-15 10:36:52 +00:00
57f3d69fd5
Merge "Revert "Bundle Cronet's boringssl""
Treehugger Robot   authored and   Gerrit Code Review   commited 2023-03-15 00:31:21 +00:00
853ef56fb6
Revert "Bundle Cronet's boringssl"
This reverts commit 2cd4ac8725.

Reason for revert: b/273575026

Change-Id: I5b9886465b8a0f71af469d303a39f670a9b0cb68

Patrick Rohr   authored and   Gerrit Code Review   commited 2023-03-14 22:45:06 +00:00
77c084d1f6
Merge "Cronet API: make UrlRequest.Callback an interface."
Treehugger Robot   authored and   Gerrit Code Review   commited 2023-03-14 15:42:28 +00:00
944d6a3235
Cronet API: make UrlRequest.Callback an interface.
For consistency with other Callback classes, and not to force class
hierarchy on users. The historical "callback completeness" issue can be
mnitigate using interface defaults.

Test: atest CtsNetHttpTestCases
Change-Id: Ibf2aaf4396ab9defdeb4e3882cea6b1b2dbd36ee
Merged-In: Id8fcc13567da8878e848f3c6668d865e77b48146

Dan Stahr   authored and   Motomu Utsumi   commited 2023-03-14 05:57:19 +00:00
fcfe8c7d8e
Bundle Cronet's boringssl
Test: m && atest CtsNetHttpTestCases
Change-Id: I3c28a52d60128cf4324eda436c1f6e9fa463108e

Stefano Duo   commited 2023-03-13 13:28:35 +00:00
2cd4ac8725
cronet: re-enable lint
Bug: 265674359
Test: TH
Change-Id: I867a66518db0eb9fe446aa28e07d4678f0e3af94

Motomu Utsumi   commited 2023-03-10 19:01:18 +09:00
d4a1c63c5d
cronet: Hide old newUrlRequestBuilder
Bug: 272009719
Bug: 265674359
Test: TH
Change-Id: If98ea3c45d9e181773f9d5877462d4d3c6097302

Motomu Utsumi   commited 2023-03-10 13:38:08 +09:00
d229268989
Merge "cronet: Make BidirectionalStream.Callback interface"
Motomu Utsumi   authored and   Gerrit Code Review   commited 2023-03-09 16:19:07 +00:00
04de61f9e9
Merge changes from topics "setter_getter_fix", "use_header_block"
* changes:
  cronet: Use HeaderBlock for getHeaders API
  cronet: Address Setter/Getter related API linter issues

Treehugger Robot   authored and   Gerrit Code Review   commited 2023-03-09 15:03:34 +00:00
ba0f26fb86
Merge "Expose the getter for idle connection timeout."
Dan Stahr   authored and   Gerrit Code Review   commited 2023-03-09 11:33:18 +00:00
78cfe3336b
Expose the getter for idle connection timeout.
Test: m
Bug: 271423645
API-Coverage-Bug: 251012627
Change-Id: I10862786e83e79ced1c4afd9328d6a158bae7232

Dan Stahr   commited 2023-03-09 11:32:11 +00:00
f63b5df622
cronet: Make BidirectionalStream.Callback interface
Bug: 271423645
Bug: 265674359
Test: TH
Change-Id: I0efb1ad4719a62b1e7ad2c96af0660e212dbb966

Motomu Utsumi   commited 2023-03-09 18:33:55 +09:00
d41fa7b77c
cronet: Use HeaderBlock for getHeaders API
Bug: 265674359
API-Coverage-Bug: 251012627
Test: TH
Change-Id: I03bfafdc6c855f38145eb9d35c1f0ac6934d903f

Motomu Utsumi   commited 2023-03-09 18:33:55 +09:00
444192ad69
cronet: Address Setter/Getter related API linter issues
Bug: 271423645
Bug: 265674359
Test: TH

Change-Id: Id1628dd7af48a8e079636924b66368db0eb2ec4e

Motomu Utsumi   commited 2023-03-09 18:33:52 +09:00
00b4a97224
cronet: Fix remaining MissingNullability API linter issue
Bug: 265674359
Test: TH
Change-Id: I7e498d12469a974aa5b4f1d94223e6254e072c29

Motomu Utsumi   commited 2023-03-08 11:39:51 +09:00
41b5e83be0
cronet: Fix some MissingNullability API lineter issues
Bug: 265674359
Test: th
Change-Id: I710b2cfb0bc358ef7ed24ccaf04c91d56e75ecba

Chidera Olibie   authored and   Motomu Utsumi   commited 2023-03-08 11:39:31 +09:00
bff88ee900
cronet: Fixed AcronymName API linter issue
Bug: 265674359
Test: TH
Change-Id: Icd786451641f32022587ca95714233d476804e67

Motomu Utsumi   commited 2023-03-06 17:15:38 +09:00
7c1505915c
cronet: Fix ListenerInterface API linter error
Update UrlRequest.StatusListener to interface

Bug: 265674359
Test: TH
Change-Id: Ib3c0f3dcc42add6e529fc4f36e735ce7ab1fc633

Motomu Utsumi   commited 2023-03-06 17:15:38 +09:00
73d869f1b2
cronet: Fix ListenerLast API linter error
This CL adds method with the right signature since there's an internal
caller of old API.
Old API will be removed once the caller has been updated.

Bug: 265674359
Test: TH
Change-Id: I5e614530163d4f05fda0bff3966ba34e7a24d34e

Motomu Utsumi   commited 2023-03-06 17:14:04 +09:00
45a35aec20
cronet: Addressed StaticFinalBuilder API linter errors
Bug: 265674359
Test: TH
Change-Id: I767e276413112aa4b1a03e7821c4b3992a2e28c1

Motomu Utsumi   commited 2023-03-03 20:02:44 +09:00
5505063c1b
cronet: Fix BuilderSetStyle API lint errors
Bug: 265674359
Test: TH
API-Coverage-Bug: 251012627
Change-Id: Ie420d553d18c88a2fa654ae41cca8812c863af20

Motomu Utsumi   commited 2023-03-03 20:02:44 +09:00
15a147ce7a
cronet: Fix MissingNullability API linter errors
Bug: 265674359
Test: TH
Change-Id: Ibaceeaf5f851c0d901c09942a63f038b612818cc

Motomu Utsumi   commited 2023-03-03 20:02:41 +09:00
0ace420204
Expose the socket tagging APIs in Android.
Addressing API Councillor feedback, this is necessary for feature parity
between existing networking APIs and AOSP Cronet.

Test: m
API-Coverage-Bug: 251012627
Change-Id: I462a234dd95aad5a1c09838fbca13b6cf9649cbd

Dan Stahr   commited 2023-02-17 23:06:34 +00:00
3cf0829e71
Merge "Expose additional Cronet APIs in AOSP."
Dan Stahr   authored and   Gerrit Code Review   commited 2023-02-17 23:04:01 +00:00
35e799efbd
Expose additional Cronet APIs in AOSP.
This is required to provide a reasonably feature-comnplete
implementation of current org.chromium.net APIs on top of
android.net.http. The main targets for this change are gRPC (mostly
bidirectional streaming) and prospective early adopters.

Test: m
API-Coverage-Bug: 251012627
Change-Id: I66341581501090641c7eea32de5a5b8453cd97d4

Dan Stahr   commited 2023-02-17 18:34:59 +00:00
62d57d09c2
Merge "Expose the network binding APIs in AOSP."
Dan Stahr   authored and   Gerrit Code Review   commited 2023-02-14 14:56:23 +00:00
722a5f2c5e
Reflect changes from r.android.com/2426234 in the API surface.
HttpEngine.getVersion() can be implemented directly as the API and implementation versions don't differ in AOSP.

Test: m
Change-Id: Ide6881f8978cb8890d585f760cd0d1225a4c2542

Dan Stahr   commited 2023-02-13 13:00:17 +00:00
0d2d19a706
Expose the network binding APIs in AOSP.
See the other topic CLs for code changes.

Test: m
API-Coverage-Bug: 251012627
Change-Id: Iad5c500139ce17d834e122e373ca6d0ebee28265

Dan Stahr   commited 2023-02-09 11:54:38 +00:00
33a98282e5
cronet: remove cronet_java_defaults_enabled_srcs
external/cronet has been added to the default manifest in
tm-mainline-prod, so this soong variable is not needed anymore.

Test: TH
Merged-In: I5750d87c9cab0e9d4d213b5a81a2d71cc9610a08
Change-Id: I5750d87c9cab0e9d4d213b5a81a2d71cc9610a08

Patrick Rohr   commited 2023-01-25 01:07:04 -08:00
ffdeb180a1
Add Cronet to the Tethering apex.
Test: m
API-Coverage-Bug: 258707653

Change-Id: I2d6401ec719ce265abdb30d6ba8fd94861845197

Dan Stahr   authored and   Patrick Rohr   commited 2023-01-17 08:06:53 -08:00
e2be25f6a0
cronet: Introduce constant for CronetJavaDefaultsEnabled srcs
This is required temporarily until the external/cronet is auto-merged
to tm-mainline-prod

Test: m
Change-Id: Ie875e4108a0b2a82e9615d1f32f3b0bf76572146

Motomu Utsumi   commited 2023-01-17 15:03:03 +09:00
841643a95e
Set up the jarjar config generator for the Tethering module.
This does not affect existing classes in framework-tethering.jar
as everything inside android.net is excluded from being jarjar'ed.
It is a preparatory step to adding cronet to framework-tethering.jar
which will use jarjar.

Test: m
Change-Id: I8cc7babaa37f7aef52306a833593dba097fd26db

Dan Stahr   authored and   Patrick Rohr   commited 2023-01-13 02:26:19 -08:00
1a8d9d1521
cronet: enable defaults in aosp
Automerger into tm-mainline-prod is currently broken, so this change
uses a Merged-In line that is already present in tm-mainline-prod (and
downstream from it). This means that this change must also be
cherry-picked into internal-master with a slightly different Merged-In
specification.

Test: TH
Merged-In: I555ad1ed687632cfe8a7e30283f80e80956fc1d4
Change-Id: I25096f4cc21923c602d77a66aad248d52b42b18f

Patrick Rohr   commited 2023-01-06 04:13:56 -08:00
a6d600ff50
cronet: add defaults to enable / disable Cronet in framework-tethering
A similar option already exists in
packages/modules/Connectivity/Cronet/apex/Android.bp. This is in
preparation of adding cronet to framework-tethering. It is possible that
we only end up using one of the variables but better safe than sorry.

This change will be blocked by the blocked automerger into
tm-mainline-prod. If this continues to be a problem, we might have to
play some tricks with automerger.

Test: TH
Change-Id: I40ba22aba041ec12ec2bf2881df14e6c0ee53b44

Patrick Rohr   commited 2023-01-06 04:12:59 -08:00
3b9ba6acdf
Add CDM dependency in Tethering
This change introduces a limited library for dependencies on
framework-connectivity from Tethering,
connectivity-internal-api-util, where all classes are annotated with
@RequiresApi(S) to ensure proper API checks are done before usage.

Bug: 245972418

Change-Id: I82bafd9063341adc71d07f0858e6d68283d081f0

Igor Chernyshev   commited 2022-12-16 17:55:53 +00:00
9dac660bf0
Merge "Remove unused TetheringConfigurationParcel fileds"
Mark Chien   authored and   Gerrit Code Review   commited 2022-10-21 07:50:23 +00:00
381e339647
Fix array-related errorprone warnings
The ArrayEquals, ArrayHashCode, ArrayToString, and
ArraysAsListPrimitiveArray errorprone findings were
demoted from errors to warnings. Fix existing
occurrences of them so they can be made errors again.

Bug: 242630963
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: I95b4d0f8d3dfa957285ca94e0846fd3da4734e57

Cole Faust   authored and   Lorenzo Colitti   commited 2022-08-22 00:30:47 +00:00
fe60c0fe31
Remove unused TetheringConfigurationParcel fileds
Bug: 237338640
Test: atest TetheringTests

Change-Id: Ic851e2e9ed16b5be6f5b1380f6b905fcc1e131cf

Mark Chien   authored and   Mark   commited 2022-08-16 15:58:44 +00:00
40caeb78f3