joy/android_packages_modules_Connectivity
Watch
1
Fork
You've already forked android_packages_modules_Connectivity
 0
Code Issues Pull requests Projects Releases Wiki Activity

Make NetworkAgent#sendNetworkInfo public again

Browse source 
Changing this method to private broke OEM code that would link
directly against the non-public methods of the module. This
should not be allowed, and we have changes in the works to
disallow this, but in the mean time we can't afford to break
devices in the field.

Test: will have to see how it behaves in the lab on relevant devices
Flag: EXEMPT bugfix
Bug: 406489362
Change-Id: Ie6c1ebb04e49317fdda34ff3dd522cd9d4677556
This commit is contained in:
Chalard Jean 2025-03-28 18:09:13 +09:00
commit f7e102081d
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
framework/src/android/net/NetworkAgent.java
View file

@ -1236,7 +1236,11 @@ public abstract class NetworkAgent {
* @hide TODO: expose something better.
*/
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 115609023)
private void sendNetworkInfo(final NetworkInfo networkInfo) {
// Note : this should be private, but is still called by some OEM network agents
// linking against the full module. They should not do this, and it should be
// forbidden, but as long as there are such devices this can't be made private
// on pain of breaking them.
public void sendNetworkInfo(final NetworkInfo networkInfo) {
final NetworkInfo ni = new NetworkInfo(networkInfo);
send(reg -> reg.sendNetworkInfo(ni));
}