From 1185d242a61ef32795e509057fadfdf913c668d0 Mon Sep 17 00:00:00 2001 From: Patrick Rohr Date: Thu, 29 May 2025 12:57:00 -0700 Subject: [PATCH] Make EthernetPort#toString more legible Test: TH Flag: EXEMPT mainline Bug: 1000001 Change-Id: I6abf322a57412edf97b20d6b96ca5747938fd1ea --- service-t/src/com/android/server/ethernet/EthernetPort.java | 4 ++-- .../java/com/android/server/ethernet/EthernetPortTest.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/service-t/src/com/android/server/ethernet/EthernetPort.java b/service-t/src/com/android/server/ethernet/EthernetPort.java index eb7a0bd885..b9d9961dd7 100644 --- a/service-t/src/com/android/server/ethernet/EthernetPort.java +++ b/service-t/src/com/android/server/ethernet/EthernetPort.java @@ -70,8 +70,8 @@ public class EthernetPort { @Override public String toString() { - return "Interface name: " + mInterfaceName + ", MAC address: " + mMacAddress - + ", Interface index: " + mInterfaceIndex; + return "EthernetPort(" + mInterfaceName + ", ifindex=" + mInterfaceIndex + + ", MAC=" + mMacAddress + ")"; } @Override diff --git a/tests/unit/java/com/android/server/ethernet/EthernetPortTest.java b/tests/unit/java/com/android/server/ethernet/EthernetPortTest.java index 0aa133405f..594b4c13b5 100644 --- a/tests/unit/java/com/android/server/ethernet/EthernetPortTest.java +++ b/tests/unit/java/com/android/server/ethernet/EthernetPortTest.java @@ -115,7 +115,7 @@ public class EthernetPortTest { public void testToString() { EthernetPort port = new EthernetPort( mTestInterfaceName, mTestMacAddress, mTestInterfaceIndex); - String expect = "Interface name: eth0, MAC address: 0a:1b:2c:3d:4e:5f, Interface index: 1"; + String expect = "EthernetPort(eth0, ifindex=1, MAC=0a:1b:2c:3d:4e:5f)"; assertEquals(expect, port.toString()); } }