From d89374cf11f5037de30b7f29b638b8e8b05dd526 Mon Sep 17 00:00:00 2001 From: wangshengrjxtjcb Date: Mon, 1 Aug 2022 15:11:48 +0800 Subject: [PATCH] unit test of offernetwork and unoffernetwork BUG:238033349 Change-Id: Ibdedbae5d785145af155bb5bf10a5ba5dfaffcff --- .../server/ConnectivityServiceTest.java | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) mode change 100644 => 100755 tests/unit/java/com/android/server/ConnectivityServiceTest.java diff --git a/tests/unit/java/com/android/server/ConnectivityServiceTest.java b/tests/unit/java/com/android/server/ConnectivityServiceTest.java old mode 100644 new mode 100755 index 0919dfc981..9d1e401815 --- a/tests/unit/java/com/android/server/ConnectivityServiceTest.java +++ b/tests/unit/java/com/android/server/ConnectivityServiceTest.java @@ -16439,6 +16439,26 @@ public class ConnectivityServiceTest { assertNull(readHead.poll(TEST_CALLBACK_TIMEOUT_MS, it -> true)); } + @Test + public void testOfferNetwork_ChecksArgumentsOutsideOfHandler() throws Exception { + final TestableNetworkOfferCallback callback = new TestableNetworkOfferCallback( + TIMEOUT_MS /* timeout */, TEST_CALLBACK_TIMEOUT_MS /* noCallbackTimeout */); + final NetworkProvider testProvider = new NetworkProvider(mServiceContext, + mCsHandlerThread.getLooper(), "Test provider"); + final NetworkCapabilities caps = new NetworkCapabilities.Builder() + .addCapability(NET_CAPABILITY_INTERNET) + .addCapability(NET_CAPABILITY_NOT_VCN_MANAGED) + .build(); + + final NetworkScore score = new NetworkScore.Builder().build(); + testProvider.registerNetworkOffer(score, caps, r -> r.run(), callback); + testProvider.unregisterNetworkOffer(callback); + + assertThrows(NullPointerException.class, + () -> mService.offerNetwork(100, score, caps, null)); + assertThrows(NullPointerException.class, () -> mService.unofferNetwork(null)); + } + @Test public void testIgnoreValidationAfterRoamDisabled() throws Exception { assumeFalse(SdkLevel.isAtLeastT());