From bfc0b6187c9e384a08ec30cde7e2de91cd635dad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20=C5=BBenczykowski?= Date: Wed, 28 Aug 2024 17:45:25 -0700 Subject: [PATCH] NetBpfLoad: better log message on program load failure MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We're reduced logging enough that it is no longer clear which program failed to load. Test: TreeHugger Signed-off-by: Maciej Żenczykowski Change-Id: I8919a055f82d0c0e6e6818799463c606e853f70b --- bpf/loader/NetBpfLoad.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/bpf/loader/NetBpfLoad.cpp b/bpf/loader/NetBpfLoad.cpp index 55e41d3989..93dffb6732 100644 --- a/bpf/loader/NetBpfLoad.cpp +++ b/bpf/loader/NetBpfLoad.cpp @@ -1018,10 +1018,11 @@ static int loadCodeSections(const char* elfPath, vector& cs, const ALOGW("BPF_PROG_LOAD - END log_buf contents."); if (cs[i].prog_def->optional) { - ALOGW("failed program is marked optional - continuing..."); + ALOGW("failed program %s is marked optional - continuing...", + cs[i].name.c_str()); continue; } - ALOGE("non-optional program failed to load."); + ALOGE("non-optional program %s failed to load.", cs[i].name.c_str()); } }