Merge "Address aosp/3541181 leftover comments" into main
This commit is contained in:
commit
bd1703ff4f
2 changed files with 6 additions and 12 deletions
|
|
@ -767,23 +767,17 @@ public class TetheringConfigurationTest {
|
||||||
mMockContext, mLog, INVALID_SUBSCRIPTION_ID, mDeps).readEnableSyncSM(mMockContext);
|
mMockContext, mLog, INVALID_SUBSCRIPTION_ID, mDeps).readEnableSyncSM(mMockContext);
|
||||||
}
|
}
|
||||||
|
|
||||||
private void assertEnableSyncSM(boolean value) {
|
|
||||||
assertEquals(value, TetheringConfiguration.USE_SYNC_SM);
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void testEnableSyncSMFlag() throws Exception {
|
public void testEnableSyncSMFlag() throws Exception {
|
||||||
// Test default enabled
|
// Test default enabled
|
||||||
setTetherEnableSyncSMFlagEnabled(null);
|
setTetherEnableSyncSMFlagEnabled(null);
|
||||||
assertEnableSyncSM(true);
|
assertEquals(true, TetheringConfiguration.USE_SYNC_SM);
|
||||||
|
|
||||||
setTetherEnableSyncSMFlagEnabled(true);
|
setTetherEnableSyncSMFlagEnabled(true);
|
||||||
assertEnableSyncSM(true);
|
assertEquals(true, TetheringConfiguration.USE_SYNC_SM);
|
||||||
|
|
||||||
// Feature is enabled by default after 25Q2 release.
|
// Feature is enabled forcefully after 25Q2 release.
|
||||||
if (!SdkUtil.isAtLeast25Q2()) {
|
setTetherEnableSyncSMFlagEnabled(false);
|
||||||
setTetherEnableSyncSMFlagEnabled(false);
|
assertEquals(SdkUtil.isAtLeast25Q2(), TetheringConfiguration.USE_SYNC_SM);
|
||||||
assertEnableSyncSM(false);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -52,6 +52,6 @@ public class SdkUtil {
|
||||||
|
|
||||||
/** Checks if the device is running on a release version of Android Baklava or newer */
|
/** Checks if the device is running on a release version of Android Baklava or newer */
|
||||||
public static boolean isAtLeast25Q2() {
|
public static boolean isAtLeast25Q2() {
|
||||||
return SDK_INT >= 36 || (SDK_INT == 35 && "Baklava".equals(Build.VERSION.CODENAME));
|
return SDK_INT >= 36 || (SDK_INT == 35 && "Baklava".equals(Build.VERSION.CODENAME));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue