From b824e0f2aa2b69302a3b06ba96a5b8d7c8825c96 Mon Sep 17 00:00:00 2001 From: Mohannad Farrag Date: Thu, 2 May 2024 10:47:59 +0000 Subject: [PATCH] Move Cronet's MTS/CTS to external/cronet * Cronet MTS / configuration changes continuously on each new import that we do and coordinating two different repositories while doing an import is unnecessarily added friction for which we wish to avoid. Moving configuration to external/cronet will allow us to reduce test divergence COMPLETELY which will make our import process easier. * The code under test exists under `external/cronet` which makes sense that the testing modules should live next to the code under test. * Moved CTS tests to external/cronet as the code under test lives in external/cronet. Test: TH Bug: 304217500 Bug: 338358650 Change-Id: I7537985f66ba36169219472cc268fe8fd5b3c58d --- Cronet/tests/OWNERS | 8 - Cronet/tests/common/Android.bp | 79 --- Cronet/tests/common/AndroidManifest.xml | 36 -- Cronet/tests/common/AndroidTest.xml | 59 -- Cronet/tests/common/jarjar_excludes.txt | 29 - Cronet/tests/common/res/raw/quicroot.pem | 19 - .../values/cronet-test-rule-configuration.xml | 20 - .../res/xml/network_security_config.xml | 47 -- Cronet/tests/cts/Android.bp | 71 --- Cronet/tests/cts/AndroidManifest.xml | 35 -- Cronet/tests/cts/AndroidTest.xml | 38 -- Cronet/tests/cts/assets/html/hello_world.html | 24 - .../cts/res/xml/network_security_config.xml | 23 - .../net/http/cts/BidirectionalStreamTest.kt | 201 ------- .../net/http/cts/CallbackExceptionTest.kt | 70 --- .../cts/ConnectionMigrationOptionsTest.kt | 71 --- .../android/net/http/cts/DnsOptionsTest.kt | 153 ----- .../android/net/http/cts/HttpEngineTest.java | 402 ------------- .../net/http/cts/NetworkExceptionTest.kt | 65 --- .../android/net/http/cts/QuicExceptionTest.kt | 46 -- .../android/net/http/cts/QuicOptionsTest.kt | 87 --- .../android/net/http/cts/UrlRequestTest.java | 526 ------------------ .../net/http/cts/UrlResponseInfoTest.kt | 70 --- .../net/http/cts/util/HttpCtsTestServer.kt | 57 -- .../util/TestBidirectionalStreamCallback.java | 485 ---------------- .../net/http/cts/util/TestStatusListener.kt | 38 -- .../http/cts/util/TestUrlRequestCallback.java | 481 ---------------- .../android/net/http/cts/util/TestUtils.kt | 40 -- .../http/cts/util/UploadDataProviders.java | 209 ------- TEST_MAPPING | 31 +- 30 files changed, 3 insertions(+), 3517 deletions(-) delete mode 100644 Cronet/tests/OWNERS delete mode 100644 Cronet/tests/common/Android.bp delete mode 100644 Cronet/tests/common/AndroidManifest.xml delete mode 100644 Cronet/tests/common/AndroidTest.xml delete mode 100644 Cronet/tests/common/jarjar_excludes.txt delete mode 100644 Cronet/tests/common/res/raw/quicroot.pem delete mode 100644 Cronet/tests/common/res/values/cronet-test-rule-configuration.xml delete mode 100644 Cronet/tests/common/res/xml/network_security_config.xml delete mode 100644 Cronet/tests/cts/Android.bp delete mode 100644 Cronet/tests/cts/AndroidManifest.xml delete mode 100644 Cronet/tests/cts/AndroidTest.xml delete mode 100644 Cronet/tests/cts/assets/html/hello_world.html delete mode 100644 Cronet/tests/cts/res/xml/network_security_config.xml delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/BidirectionalStreamTest.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/CallbackExceptionTest.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/ConnectionMigrationOptionsTest.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/DnsOptionsTest.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/HttpEngineTest.java delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/NetworkExceptionTest.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/QuicExceptionTest.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/QuicOptionsTest.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/UrlRequestTest.java delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/UrlResponseInfoTest.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/util/HttpCtsTestServer.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/util/TestBidirectionalStreamCallback.java delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/util/TestStatusListener.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/util/TestUrlRequestCallback.java delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/util/TestUtils.kt delete mode 100644 Cronet/tests/cts/src/android/net/http/cts/util/UploadDataProviders.java diff --git a/Cronet/tests/OWNERS b/Cronet/tests/OWNERS deleted file mode 100644 index a35a789bdb..0000000000 --- a/Cronet/tests/OWNERS +++ /dev/null @@ -1,8 +0,0 @@ -# Bug component: 31808 - -set noparent -file:platform/packages/modules/Connectivity:main:/OWNERS_core_networking_xts - -# TODO: Temp ownership to develop cronet CTS -colibie@google.com #{LAST_RESORT_SUGGESTION} -prohr@google.com #{LAST_RESORT_SUGGESTION} diff --git a/Cronet/tests/common/Android.bp b/Cronet/tests/common/Android.bp deleted file mode 100644 index 0b6eceffc7..0000000000 --- a/Cronet/tests/common/Android.bp +++ /dev/null @@ -1,79 +0,0 @@ -// Copyright (C) 2023 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. -// - -// Tests in this folder are included both in unit tests and CTS. -// They must be fast and stable, and exercise public or test APIs. - -package { - default_team: "trendy_team_fwk_core_networking", - // See: http://go/android-license-faq - default_applicable_licenses: ["Android-Apache-2.0"], -} - -// TODO: Consider merging with ConnectivityCoverageTests which is a collection of all -// Connectivity tests being used for coverage. This will depend on how far we decide to -// go with merging NetHttp and Tethering targets. -// Target used for coverage. Combines CTS tests and our MTS tests. -android_test { - name: "NetHttpCoverageTests", - enforce_default_target_sdk_version: true, - min_sdk_version: "30", - test_suites: [ - "general-tests", - "mts-tethering", - ], - static_libs: [ - "modules-utils-native-coverage-listener", - "CtsNetHttpTestsLib", - "NetHttpTestsLibPreJarJar", - ], - jarjar_rules: ":net-http-test-jarjar-rules", - compile_multilib: "both", // Include both the 32 and 64 bit versions - jni_libs: [ - "cronet_aml_components_cronet_android_cronet_tests__testing", - "cronet_aml_third_party_netty_tcnative_netty_tcnative_so__testing", - "libnativecoverage", - ], - data: [":cronet_javatests_resources"], -} - -// MTS-only specific targets. -java_genrule { - name: "net-http-test-jarjar-rules", - tool_files: [ - ":NetHttpTestsLibPreJarJar{.jar}", - "jarjar_excludes.txt", - ], - tools: [ - "jarjar-rules-generator", - ], - out: ["net_http_test_jarjar_rules.txt"], - cmd: "$(location jarjar-rules-generator) " + - "$(location :NetHttpTestsLibPreJarJar{.jar}) " + - "--prefix android.net.connectivity " + - "--excludes $(location jarjar_excludes.txt) " + - "--output $(out)", -} - -android_library { - name: "NetHttpTestsLibPreJarJar", - static_libs: [ - "cronet_aml_api_java", - "cronet_aml_java__testing", - "cronet_java_tests", - ], - sdk_version: "module_current", - min_sdk_version: "30", -} diff --git a/Cronet/tests/common/AndroidManifest.xml b/Cronet/tests/common/AndroidManifest.xml deleted file mode 100644 index 418af8641b..0000000000 --- a/Cronet/tests/common/AndroidManifest.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - - - - - - - - - - - - - - diff --git a/Cronet/tests/common/AndroidTest.xml b/Cronet/tests/common/AndroidTest.xml deleted file mode 100644 index bb7ed11473..0000000000 --- a/Cronet/tests/common/AndroidTest.xml +++ /dev/null @@ -1,59 +0,0 @@ - - - - -