From aecfab5f72cdaa7034f91126b470e952d20ea0be Mon Sep 17 00:00:00 2001 From: Patrick Rohr Date: Thu, 7 Jul 2022 11:46:33 -0700 Subject: [PATCH] NetworkProvider: add missing synchronization Adding missing lock to unregisterNetworkOffer() call. Test: TH Change-Id: Ia54664caaecb63e0bfa737903b48d08856fb4877 --- framework/src/android/net/NetworkProvider.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/framework/src/android/net/NetworkProvider.java b/framework/src/android/net/NetworkProvider.java index 0665af5849..4dd642e11c 100644 --- a/framework/src/android/net/NetworkProvider.java +++ b/framework/src/android/net/NetworkProvider.java @@ -326,7 +326,9 @@ public class NetworkProvider { public void unregisterNetworkOffer(final @NonNull NetworkOfferCallback callback) { final NetworkOfferCallbackProxy proxy = findProxyForCallback(callback); if (null == proxy) return; - mProxies.remove(proxy); + synchronized (mProxies) { + mProxies.remove(proxy); + } mContext.getSystemService(ConnectivityManager.class).unofferNetwork(proxy); } }