From 12b002deaf34b0f223597208a7cd985cbe979b5c Mon Sep 17 00:00:00 2001 From: Chiachang Wang Date: Thu, 18 Jan 2024 06:18:44 +0000 Subject: [PATCH] Address review feedback This commit addresses the review feeback of aosp/2864606 to add a wtf log for unexpected cases. Bug: 320842025 Test: m Change-Id: I1581b0e754b74aac72278a0db61d9836618d50b5 --- .../com/android/net/module/util/netlink/InetDiagMessage.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/staticlibs/device/com/android/net/module/util/netlink/InetDiagMessage.java b/staticlibs/device/com/android/net/module/util/netlink/InetDiagMessage.java index 1a326b5205..b980c7d81d 100644 --- a/staticlibs/device/com/android/net/module/util/netlink/InetDiagMessage.java +++ b/staticlibs/device/com/android/net/module/util/netlink/InetDiagMessage.java @@ -180,7 +180,10 @@ public class InetDiagMessage extends NetlinkMessage { while (payload.position() < payloadLength) { final StructNlAttr attr = StructNlAttr.parse(payload); // Stop parsing for truncated or malformed attribute - if (attr == null) return null; + if (attr == null) { + Log.wtf(TAG, "Got truncated or malformed attribute"); + return null; + } msg.nlAttrs.add(attr); }