joy/android_packages_modules_Connectivity
Watch
1
Fork
You've already forked android_packages_modules_Connectivity
 0
Code Issues Pull requests Projects Releases Wiki Activity

ethernet: remove buggy test expectations for compatibility

Browse source 
EthernetManagerTest#testCallbacks() should not enforce up/up/down/up
callbacks, so this bug can be fixed in mainline without breaking CTS13.

Test: atest EthernetManagerTest
Change-Id: I1650bbc2a5883a874b92ecf2bcc7a56d01f4a905
This commit is contained in:
Patrick Rohr 2022-08-17 12:23:53 -07:00
commit 8b983158dc
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/cts/net/src/android/net/cts/EthernetManagerTest.kt
View file

@ -496,11 +496,10 @@ class EthernetManagerTest {
validateListenerOnRegistration(listener1)
// If an interface appears, existing callbacks see it.
// TODO: fix the up/up/down/up callbacks and only send down/up.
val iface2 = createInterface()
listener1.expectCallback(iface2, STATE_LINK_UP, ROLE_CLIENT)
listener1.expectCallback(iface2, STATE_LINK_UP, ROLE_CLIENT)
listener1.expectCallback(iface2, STATE_LINK_DOWN, ROLE_CLIENT)
// TODO: fix the up/up/down/up callbacks and only send down/up. Change to expectCallback
// once that is fixed.
listener1.eventuallyExpect(iface2, STATE_LINK_DOWN, ROLE_CLIENT)
listener1.expectCallback(iface2, STATE_LINK_UP, ROLE_CLIENT)
// Register a new listener, it should see state of all existing interfaces immediately.