diff --git a/service/src/com/android/server/ConnectivityService.java b/service/src/com/android/server/ConnectivityService.java index 47cd3e119e..07375c7f4c 100644 --- a/service/src/com/android/server/ConnectivityService.java +++ b/service/src/com/android/server/ConnectivityService.java @@ -1966,7 +1966,7 @@ public class ConnectivityService extends IConnectivityManager.Stub mAppOpsManager = (AppOpsManager) mContext.getSystemService(Context.APP_OPS_SERVICE); mLocationPermissionChecker = mDeps.makeLocationPermissionChecker(mContext); mRequestRestrictedWifiEnabled = mDeps.isAtLeastU() - && mDeps.isFeatureEnabled(context, REQUEST_RESTRICTED_WIFI); + && mDeps.isFeatureNotChickenedOut(context, REQUEST_RESTRICTED_WIFI); mBackgroundFirewallChainEnabled = mDeps.isAtLeastV() && mDeps.isFeatureNotChickenedOut( context, ConnectivityFlags.BACKGROUND_FIREWALL_CHAIN); mUseDeclaredMethodsForCallbacksEnabled = diff --git a/service/src/com/android/server/connectivity/CarrierPrivilegeAuthenticator.java b/service/src/com/android/server/connectivity/CarrierPrivilegeAuthenticator.java index 14a935f546..84475fea36 100644 --- a/service/src/com/android/server/connectivity/CarrierPrivilegeAuthenticator.java +++ b/service/src/com/android/server/connectivity/CarrierPrivilegeAuthenticator.java @@ -97,7 +97,7 @@ public class CarrierPrivilegeAuthenticator { mContext = c; mTelephonyManager = t; mTelephonyManagerShim = telephonyManagerShim; - mUseCallbacksForServiceChanged = deps.isFeatureEnabled( + mUseCallbacksForServiceChanged = deps.isFeatureNotChickenedOut( c, CARRIER_SERVICE_CHANGED_USE_CALLBACK); mRequestRestrictedWifiEnabled = requestRestrictedWifiEnabled; mListener = listener; @@ -159,10 +159,10 @@ public class CarrierPrivilegeAuthenticator { } /** - * @see DeviceConfigUtils#isTetheringFeatureEnabled + * @see DeviceConfigUtils#isTetheringFeatureNotChickenedOut */ - public boolean isFeatureEnabled(Context context, String name) { - return DeviceConfigUtils.isTetheringFeatureEnabled(context, name); + public boolean isFeatureNotChickenedOut(Context context, String name) { + return DeviceConfigUtils.isTetheringFeatureNotChickenedOut(context, name); } } diff --git a/tests/unit/java/com/android/server/ConnectivityServiceTest.java b/tests/unit/java/com/android/server/ConnectivityServiceTest.java index b144cd17a3..640806a45e 100755 --- a/tests/unit/java/com/android/server/ConnectivityServiceTest.java +++ b/tests/unit/java/com/android/server/ConnectivityServiceTest.java @@ -2183,8 +2183,6 @@ public class ConnectivityServiceTest { public boolean isFeatureEnabled(Context context, String name) { switch (name) { case ConnectivityFlags.NO_REMATCH_ALL_REQUESTS_ON_REGISTER: - case ConnectivityFlags.CARRIER_SERVICE_CHANGED_USE_CALLBACK: - case ConnectivityFlags.REQUEST_RESTRICTED_WIFI: case ConnectivityFlags.USE_DECLARED_METHODS_FOR_CALLBACKS: case ConnectivityFlags.QUEUE_CALLBACKS_FOR_FROZEN_APPS: case ConnectivityFlags.BACKGROUND_FIREWALL_CHAIN: @@ -2205,6 +2203,7 @@ public class ConnectivityServiceTest { case ConnectivityFlags.INGRESS_TO_VPN_ADDRESS_FILTERING: case ConnectivityFlags.BACKGROUND_FIREWALL_CHAIN: case ConnectivityFlags.DELAY_DESTROY_SOCKETS: + case ConnectivityFlags.REQUEST_RESTRICTED_WIFI: case ConnectivityFlags.USE_DECLARED_METHODS_FOR_CALLBACKS: case ConnectivityFlags.QUEUE_CALLBACKS_FOR_FROZEN_APPS: case ConnectivityFlags.QUEUE_NETWORK_AGENT_EVENTS_IN_SYSTEM_SERVER: diff --git a/tests/unit/java/com/android/server/connectivity/CarrierPrivilegeAuthenticatorTest.java b/tests/unit/java/com/android/server/connectivity/CarrierPrivilegeAuthenticatorTest.java index ab81abc030..54ac4fb3ba 100644 --- a/tests/unit/java/com/android/server/connectivity/CarrierPrivilegeAuthenticatorTest.java +++ b/tests/unit/java/com/android/server/connectivity/CarrierPrivilegeAuthenticatorTest.java @@ -141,7 +141,7 @@ public class CarrierPrivilegeAuthenticatorTest { mHandlerThread = new HandlerThread(CarrierPrivilegeAuthenticatorTest.class.getSimpleName()); mUseCallbacks = useCallbacks; final Dependencies deps = mock(Dependencies.class); - doReturn(useCallbacks).when(deps).isFeatureEnabled(any() /* context */, + doReturn(useCallbacks).when(deps).isFeatureNotChickenedOut(any() /* context */, eq(CARRIER_SERVICE_CHANGED_USE_CALLBACK)); doReturn(mHandlerThread).when(deps).makeHandlerThread(); doReturn(SUBSCRIPTION_COUNT).when(mTelephonyManager).getActiveModemCount();