Changing the targetSdkVersion for RESTRICT_LOCAL_NETWORK

The targetSdkVersion was set to enable after current_development version
so the test cases targetting current do not have change enabled. It was
observed that user builds did not allowed changing compat flag on
current values. Changing this to enabled after baklava.

Bug: 405183129
Test: atest ConnectivityCoverageTests
Change-Id: Ifeb7cde9f1a7d2b5a254f297207d625bf9d02731
This commit is contained in:
Sarup Dalwani 2025-03-20 21:00:34 +00:00
commit 5f020a5ab8
3 changed files with 48 additions and 16 deletions

View file

@ -139,13 +139,13 @@ public final class ConnectivityCompatChanges {
/**
* Restrict local network access.
*
* Apps targeting a release after V will require permissions to access the local network.
*
* ToDo: Update the target SDK version once it's finalized.
* @hide
*/
@ChangeId
@EnabledAfter(targetSdkVersion = Build.VERSION_CODES.CUR_DEVELOPMENT)
@EnabledAfter(targetSdkVersion = 36)
public static final long RESTRICT_LOCAL_NETWORK = 365139289L;
private ConnectivityCompatChanges() {

View file

@ -26,6 +26,7 @@
<uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION" />
<uses-permission android:name="android.permission.CHANGE_NETWORK_STATE" />
<uses-permission android:name="android.permission.CHANGE_WIFI_STATE" />
<uses-permission android:name="android.permission.NEARBY_WIFI_DEVICES" />
<uses-permission android:name="android.permission.CONNECTIVITY_USE_RESTRICTED_NETWORKS" />
<uses-permission android:name="android.permission.DISABLE_KEYGUARD" />
<uses-permission android:name="android.permission.INTERACT_ACROSS_USERS" />

View file

@ -15,6 +15,7 @@
*/
package android.net.cts
import android.Manifest.permission.NEARBY_WIFI_DEVICES
import android.Manifest.permission.NETWORK_SETTINGS
import android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE
import android.app.Instrumentation
@ -237,6 +238,12 @@ class NetworkAgentTest {
@Before
fun setUp() {
instrumentation.getUiAutomation().adoptShellPermissionIdentity()
if (SdkLevel.isAtLeastT()) {
instrumentation.getUiAutomation().grantRuntimePermission(
"android.net.cts",
NEARBY_WIFI_DEVICES
)
}
mHandlerThread.start()
}
@ -741,12 +748,24 @@ class NetworkAgentTest {
tryTest {
// This process is not the carrier service UID, so allowedUids should be ignored in all
// the following cases.
doTestAllowedUidsWithSubId(defaultSubId, TRANSPORT_CELLULAR, uid,
expectUidsPresent = false)
doTestAllowedUidsWithSubId(defaultSubId, TRANSPORT_WIFI, uid,
expectUidsPresent = false)
doTestAllowedUidsWithSubId(defaultSubId, TRANSPORT_BLUETOOTH, uid,
expectUidsPresent = false)
doTestAllowedUidsWithSubId(
defaultSubId,
TRANSPORT_CELLULAR,
uid,
expectUidsPresent = false
)
doTestAllowedUidsWithSubId(
defaultSubId,
TRANSPORT_WIFI,
uid,
expectUidsPresent = false
)
doTestAllowedUidsWithSubId(
defaultSubId,
TRANSPORT_BLUETOOTH,
uid,
expectUidsPresent = false
)
// The tools to set the carrier service package override do not exist before U,
// so there is no way to test the rest of this test on < U.
@ -764,9 +783,11 @@ class NetworkAgentTest {
val timeout = SystemClock.elapsedRealtime() + DEFAULT_TIMEOUT_MS
while (true) {
if (SystemClock.elapsedRealtime() > timeout) {
fail("Couldn't make $servicePackage the service package for $defaultSubId: " +
fail(
"Couldn't make $servicePackage the service package for $defaultSubId: " +
"dumpsys connectivity".execute().split("\n")
.filter { it.contains("Logical slot = $defaultSlotIndex.*") })
.filter { it.contains("Logical slot = $defaultSlotIndex.*") }
)
}
if ("dumpsys connectivity"
.execute()
@ -789,10 +810,18 @@ class NetworkAgentTest {
// TODO(b/315136340): Allow ownerUid to see allowedUids and enable below test case
// doTestAllowedUids(defaultSubId, TRANSPORT_WIFI, uid, expectUidsPresent = true)
}
doTestAllowedUidsWithSubId(defaultSubId, TRANSPORT_BLUETOOTH, uid,
expectUidsPresent = false)
doTestAllowedUidsWithSubId(defaultSubId, intArrayOf(TRANSPORT_CELLULAR, TRANSPORT_WIFI),
uid, expectUidsPresent = false)
doTestAllowedUidsWithSubId(
defaultSubId,
TRANSPORT_BLUETOOTH,
uid,
expectUidsPresent = false
)
doTestAllowedUidsWithSubId(
defaultSubId,
intArrayOf(TRANSPORT_CELLULAR, TRANSPORT_WIFI),
uid,
expectUidsPresent = false
)
}
}
@ -1848,8 +1877,10 @@ class NetworkAgentTest {
it.setTransportInfo(VpnTransportInfo(
VpnManager.TYPE_VPN_PLATFORM,
sessionId,
/*bypassable=*/ false,
/*longLivedTcpConnectionsExpensive=*/ false
/*bypassable=*/
false,
/*longLivedTcpConnectionsExpensive=*/
false
))
it.underlyingNetworks = listOf()
}