joy/android_packages_modules_Connectivity
Watch
1
Fork
You've already forked android_packages_modules_Connectivity
 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge "Revert^2 "Update NetworkAgent#register to compatible with old NetworkAgentTest"" into main am: dda4052e54

Browse source 
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2854710

Change-Id: I81d96743cdaaff28acbec3368a33260ddd777255
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Motomu Utsumi 2023-12-01 12:50:08 +00:00 • committed by Automerger Merge Worker
commit 58e4e95fc7
2 changed files with 25 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

19
framework/src/android/net/NetworkAgent.java
View file

@ -756,11 +756,20 @@ public abstract class NetworkAgent {
} }
final ConnectivityManager cm = (ConnectivityManager) mInitialConfiguration.context final ConnectivityManager cm = (ConnectivityManager) mInitialConfiguration.context
.getSystemService(Context.CONNECTIVITY_SERVICE); .getSystemService(Context.CONNECTIVITY_SERVICE);
mNetwork = cm.registerNetworkAgent(new NetworkAgentBinder(mHandler), if (mInitialConfiguration.localNetworkConfig == null) {
new NetworkInfo(mInitialConfiguration.info), // Call registerNetworkAgent without localNetworkConfig argument to pass
mInitialConfiguration.properties, mInitialConfiguration.capabilities, // android.net.cts.NetworkAgentTest#testAgentStartsInConnecting in old cts
mInitialConfiguration.localNetworkConfig, mInitialConfiguration.score, mNetwork = cm.registerNetworkAgent(new NetworkAgentBinder(mHandler),
mInitialConfiguration.config, providerId); new NetworkInfo(mInitialConfiguration.info),
mInitialConfiguration.properties, mInitialConfiguration.capabilities,
mInitialConfiguration.score, mInitialConfiguration.config, providerId);
} else {
mNetwork = cm.registerNetworkAgent(new NetworkAgentBinder(mHandler),
new NetworkInfo(mInitialConfiguration.info),
mInitialConfiguration.properties, mInitialConfiguration.capabilities,
mInitialConfiguration.localNetworkConfig, mInitialConfiguration.score,
mInitialConfiguration.config, providerId);
}
mInitialConfiguration = null; // All this memory can now be GC'd mInitialConfiguration = null; // All this memory can now be GC'd
} }
return mNetwork; return mNetwork;

23
tests/cts/net/src/android/net/cts/NetworkAgentTest.kt
View file

@ -131,17 +131,6 @@ import com.android.testutils.TestableNetworkCallback
import com.android.testutils.assertThrows import com.android.testutils.assertThrows
import com.android.testutils.runAsShell import com.android.testutils.runAsShell
import com.android.testutils.tryTest import com.android.testutils.tryTest
import org.junit.After
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.ArgumentMatchers.any
import org.mockito.ArgumentMatchers.argThat
import org.mockito.ArgumentMatchers.eq
import org.mockito.Mockito.doReturn
import org.mockito.Mockito.mock
import org.mockito.Mockito.timeout
import org.mockito.Mockito.verify
import java.io.Closeable import java.io.Closeable
import java.io.IOException import java.io.IOException
import java.net.DatagramSocket import java.net.DatagramSocket
@ -160,6 +149,17 @@ import kotlin.test.assertNotNull
import kotlin.test.assertNull import kotlin.test.assertNull
import kotlin.test.assertTrue import kotlin.test.assertTrue
import kotlin.test.fail import kotlin.test.fail
import org.junit.After
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.ArgumentMatchers.any
import org.mockito.ArgumentMatchers.argThat
import org.mockito.ArgumentMatchers.eq
import org.mockito.Mockito.doReturn
import org.mockito.Mockito.mock
import org.mockito.Mockito.timeout
import org.mockito.Mockito.verify
private const val TAG = "NetworkAgentTest" private const val TAG = "NetworkAgentTest"
// This test doesn't really have a constraint on how fast the methods should return. If it's // This test doesn't really have a constraint on how fast the methods should return. If it's
@ -951,7 +951,6 @@ class NetworkAgentTest {
argThat<NetworkInfo> { it.detailedState == NetworkInfo.DetailedState.CONNECTING }, argThat<NetworkInfo> { it.detailedState == NetworkInfo.DetailedState.CONNECTING },
any(LinkProperties::class.java), any(LinkProperties::class.java),
any(NetworkCapabilities::class.java), any(NetworkCapabilities::class.java),
any(), // LocalNetworkConfig TODO : specify when it's public
any(NetworkScore::class.java), any(NetworkScore::class.java),
any(NetworkAgentConfig::class.java), any(NetworkAgentConfig::class.java),
eq(NetworkProvider.ID_NONE)) eq(NetworkProvider.ID_NONE))