From 46102348e0c7a92bf2f232b59b633df5e9eb8a32 Mon Sep 17 00:00:00 2001 From: Jimi Chen Date: Thu, 19 Sep 2024 10:48:38 +0000 Subject: [PATCH] Use unicast instead of broadcast as ethernet destination in `test_apf_drop_ethercat` To prevent packet dropped earlier by multicast filtering, use unicast ethernet destination instead Bug: 360730207 Test: m connectivity_multi_devices_snippet && atest CtsConnectivityMultiDevicesTestCases:ApfV4Test Change-Id: I4816b71f68f349abf1423c7013bb058ccc233d61 --- staticlibs/testutils/host/python/apf_test_base.py | 3 +++ tests/cts/multidevices/apfv4_test.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/staticlibs/testutils/host/python/apf_test_base.py b/staticlibs/testutils/host/python/apf_test_base.py index 9a30978420..891876b7a9 100644 --- a/staticlibs/testutils/host/python/apf_test_base.py +++ b/staticlibs/testutils/host/python/apf_test_base.py @@ -50,6 +50,9 @@ class ApfTestBase(multi_devices_test_base.MultiDevicesTestBase): self.server_mac_address = apf_utils.get_hardware_address( self.serverDevice, self.server_iface_name ) + self.client_mac_address = apf_utils.get_hardware_address( + self.clientDevice, self.client_iface_name + ) # Enable doze mode to activate APF. adb_utils.set_doze_mode(self.clientDevice, True) diff --git a/tests/cts/multidevices/apfv4_test.py b/tests/cts/multidevices/apfv4_test.py index 7795be523a..aa535fd3fc 100644 --- a/tests/cts/multidevices/apfv4_test.py +++ b/tests/cts/multidevices/apfv4_test.py @@ -53,7 +53,7 @@ class ApfV4Test(apf_test_base.ApfTestBase, parameterized.TestCase): ) # Declare inputs for state_str and expected_result. def test_apf_drop_ethertype_not_allowed(self, blocked_ether_type): # Ethernet header (14 bytes). - packet = ETHER_BROADCAST_ADDR # Destination MAC (broadcast) + packet = self.client_mac_address.replace(":", "") # Destination MAC packet += self.server_mac_address.replace(":", "") # Source MAC packet += blocked_ether_type