From c2c57a3a8e4fa5dc1e09ab70f69eec63080e4bb3 Mon Sep 17 00:00:00 2001 From: Motomu Utsumi Date: Fri, 29 Jul 2022 05:23:16 +0000 Subject: [PATCH] Mark testFirewallBlocking as ConnectivityModuleTest ConnectivityManager#getFirewallChainEnabled was added after T. So this test will fail on T without an updated connectivity module. Test: atest CtsNetTestCasesLatestSdk Bug: 240510152 Change-Id: I28b908663b3a8e558f911793ff178a2e7dc9ae3b --- tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java b/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java index 64238b3d9c..5edf727ac3 100644 --- a/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java +++ b/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java @@ -189,6 +189,7 @@ import com.android.networkstack.apishim.ConstantsShim; import com.android.networkstack.apishim.NetworkInformationShimImpl; import com.android.networkstack.apishim.common.ConnectivityManagerShim; import com.android.testutils.CompatUtil; +import com.android.testutils.ConnectivityModuleTest; import com.android.testutils.DevSdkIgnoreRule; import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo; import com.android.testutils.DeviceInfoUtils; @@ -3358,7 +3359,7 @@ public class ConnectivityManagerTest { }, NETWORK_SETTINGS); } - @Test @IgnoreUpTo(SC_V2) + @Test @IgnoreUpTo(SC_V2) @ConnectivityModuleTest @AppModeFull(reason = "Socket cannot bind in instant app mode") public void testFirewallBlocking() { // ALLOWLIST means the firewall denies all by default, uids must be explicitly allowed