From 2ebff8a777eac80c021b3e73135834d74a37851c Mon Sep 17 00:00:00 2001 From: Patrick Rohr Date: Tue, 7 Jun 2022 16:13:43 -0700 Subject: [PATCH] TestNetworkService: Fix TestNetworkInterface parcel flags PARCELABLE_WRITE_RETURN_VALUE will close the fd when writeParcelable is called. This is not always preferable (specifically, if TestNetworkInterface is passed as an "in" parameter). writeParcelable(FileDescriptor, ...) should therefore use the flags passed to writeToParcel which should be correct for all cases. Test: atest EthernetManagerTest Change-Id: Ibb5f14028a3d686157504da3657a18ec0bc28110 --- framework/src/android/net/TestNetworkInterface.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/src/android/net/TestNetworkInterface.java b/framework/src/android/net/TestNetworkInterface.java index 4449ff8018..a3239fca38 100644 --- a/framework/src/android/net/TestNetworkInterface.java +++ b/framework/src/android/net/TestNetworkInterface.java @@ -40,7 +40,7 @@ public final class TestNetworkInterface implements Parcelable { @Override public void writeToParcel(@NonNull Parcel out, int flags) { - out.writeParcelable(mFileDescriptor, PARCELABLE_WRITE_RETURN_VALUE); + out.writeParcelable(mFileDescriptor, flags); out.writeString(mInterfaceName); }