android_packages_modules_Co.../PREUPLOAD.cfg

[Builtin Hooks]
bpfmt = true
clang_format = true
rustfmt = true

[Builtin Hooks Options]
clang_format = --commit ${PREUPLOAD_COMMIT} --style file --extensions c,h,cc,cpp,hpp
rustfmt = --config-path=rustfmt.toml

[Hook Scripts]
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}

ktlint_hook = ${REPO_ROOT}/prebuilts/ktlint/ktlint.py --disabled-rules comment-wrapping -f ${PREUPLOAD_FILES}

hidden_api_txt_checksorted_hook = ${REPO_ROOT}/tools/platform-compat/hiddenapi/checksorted_sha.sh ${PREUPLOAD_COMMIT} ${REPO_ROOT}

python_hook = ${REPO_ROOT}/packages/modules/Connectivity/preupload_hook_script.py ${PREUPLOAD_FILES}

# go/alint for details
alint_hook = ${REPO_ROOT}/vendor/google/tools/alint
Enable builtin formatting hooks Enable bpfmt, clang_format, and ktfmt instead of ktlint. ktfmt is better adapted to Android style than ktlint, see external/ktfmt/README.md. In particular ktlint does not allow comments with argument names when calling java functions like: myFunction(/* arg1= / 0, / arg2= / null) or like: myFunction(0 / arg1 /, null / arg2 */) Test: upload Change-Id: I0a134d8b0807f9b016ab7c416e4fad335baa310e 2024-07-17 11:27:48 +09:00			`[Builtin Hooks]`
			`bpfmt = true`
			`clang_format = true`
Add rustfmt to p/m/C Test: try to upload .rs Change-Id: I8ccea161da10db8505e1f0aa5fb22f6c6952373e 2025-03-28 10:04:34 -07:00			`rustfmt = true`
Enable builtin formatting hooks Enable bpfmt, clang_format, and ktfmt instead of ktlint. ktfmt is better adapted to Android style than ktlint, see external/ktfmt/README.md. In particular ktlint does not allow comments with argument names when calling java functions like: myFunction(/* arg1= / 0, / arg2= / null) or like: myFunction(0 / arg1 /, null / arg2 */) Test: upload Change-Id: I0a134d8b0807f9b016ab7c416e4fad335baa310e 2024-07-17 11:27:48 +09:00
			`[Builtin Hooks Options]`
			`clang_format = --commit ${PREUPLOAD_COMMIT} --style file --extensions c,h,cc,cpp,hpp`
Add rustfmt to p/m/C Test: try to upload .rs Change-Id: I8ccea161da10db8505e1f0aa5fb22f6c6952373e 2025-03-28 10:04:34 -07:00			`rustfmt = --config-path=rustfmt.toml`
Enable builtin formatting hooks Enable bpfmt, clang_format, and ktfmt instead of ktlint. ktfmt is better adapted to Android style than ktlint, see external/ktfmt/README.md. In particular ktlint does not allow comments with argument names when calling java functions like: myFunction(/* arg1= / 0, / arg2= / null) or like: myFunction(0 / arg1 /, null / arg2 */) Test: upload Change-Id: I0a134d8b0807f9b016ab7c416e4fad335baa310e 2024-07-17 11:27:48 +09:00
Add repo hooks for packages/modules/Connectivity. This adds the Java and Kotlin linters. Test: repo upload Change-Id: Ic508b17ed0b4e33c41debbbeb7a6c0406c46a973 2020-11-27 17:11:56 +09:00			`[Hook Scripts]`
			`checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}`

Disable ktfmt and rely solely on ktlint for Kotlin linting This change disables the ktfmt tool and uses only ktlint for linting Kotlin files. Due to previous bugs (fixed in aosp/3391169), ktfmt was not functioning correctly before. Enabling ktfmt will cause entire files to be reformatted without specific error reporting. By relying solely on ktlint, we ensure more precise and informative linting feedback. Test: TH Change-Id: Iad58badb4fc431e52a5b02489cfa6cd46712bf37 2024-12-13 12:13:08 +09:00			`ktlint_hook = ${REPO_ROOT}/prebuilts/ktlint/ktlint.py --disabled-rules comment-wrapping -f ${PREUPLOAD_FILES}`
Enable tethering to perform its own hidden API processing Previously, the hidden API encoding of the tethering boot dex jars, i.e. those dex jars that tethering contributes to the bootclasspath were done as part of the monolithic hidden API processing. This change causes the encoding to be done by the tethering's bootclasspath_fragment. This change involves the following: * Addition of the fragments property to the tethering's bootclasspath_fragment module to list all the other bootclasspath_fragment modules on which this depends. * Addition of the additional_stubs property to add stubs for APIs that are not provided by another bootclasspath_fragment. * Moving hidden API flag file entries related to tethering from the flag files in frameworks/base/boot/hiddenapi directory into the tethering directory with an appropriate OWNERS file to allow them to be managed by the Soong and compat team. * Addition of a PREUPLOAD.cfg hook script to ensure that the flag files are sorted. The build automatically checks that the hidden API flags which are computed by tethering and encoded into its boot dex jars match those that are generated by the monolithic processing so this is guaranteed to be safe. Bug: 179354495 Test: m com.android.tethering - ensure that the generated APEX is byte-for-byte identical before and after these changes. m out/soong/hiddenapi/hiddenapi-flags.csv - make sure that they are not changed by this. Change-Id: I4d9621325c7fcea5043cbca4c577ba2ac6125c0c Ignore-AOSP-First: merge conflicts 2021-05-26 10:46:20 +01:00
			`hidden_api_txt_checksorted_hook = ${REPO_ROOT}/tools/platform-compat/hiddenapi/checksorted_sha.sh ${PREUPLOAD_COMMIT} ${REPO_ROOT}`
Refactor: apply pyformat for coding style consistency add pyformat for presubmit hook Flag: EXEMPT mainline Bug: 419423721 Test: atest CtsConnectivityMultiDevicesTestCases Change-Id: I9abc5cee454e8c8e21ce7e3c134145857680251f 2025-05-28 09:33:18 +00:00
			`python_hook = ${REPO_ROOT}/packages/modules/Connectivity/preupload_hook_script.py ${PREUPLOAD_FILES}`
Add alint hook to Connectivity repo Onboarding repo to go/alint, which will run ayeaye analyzers locally. Bug: 419241911 Test: Locally Flag: NONE, repo change Change-Id: I78b938222ac73f00438692045e4c062cb5356029 2025-05-30 11:36:49 +00:00
			`# go/alint for details`
			`alint_hook = ${REPO_ROOT}/vendor/google/tools/alint`