Namhyung Kim
813ccd1545
perf tools: Fix segfault for symbol annotation on TUI ...
Currently the symbol structure is allocated with symbol_conf.priv_size
to carry sideband information like annotation, map browser on TUI and
sort-by-name tree node. So retrieving these information from symbol
needs to care about the details of such placement.
However the annotation code just assumes that the symbol is placed after
the struct annotation. But actually there's other info between them.
So accessing those struct will lead to an undefined behavior (usually a
crash) after they write their info to the same location.
To reproduce the problem, please follow the steps below:
1. run perf report (TUI of course) with -v option
2. open map browser (by pressing right arrow key for any entry)
3. search any function (by pressing '/' key and input whatever..)
4. return to the hist browser (by pressing 'q' or left arrow key)
5. open annotation window for the same entry (by pressing 'a' key)
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1421234288-22758-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2015-01-16 17:49:29 -03:00
tools: Remove bitops/hweight usage of bits in tools/perf
2015-01-16 17:49:29 -03:00
perf script python: Removing event cache as it's no longer needed
2014-11-06 17:44:06 -03:00
perf tools: Introduce zfree
2013-12-27 15:17:00 -03:00
perf callchain: Make get_srcline fall back to sym+offset
2014-11-24 18:03:47 -03:00
perf tools: Fix segfault for symbol annotation on TUI
2015-01-16 17:49:29 -03:00
perf tools: Add bitmap_or function into bitmap object
2012-02-13 23:28:10 -02:00
perf buildid-cache: Remove extra debugdir variables
2014-12-09 09:14:34 -03:00
perf build-id: Move disable_buildid_cache() to util/build-id.c
2014-11-19 12:33:46 -03:00
perf tools: Elide strlcpy warning with uclibc
2015-01-16 17:49:29 -03:00
perf callchain: Free callchains when hist entries are deleted
2015-01-08 11:56:35 -03:00
perf callchain: Free callchains when hist entries are deleted
2015-01-08 11:56:35 -03:00
perf evlist: Introduce evlist__for_each() & friends
2014-01-13 10:06:25 -03:00
perf util: Replace strerror with strerror_r for thread-safety
2014-08-15 10:58:35 -03:00
perf tools: Enable close-on-exec flag on perf file descriptor
2014-07-18 09:09:34 +02:00
perf tools: Make __hpp__fmt() receive an additional len argument
2014-08-12 12:03:05 -03:00
perf tools: Make __hpp__fmt() receive an additional len argument
2014-08-12 12:03:05 -03:00
perf tools: Identify which comms are from exec
2014-08-13 19:23:08 -03:00
perf tools: Add facility to export data in database-friendly way
2014-10-29 10:32:49 -02:00
perf tools: Add --buildid-dir option to set cache directory
2014-12-09 09:14:35 -03:00
perf tools: Use cpu/possible instead of cpu/kernel_max
2014-04-22 17:39:16 +02:00
perf tools: Allow ability to map cpus to nodes easily
2014-04-22 17:39:12 +02:00
perf tools: ctype.c only wants util.h
2012-02-13 23:17:40 -02:00
perf util: Replace strerror with strerror_r for thread-safety
2014-08-15 10:58:35 -03:00
perf tools: Add perf_data_file__write interface
2013-12-02 09:22:46 -03:00
perf tools: Defer export of comms that were not 'set'
2014-11-03 18:11:59 -03:00
perf tools: Defer export of comms that were not 'set'
2014-11-03 18:11:59 -03:00
perf tools: Allow to force redirect pr_debug to stderr.
2014-11-24 18:03:48 -03:00
perf: Use strerror_r instead of strerror
2014-08-15 10:54:29 -03:00
perf tools: Add gzip decompression support for kernel module
2014-11-05 10:11:26 -03:00
perf symbols: Preparation for compressed kernel module support
2014-11-04 10:15:53 -03:00
perf probe: Fix perf probe to find correct variable DIE
2014-06-04 14:49:20 +02:00
perf probe: Fix to find line information for probe list
2013-10-04 15:16:05 -03:00
perf tools: Add id index
2014-10-29 11:24:47 -02:00
Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-12-09 21:18:06 -08:00
perf evlist: Use roundup_pow_of_two
2014-12-17 11:58:16 -03:00
perf evlist: Introduce strerror_mmap method
2014-12-11 18:03:01 -03:00
perf tools: Remove perf_evsel__read interface
2014-12-01 20:00:30 -03:00
perf stat: Add support for per-pkg counters
2014-12-01 20:00:30 -03:00
perf tools: Makefile: Remove various and sundry cruft
2011-02-18 07:43:06 -02:00
perf tools: Build programs to copy 32-bit compatibility
2014-10-29 10:32:48 -02:00
tools/perf: Standardize feature support define names to: HAVE_{FEATURE}_SUPPORT
2013-10-09 08:48:28 +02:00
perf build-id: Move disable_buildid_cache() to util/build-id.c
2014-11-19 12:33:46 -03:00
perf build-id: Move build-id related functions to util/build-id.c
2014-11-05 10:14:07 -03:00
perf tools: Use zfree to help detect use after free bugs
2013-12-27 17:08:19 -03:00
perf callchain: Free callchains when hist entries are deleted
2015-01-08 11:56:35 -03:00
perf report: Show progress bar for output resorting
2014-12-23 12:01:37 -03:00
perf util: Add findnew method to intlist
2013-10-14 10:28:48 -03:00
perf util: Add findnew method to intlist
2013-10-14 10:28:48 -03:00
perf kvm stat report: Save pid string in opts.target.pid
2014-09-17 17:08:07 -03:00
perf machine: Fix __machine__findnew_thread() error path
2015-01-16 17:49:28 -03:00
perf tools: Add facility to export data in database-friendly way
2014-10-29 10:32:49 -02:00
perf callchain: Make get_srcline fall back to sym+offset
2014-11-24 18:03:47 -03:00
perf tools: Set thread->mg.machine in all places
2014-10-29 10:32:46 -02:00
perf session: Add option to copy events when queueing
2014-10-15 17:39:03 -03:00
perf session: Add option to copy events when queueing
2014-10-15 17:39:03 -03:00
perf tools: Add cat as fallback pager
2014-05-21 11:48:33 +02:00
perf tools: Add snapshot format file parsing
2014-11-24 18:03:51 -03:00
perf tools: Parse the pmu event prefix and suffix
2014-10-15 16:05:01 -03:00
perf tools: Add support to new style format of kernel PMU event
2014-10-15 16:05:45 -03:00
perf tools: Add support to new style format of kernel PMU event
2014-10-15 16:05:45 -03:00
perf tools: Add support for exclusive option
2014-10-29 10:32:47 -02:00
perf tools: Add support for exclusive option
2014-10-29 10:32:47 -02:00
tools/perf: Turn strlcpy() into a __weak function
2013-10-09 08:48:49 +02:00
perf tools: Fix version when building out of tree
2013-11-07 10:40:47 -03:00
perf tools: Cache register accesses for unwind processing
2014-06-12 16:53:19 +02:00
perf tools: Cache register accesses for unwind processing
2014-06-12 16:53:19 +02:00
perf tools: Add snapshot format file parsing
2014-11-24 18:03:51 -03:00
perf tools: Add snapshot format file parsing
2014-11-24 18:03:51 -03:00
perf tools: Add perf pmu object to access pmu format definition
2012-03-16 14:29:35 -03:00
perf tools: Fix build with bison 2.3 and older.
2013-02-14 16:12:34 -03:00
perf probe: Propagate error code when write(2) failed
2015-01-16 17:49:28 -03:00
perf probe: Do not access kallsyms when analyzing user binaries
2014-09-17 18:01:14 -03:00
perf probe: Fix crash in dwarf_getcfi_elf
2015-01-02 12:44:01 -03:00
perf probe: Support distro-style debuginfo for uprobe
2014-02-18 09:38:44 -03:00
perf tools: Move pr_* debug macros into debug object
2014-07-17 12:58:39 -03:00
perf tools: Finish the removal of 'self' arguments
2013-11-05 15:32:36 -03:00
tools: Remove bitops/hweight usage of bits in tools/perf
2015-01-16 17:49:29 -03:00
tools lib api: Adopt fdarray class from perf's evlist
2014-09-25 16:46:55 -03:00
perf util: Add findnew method to intlist
2013-10-14 10:28:48 -03:00
perf util: Add findnew method to intlist
2013-10-14 10:28:48 -03:00
perf tools: Use sysctl__read_int instead of ad-hoc copies
2014-12-11 17:53:04 -03:00
perf util: Replace strerror with strerror_r for thread-safety
2014-08-15 10:58:35 -03:00
Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-12-09 21:18:06 -08:00
perf session: Add perf_session__deliver_synth_event()
2014-10-29 11:36:15 -02:00
tools/: Convert to new topic libraries
2013-12-16 16:03:27 -03:00
perf callchain: Make get_srcline fall back to sym+offset
2014-11-24 18:03:47 -03:00
perf tools: Add +field argument support for --field option
2014-08-24 08:11:19 -03:00
perf: Fix building warning on ARM 32
2014-12-19 13:09:43 +01:00
perf stats: Add max and min stats
2013-08-07 17:35:26 -03:00
tools: Consolidate types.h
2014-05-01 21:22:39 +02:00
perf tools: Use zfree to help detect use after free bugs
2013-12-27 17:08:19 -03:00
perf tools: Use zfree to help detect use after free bugs
2013-12-27 17:08:19 -03:00
perf tools: Finish the removal of 'self' arguments
2013-11-05 15:32:36 -03:00
Revert "perf tools: Default to cpu// for events v5"
2014-10-15 16:04:33 -03:00
perf tools: Fix build error due to zfree() cast
2014-01-15 15:10:04 -03:00
perf tools: Stop using 'self' in strlist
2013-01-25 12:49:28 -03:00
perf timechart: Implement IO mode
2014-07-10 00:22:54 +02:00
perf timechart: Implement IO mode
2014-07-10 00:22:54 +02:00
perf symbols: Move bfd_demangle stubbing to its only user
2014-11-24 18:03:47 -03:00
perf symbols: Fix use after free in filename__read_build_id
2014-12-17 11:58:17 -03:00
perf record: Do not save pathname in ./debug/.build-id directory for vmlinux
2014-11-05 10:14:08 -03:00
perf callchain: Support handling complete branch stacks as histograms
2014-12-01 20:00:31 -03:00
perf record: Make per-cpu mmaps the default.
2013-11-27 14:58:36 -03:00
perf target: Move the checking of which map function to call into function.
2013-12-04 13:46:37 -03:00
perf tools: Enhance the thread stack to output call/return data
2014-11-03 17:43:56 -03:00
perf tools: Enhance the thread stack to output call/return data
2014-11-03 17:43:56 -03:00
perf tools: Only override the default :tid comm entry
2014-11-19 12:37:26 -03:00
perf tools: Add a thread stack for synthesizing call chains
2014-11-03 17:10:59 -03:00
perf thread_map: Create dummy constructor out of open coded equivalent
2014-10-14 17:32:52 -03:00
perf thread_map: Create dummy constructor out of open coded equivalent
2014-10-14 17:32:52 -03:00
perf tools: Add id index
2014-10-29 11:24:47 -02:00
perf tools: Rename 'perf_record_opts' to 'record_opts
2013-12-19 14:43:45 -03:00
tools: Consolidate types.h
2014-05-01 21:22:39 +02:00
perf tools: Move pr_* debug macros into debug object
2014-07-17 12:58:39 -03:00
perf tools: Fix memory leak in event_format__print function
2014-02-18 09:34:47 -03:00
perf tools: Remove needless getopt.h includes
2014-07-17 12:59:00 -03:00
perf scripting: Add 'flush' callback to scripting API
2014-08-22 13:12:11 -03:00
tools lib traceevent: Make plugin unload function receive pevent
2014-01-15 15:10:40 -03:00
perf scripting: Add 'flush' callback to scripting API
2014-08-22 13:12:11 -03:00
perf tools: Move rdtsc() function
2014-07-23 11:48:11 -03:00
perf tools: Move rdtsc() function
2014-07-23 11:48:11 -03:00
perf callchains: Use thread->mg->machine
2014-10-29 10:32:46 -02:00
perf tools: Add libdw DWARF post unwind support
2014-02-24 09:29:36 -03:00
perf test: Fix dwarf unwind using libunwind.
2015-01-16 17:49:29 -03:00
perf callchains: Use thread->mg->machine
2014-10-29 10:32:46 -02:00
perf target: Introduce perf_target__parse_uid()
2012-05-07 16:46:48 -03:00
perf tools: Use sysctl__read_int instead of ad-hoc copies
2014-12-11 17:53:04 -03:00
perf: Fix building warning on ARM 32
2014-12-19 13:09:43 +01:00
perf tools: Use zfree to help detect use after free bugs
2013-12-27 17:08:19 -03:00
tools: Consolidate types.h
2014-05-01 21:22:39 +02:00
perf tools: Do not attempt to run perf-read-vdso32 if it wasn't built
2014-10-29 10:32:48 -02:00
perf tools: Add support for 32-bit compatibility VDSOs
2014-10-29 10:32:48 -02:00
perf tools: Use __maybe_used for unused variables
2012-09-11 12:19:15 -03:00
perf tools: Add gzip decompression support for kernel module
2014-11-05 10:11:26 -03:00
813ccd1545