J. Bruce Fields
7c17705e77
lockd: fix rpcbind crash on lockd startup failure
Nikita Yuschenko reported that booting a kernel with init=/bin/sh and
then nfs mounting without portmap or rpcbind running using a busybox
mount resulted in:
# mount -t nfs 10.30.130.21:/opt /mnt
svc: failed to register lockdv1 RPC service (errno 111).
lockd_up: makesock failed, error=-111
Unable to handle kernel paging request for data at address 0x00000030
Faulting instruction address: 0xc055e65c
Oops: Kernel access of bad area, sig: 11 [#1]
MPC85xx CDS
Modules linked in:
CPU: 0 PID: 1338 Comm: mount Not tainted 3.10.44.cge #117
task: cf29cea0 ti: cf35c000 task.ti: cf35c000
NIP: c055e65c LR: c0566490 CTR: c055e648
REGS: cf35dad0 TRAP: 0300 Not tainted (3.10.44.cge)
MSR: 00029000 <CE,EE,ME> CR: 22442488 XER: 20000000
DEAR: 00000030, ESR: 00000000
GPR00: c05606f4 cf35db80 cf29cea0 cf0ded80 cf0dedb8 00000001 1dec3086
00000000
GPR08: 00000000 c07b1640 00000007 1dec3086 22442482 100b9758 00000000
10090ae8
GPR16: 00000000 000186a5 00000000 00000000 100c3018 bfa46edc 100b0000
bfa46ef0
GPR24: cf386ae0 c07834f0 00000000 c0565f88 00000001 cf0dedb8 00000000
cf0ded80
NIP [c055e65c] call_start+0x14/0x34
LR [c0566490] __rpc_execute+0x70/0x250
Call Trace:
[cf35db80] [00000080] 0x80 (unreliable)
[cf35dbb0] [c05606f4] rpc_run_task+0x9c/0xc4
[cf35dbc0] [c0560840] rpc_call_sync+0x50/0xb8
[cf35dbf0] [c056ee90] rpcb_register_call+0x54/0x84
[cf35dc10] [c056f24c] rpcb_register+0xf8/0x10c
[cf35dc70] [c0569e18] svc_unregister.isra.23+0x100/0x108
[cf35dc90] [c0569e38] svc_rpcb_cleanup+0x18/0x30
[cf35dca0] [c0198c5c] lockd_up+0x1dc/0x2e0
[cf35dcd0] [c0195348] nlmclnt_init+0x2c/0xc8
[cf35dcf0] [c015bb5c] nfs_start_lockd+0x98/0xec
[cf35dd20] [c015ce6c] nfs_create_server+0x1e8/0x3f4
[cf35dd90] [c0171590] nfs3_create_server+0x10/0x44
[cf35dda0] [c016528c] nfs_try_mount+0x158/0x1e4
[cf35de20] [c01670d0] nfs_fs_mount+0x434/0x8c8
[cf35de70] [c00cd3bc] mount_fs+0x20/0xbc
[cf35de90] [c00e4f88] vfs_kern_mount+0x50/0x104
[cf35dec0] [c00e6e0c] do_mount+0x1d0/0x8e0
[cf35df10] [c00e75ac] SyS_mount+0x90/0xd0
[cf35df40] [c000ccf4] ret_from_syscall+0x0/0x3c
The addition of svc_shutdown_net() resulted in two calls to
svc_rpcb_cleanup(); the second is no longer necessary and crashes when
it calls rpcb_register_call with clnt=NULL.
Reported-by: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
Fixes: 679b033df4 "lockd: ensure we tear down any live sockets when socket creation fails during lockd_up"
Cc: stable@vger.kernel.org
Acked-by: Jeff Layton <jlayton@primarydata.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
2014-09-08 12:03:32 -04:00 |
| .. |
|
clnt4xdr.c
|
nfsd: remove <linux/nfsd/nfsfh.h>
|
2014-05-06 17:54:53 -04:00 |
|
clntlock.c
|
LOCKD: Don't call utsname()->nodename from nlmclnt_setlockargs
|
2013-08-05 15:03:46 -04:00 |
|
clntproc.c
|
LOCKD: Don't call utsname()->nodename from nlmclnt_setlockargs
|
2013-08-05 15:03:46 -04:00 |
|
clntxdr.c
|
nfsd: remove <linux/nfsd/nfsfh.h>
|
2014-05-06 17:54:53 -04:00 |
|
grace.c
|
LockD: pass actual network namespace to grace period management functions
|
2012-07-27 16:49:22 -04:00 |
|
host.c
|
Merge branch 'for-3.9' of git://linux-nfs.org/~bfields/linux
|
2013-02-28 18:02:55 -08:00 |
|
Makefile
|
lockd: Introduce new-style XDR functions for NLMv4
|
2010-12-16 12:37:23 -05:00 |
|
mon.c
|
fs: lockd: Use ktime_get_ns()
|
2014-07-23 15:01:44 -07:00 |
|
netns.h
|
lockd: per-net NSM client creation and destruction helpers introduced
|
2012-10-01 15:27:34 -07:00 |
|
svc.c
|
lockd: fix rpcbind crash on lockd startup failure
|
2014-09-08 12:03:32 -04:00 |
|
svc4proc.c
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
|
2012-08-01 10:26:23 -07:00 |
|
svclock.c
|
lockd: send correct lock when granting a delayed lock.
|
2014-02-13 14:55:02 -05:00 |
|
svcproc.c
|
NLM: nlm_lookup_file() may return NLMv4-specific error codes
|
2012-10-17 10:14:14 -04:00 |
|
svcshare.c
|
lockd: fix sparse warning in svcshare.c
|
2008-04-23 16:13:39 -04:00 |
|
svcsubs.c
|
nfsd: move <linux/nfsd/export.h> to fs/nfsd
|
2014-05-06 17:54:54 -04:00 |
|
xdr.c
|
nfsd: remove <linux/nfsd/nfsfh.h>
|
2014-05-06 17:54:53 -04:00 |
|
xdr4.c
|
lockd: Introduce new-style XDR functions for NLMv4
|
2010-12-16 12:37:23 -05:00 |