android_kernel_sony_sdm845/security/keys
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Yang Xu e7681c217a KEYS: reaching the keys quotas correctly
commit 2e356101e72ab1361821b3af024d64877d9a798d upstream.

Currently, when we add a new user key, the calltrace as below:

add_key()
  key_create_or_update()
    key_alloc()
    __key_instantiate_and_link
      generic_key_instantiate
        key_payload_reserve
          ......

Since commit a08bf91ce28e ("KEYS: allow reaching the keys quotas exactly"),
we can reach max bytes/keys in key_alloc, but we forget to remove this
limit when we reserver space for payload in key_payload_reserve. So we
can only reach max keys but not max bytes when having delta between plen
and type->def_datalen. Remove this limit when instantiating the key, so we
can keep consistent with key_alloc.

Also, fix the similar problem in keyctl_chown_key().

Fixes: 0b77f5bfb4 ("keys: make the keyring quotas controllable through /proc/sys")
Fixes: a08bf91ce28e ("KEYS: allow reaching the keys quotas exactly")
Cc: stable@vger.kernel.org # 5.0.x
Cc: Eric Biggers <ebiggers@google.com>
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-04-24 07:58:53 +02:00
..
encrypted-keys KEYS: encrypted: fix buffer overread in valid_master_desc() 2018-02-13 12:35:57 +01:00
big_key.c KEYS: Fix race between updating and finding a negative key 2017-10-27 10:38:11 +02:00
compat.c KEYS: Add placeholder for KDF usage with DH 2016-06-03 16:14:34 +10:00
dh.c KEYS: Add placeholder for KDF usage with DH 2016-06-03 16:14:34 +10:00
gc.c KEYS: Fix race between updating and finding a negative key 2017-10-27 10:38:11 +02:00
internal.h KEYS: prevent creating a different user's keyrings 2017-10-05 09:44:00 +02:00
Kconfig security/keys: BIG_KEY requires CONFIG_CRYPTO 2018-02-25 11:05:53 +01:00
key.c KEYS: reaching the keys quotas correctly 2020-04-24 07:58:53 +02:00
keyctl.c KEYS: reaching the keys quotas correctly 2020-04-24 07:58:53 +02:00
keyring.c KEYS: always initialize keyring_index_key::desc_len 2019-02-27 10:07:00 +01:00
Makefile KEYS: Add KEYCTL_DH_COMPUTE command 2016-04-12 19:54:58 +01:00
permission.c KEYS: Move the flags representing required permission to linux/key.h 2014-03-14 17:44:49 +00:00
persistent.c KEYS: Strip trailing spaces 2016-06-14 10:29:44 +01:00
proc.c KEYS: restrict /proc/keys by credentials at open time 2019-03-19 13:14:08 +01:00
process_keys.c KEYS: Fix race between updating and finding a negative key 2017-10-27 10:38:11 +02:00
request_key.c KEYS: always initialize keyring_index_key::desc_len 2019-02-27 10:07:00 +01:00
request_key_auth.c keys: Fix missing null pointer check in request_key_auth_describe() 2019-09-21 07:14:21 +02:00
sysctl.c security: Convert use of typedef ctl_table to struct ctl_table 2014-04-15 13:39:58 +10:00
trusted.c KEYS: trusted: fix writing past end of buffer in trusted_read() 2017-11-15 15:53:17 +01:00
trusted.h keys, trusted: move struct trusted_key_options to trusted-type.h 2015-10-19 01:01:21 +02:00
user_defined.c KEYS: Fix race between updating and finding a negative key 2017-10-27 10:38:11 +02:00