Tariq Toukan
673212158f
net: Do not clear the sock TX queue in sk_set_socket()
...
[ Upstream commit 41b14fb8724d5a4b382a63cb4a1a61880347ccb8 ]
Clearing the sock TX queue in sk_set_socket() might cause unexpected
out-of-order transmit when called from sock_orphan(), as outstanding
packets can pick a different TX queue and bypass the ones already queued.
This is undesired in general. More specifically, it breaks the in-order
scheduling property guarantee for device-offloaded TLS sockets.
Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
explicitly only where needed.
Fixes: e022f0b4a0 ("net: Introduce sk_tx_queue_mapping")
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Reviewed-by: Boris Pismenny <borisp@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-30 15:38:39 -04:00
..
datagram.c
net: add READ_ONCE() annotation in __skb_wait_for_more_packets()
2019-11-10 11:23:25 +01:00
dev.c
net: fix memleak in register_netdevice()
2020-06-30 15:38:38 -04:00
dev_addr_lists.c
net: fix uninit-value in __hw_addr_add_ex()
2018-05-16 10:08:41 +02:00
dev_ioctl.c
net: Zero terminate ifr_name in dev_ifname().
2017-08-11 08:49:32 -07:00
devlink.c
devlink: add hardware messages tracing facility
2016-07-12 14:20:18 -07:00
drop_monitor.c
drop_monitor: work around gcc-10 stringop-overflow warning
2020-05-20 08:15:33 +02:00
dst.c
Fix an intermittent pr_emerg warning about lo becoming free.
2017-07-05 14:40:14 +02:00
dst_cache.c
net: dst_cache_per_cpu_dst_set() can be static
2016-03-18 17:45:08 -04:00
ethtool.c
net: ethtool: Add back transceiver type
2020-01-29 10:24:36 +01:00
fib_rules.c
net: fib_rules: Correctly set table field when table number exceeds 8 bits
2020-03-11 07:53:04 +01:00
filter.c
bpf: fix 32-bit divide by zero
2018-01-31 12:55:57 +01:00
flow.c
flowcache: Increase threshold for refusing new allocations
2016-11-23 06:37:09 +01:00
flow_dissector.c
net/flow_dissector: switch to siphash
2019-11-10 11:23:31 +01:00
gen_estimator.c
net: sched: do not acquire qdisc spinlock in qdisc/class stats dump
2016-06-07 16:37:14 -07:00
gen_stats.c
gen_stats: Fix netlink stats dumping in the presence of padding
2018-07-25 11:24:00 +02:00
hwbm.c
net: hwbm: Fix unbalanced spinlock in error case
2016-05-25 12:35:09 -07:00
link_watch.c
lwtunnel.c
lwtunnel: Fix oops on state free after encap module unload
2017-02-04 09:47:11 +01:00
Makefile
net: add a hardware buffer management helper API
2016-03-14 12:19:46 -04:00
neighbour.c
net: neigh: use long type to store jiffies delta
2020-01-29 10:24:35 +01:00
net-procfs.c
net: remove NETDEV_TX_LOCKED support
2016-04-26 15:53:05 -04:00
net-sysfs.c
net-sysfs: Fix mem leak in netdev_register_kobject
2019-03-13 14:04:52 -07:00
net-sysfs.h
net-traces.c
net: IPv6 fib lookup tracepoint
2015-11-22 11:54:10 -05:00
net_namespace.c
net/net_namespace: Check the return value of register_pernet_subsys()
2019-12-05 15:34:55 +01:00
netclassid_cgroup.c
cgroup, netclassid: periodically release file_lock on classid updating
2020-03-20 09:07:37 +01:00
netevent.c
netevent: remove automatic variable in register_netevent_notifier()
2015-05-31 00:03:21 -07:00
netpoll.c
net: fix skb use after free in netpoll
2019-09-10 10:31:04 +01:00
netprio_cgroup.c
netprio_cgroup: Fix unlimited memory leak of v2 cgroups
2020-05-20 08:15:39 +02:00
pktgen.c
pktgen: do not sleep with the thread lock held.
2019-06-11 12:22:46 +02:00
ptp_classifier.c
ptp: Change ptp_class to a proper bitmask
2015-11-03 11:08:22 -05:00
request_sock.c
tcp: restore fastopen operations
2015-10-05 03:19:06 -07:00
rtnetlink.c
net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags
2020-06-03 08:16:47 +02:00
scm.c
unix: correctly track in-flight fds in sending process user_struct
2016-02-08 10:30:42 -05:00
secure_seq.c
net: remove a sparse error in secure_dccpv6_sequence_number()
2015-05-25 22:55:37 -04:00
skbuff.c
net: gso: Fix skb_segment splat when splitting gso_size mangled skb having linear-headed frag_list
2019-09-21 07:14:02 +02:00
sock.c
net: Do not clear the sock TX queue in sk_set_socket()
2020-06-30 15:38:39 -04:00
sock_diag.c
net: core: fix module type in sock_diag_bind
2018-01-17 09:38:53 +01:00
sock_reuseport.c
soreuseport: fix mem leak in reuseport_add_sock()
2018-02-13 12:35:57 +01:00
stream.c
tcp: make sure EPOLLOUT wont be missed
2019-09-06 10:19:45 +02:00
sysctl_net_core.c
net, sysctl: Fix compiler warning when only cBPF is present
2020-01-04 13:41:04 +01:00
timestamping.c
net: skb_defer_rx_timestamp should check for phydev before setting up classify
2015-07-09 14:17:15 -07:00
tso.c
net: tso: add support for IPv6
2015-10-26 22:24:22 -07:00
utils.c
net: Fix skb->csum update in inet_proto_csum_replace16().
2020-02-05 13:05:56 +00:00