android_kernel_sony_sdm845/drivers/ptp
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Vladis Dronov 31db64366d ptp: free ptp device pin descriptors properly
commit 75718584cb3c64e6269109d4d54f888ac5a5fd15 upstream.

There is a bug in ptp_clock_unregister(), where ptp_cleanup_pin_groups()
first frees ptp->pin_{,dev_}attr, but then posix_clock_unregister() needs
them to destroy a related sysfs device.

These functions can not be just swapped, as posix_clock_unregister() frees
ptp which is needed in the ptp_cleanup_pin_groups(). Fix this by calling
ptp_cleanup_pin_groups() in ptp_clock_release(), right before ptp is freed.

This makes this patch fix an UAF bug in a patch which fixes an UAF bug.

Reported-by: Antti Laakso <antti.laakso@intel.com>
Fixes: a33121e5487b ("ptp: fix the race between the release of ptp_clock and cdev")
Link: https://lore.kernel.org/netdev/3d2bd09735dbdaf003585ca376b7c1e5b69a19bd.camel@intel.com/
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-05-20 08:15:33 +02:00
..
Kconfig ptp: ptp_pch depends on x86_32 2014-06-17 15:43:48 -07:00
Makefile
ptp_chardev.c ptp: check gettime64 return code in PTP_SYS_OFFSET ioctl 2019-02-12 19:44:52 +01:00
ptp_clock.c ptp: free ptp device pin descriptors properly 2020-05-20 08:15:33 +02:00
ptp_ixp46x.c ptp: ixp46x: remove NO_IRQ handling 2016-09-06 16:57:02 -07:00
ptp_pch.c ptp: pch: convert to the 64 bit get/set time methods. 2015-03-31 12:01:19 -04:00
ptp_private.h ptp: fix the race between the release of ptp_clock and cdev 2020-05-20 08:15:32 +02:00
ptp_sysfs.c ptp: create "pins" together with the rest of attributes 2020-05-20 08:15:32 +02:00