joy/android_kernel_sony_sdm845
Watch
1
Fork
You've already forked android_kernel_sony_sdm845
 0
Code Issues Pull requests Projects Releases Wiki Activity
android_kernel_sony_sdm845/Documentation/media/uapi/dvb
History
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Mauro Carvalho Chehab 55089d34f1 media: dvb_frontend: fix return values for FE_SET_PROPERTY 
commit 259a41d9ae8f3689742267f340ad2b159d00b302 upstream

There are several problems with regards to the return of
FE_SET_PROPERTY. The original idea were to return per-property
return codes via tvp->result field, and to return an updated
set of values.

However, that never worked. What's actually implemented is:

- the FE_SET_PROPERTY implementation doesn't call .get_frontend
  callback in order to get the actual parameters after return;

- the tvp->result field is only filled if there's no error.
  So, it is always filled with zero;

- FE_SET_PROPERTY doesn't call memdup_user() nor any other
  copy_to_user() function. So, any changes to the properties
  will be lost;

- FE_SET_PROPERTY is declared as a write-only ioctl (IOW).

While we could fix the above, it could cause regressions.

So, let's just assume what the code really does, updating
the documentation accordingly and removing the logic that
would update the discarded tvp->result.

Reviewed-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-30 15:38:35 -04:00
..
intro_files
audio-bilingual-channel-select.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
audio-channel-select.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
audio-clear-buffer.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-continue.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-fclose.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-fopen.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-fwrite.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-get-capabilities.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-get-pts.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-get-status.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-pause.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-play.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-select-source.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
audio-set-attributes.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
audio-set-av-sync.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-set-bypass-mode.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-set-ext-id.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-set-id.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-set-karaoke.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
audio-set-mixer.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
audio-set-mute.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-set-streamtype.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio-stop.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
audio.rst
audio_data_types.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
audio_function_calls.rst
audio_h.rst
ca-fclose.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
ca-fopen.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
ca-get-cap.rst [media] docs-rst: fix the remaining broken links for DVB CA API 2016-09-09 09:52:50 -03:00
ca-get-descr-info.rst [media] docs-rst: fix the remaining broken links for DVB CA API 2016-09-09 09:52:50 -03:00
ca-get-msg.rst [media] docs-rst: fix the remaining broken links for DVB CA API 2016-09-09 09:52:50 -03:00
ca-get-slot-info.rst [media] docs-rst: fix the remaining broken links for DVB CA API 2016-09-09 09:52:50 -03:00
ca-reset.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
ca-send-msg.rst [media] docs-rst: fix the remaining broken links for DVB CA API 2016-09-09 09:52:50 -03:00
ca-set-descr.rst [media] docs-rst: fix the remaining broken links for DVB CA API 2016-09-09 09:52:50 -03:00
ca-set-pid.rst [media] docs-rst: fix the remaining broken links for DVB CA API 2016-09-09 09:52:50 -03:00
ca.rst
ca_data_types.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
ca_function_calls.rst
ca_h.rst
demux.rst
dmx-add-pid.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-fclose.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-fopen.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-fread.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-fwrite.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-get-caps.rst [media] docs-rst: fix dmx bad cross-references 2016-09-09 09:53:54 -03:00
dmx-get-event.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-get-pes-pids.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-get-stc.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-remove-pid.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-set-buffer-size.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-set-filter.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-set-pes-filter.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-set-source.rst [media] docs-rst: fix dmx bad cross-references 2016-09-09 09:53:54 -03:00
dmx-start.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx-stop.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
dmx_fcalls.rst
dmx_h.rst
dmx_types.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
dtv-fe-stats.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
dtv-properties.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
dtv-property.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
dtv-stats.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
dvb-fe-read-status.rst [media] docs-rst: better use the .. note:: tag 2016-08-22 10:02:29 -03:00
dvb-frontend-event.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
dvb-frontend-parameters.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
dvbapi.rst [media] docs-rst: better use the .. note:: tag 2016-08-22 10:02:29 -03:00
dvbproperty-006.rst
dvbproperty.rst [media] docs-rst: simplify c:type: cross references 2016-09-09 09:54:54 -03:00
examples.rst [media] docs-rst: fix some .. note:: occurrences 2016-08-22 10:36:57 -03:00
fe-bandwidth-t.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe-diseqc-recv-slave-reply.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe-diseqc-reset-overload.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-diseqc-send-burst.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe-diseqc-send-master-cmd.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe-dishnetwork-send-legacy-cmd.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-enable-high-lnb-voltage.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-get-event.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-get-frontend.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-get-info.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe-get-property.rst media: dvb_frontend: fix return values for FE_SET_PROPERTY 2020-06-30 15:38:35 -04:00
fe-read-ber.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-read-signal-strength.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-read-snr.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-read-status.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe-read-uncorrected-blocks.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-set-frontend-tune-mode.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-set-frontend.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
fe-set-tone.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe-set-voltage.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe-type-t.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
fe_property_parameters.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
frontend-property-cable-systems.rst
frontend-property-satellite-systems.rst
frontend-property-terrestrial-systems.rst
frontend-stat-properties.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
frontend.rst [media] docs-rst: better use the .. note:: tag 2016-08-22 10:02:29 -03:00
frontend_f_close.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
frontend_f_open.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
frontend_fcalls.rst
frontend_h.rst
frontend_legacy_api.rst
frontend_legacy_dvbv3_api.rst
intro.rst
legacy_dvb_apis.rst
net-add-if.rst [media] docs-rst exceptions: use C domain references for DVB headers 2016-09-09 09:45:24 -03:00
net-get-if.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00
net-remove-if.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
net.rst
net_h.rst
query-dvb-frontend-info.rst
video-clear-buffer.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-command.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-continue.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-fast-forward.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-fclose.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-fopen.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-freeze.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-fwrite.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-get-capabilities.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-get-event.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-get-frame-count.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-get-frame-rate.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-get-navi.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-get-pts.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-get-size.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-get-status.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-play.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-select-source.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-set-attributes.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-set-blank.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-set-display-format.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-set-format.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-set-highlight.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-set-id.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-set-spu-palette.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-set-spu.rst [media] fix broken references on dvb/video*rst 2016-09-09 09:53:35 -03:00
video-set-streamtype.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-set-system.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-slowmotion.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-stillpicture.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-stop.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video-try-command.rst [media] docs-rst: Convert DVB uAPI to use C function references 2016-08-22 21:23:34 -03:00
video.rst
video_function_calls.rst
video_h.rst
video_types.rst [media] docs-rst: convert uAPI structs to C domain 2016-09-09 09:34:01 -03:00