android_kernel_sony_sdm845/arch/x86/kernel/apic
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Thomas Gleixner c557481a94 x86/apic/vector: Fix off by one in error path
commit 45d55e7bac4028af93f5fa324e69958a0b868e96 upstream.

Keith reported the following warning:

WARNING: CPU: 28 PID: 1420 at kernel/irq/matrix.c:222 irq_matrix_remove_managed+0x10f/0x120
  x86_vector_free_irqs+0xa1/0x180
  x86_vector_alloc_irqs+0x1e4/0x3a0
  msi_domain_alloc+0x62/0x130

The reason for this is that if the vector allocation fails the error
handling code tries to free the failed vector as well, which causes the
above imbalance warning to trigger.

Adjust the error path to handle this correctly.

Fixes: b5dc8e6c21 ("x86/irq: Use hierarchical irqdomain to manage CPU interrupt vectors")
Reported-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Keith Busch <keith.busch@intel.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/alpine.DEB.2.20.1801161217300.1823@nanos
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-01-23 19:57:06 +01:00
..
apic.c x86/irq, trace: Add __irq_entry annotation to x86's platform IRQ handlers 2017-11-21 09:23:24 +01:00
apic_flat_64.c Merge branch 'x86-cleanups-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2016-10-03 17:18:52 -07:00
apic_noop.c x86: Apply more __ro_after_init and const 2016-08-10 14:55:05 +02:00
apic_numachip.c x86: Clean up various simple wrapper functions 2016-09-13 20:42:58 +02:00
bigsmp_32.c x86: Apply more __ro_after_init and const 2016-08-10 14:55:05 +02:00
htirq.c x86: Constify irqdomain ops 2015-05-05 11:14:48 +02:00
hw_nmi.c nmi_backtrace: add more trigger_*_cpu_backtrace() methods 2016-10-07 18:46:30 -07:00
io_apic.c x86/ioapic: Pass the correct data to unmask_ioapic_irq() 2017-07-27 15:08:04 -07:00
ipi.c x86/kernel: Audit and remove any unnecessary uses of module.h 2016-07-14 15:06:41 +02:00
Makefile kernel: add kcov code coverage 2016-03-22 15:36:02 -07:00
msi.c x86: Apply more __ro_after_init and const 2016-08-10 14:55:05 +02:00
probe_32.c Merge branch 'x86-asm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2016-10-03 16:13:28 -07:00
probe_64.c x86/apic: Remove duplicated include from probe_64.c 2016-07-19 16:02:31 +02:00
vector.c x86/apic/vector: Fix off by one in error path 2018-01-23 19:57:06 +01:00
x2apic_cluster.c Merge branch 'x86/mm' into x86/asm, to unify the two branches for simplicity 2016-09-08 08:41:52 +02:00
x2apic_phys.c x86: Apply more __ro_after_init and const 2016-08-10 14:55:05 +02:00
x2apic_uv_x.c x86/apic/uv: Silence a shift wrapping warning 2016-11-24 06:01:05 +01:00