Ethan Zhao
fe0034a08b
sched/sysctl: Check user input value of sysctl_sched_time_avg
commit 5ccba44ba118a5000cccc50076b0344632459779 upstream.
System will hang if user set sysctl_sched_time_avg to 0:
[root@XXX ~]# sysctl kernel.sched_time_avg_ms=0
Stack traceback for pid 0
0xffff883f6406c600 0 0 1 3 R 0xffff883f6406cf50 *swapper/3
ffff883f7ccc3ae8 0000000000000018 ffffffff810c4dd0 0000000000000000
0000000000017800 ffff883f7ccc3d78 0000000000000003 ffff883f7ccc3bf8
ffffffff810c4fc9 ffff883f7ccc3c08 00000000810c5043 ffff883f7ccc3c08
Call Trace:
<IRQ> [<ffffffff810c4dd0>] ? update_group_capacity+0x110/0x200
[<ffffffff810c4fc9>] ? update_sd_lb_stats+0x109/0x600
[<ffffffff810c5507>] ? find_busiest_group+0x47/0x530
[<ffffffff810c5b84>] ? load_balance+0x194/0x900
[<ffffffff810ad5ca>] ? update_rq_clock.part.83+0x1a/0xe0
[<ffffffff810c6d42>] ? rebalance_domains+0x152/0x290
[<ffffffff810c6f5c>] ? run_rebalance_domains+0xdc/0x1d0
[<ffffffff8108a75b>] ? __do_softirq+0xfb/0x320
[<ffffffff8108ac85>] ? irq_exit+0x125/0x130
[<ffffffff810b3a17>] ? scheduler_ipi+0x97/0x160
[<ffffffff81052709>] ? smp_reschedule_interrupt+0x29/0x30
[<ffffffff8173a1be>] ? reschedule_interrupt+0x6e/0x80
<EOI> [<ffffffff815bc83c>] ? cpuidle_enter_state+0xcc/0x230
[<ffffffff815bc80c>] ? cpuidle_enter_state+0x9c/0x230
[<ffffffff815bc9d7>] ? cpuidle_enter+0x17/0x20
[<ffffffff810cd6dc>] ? cpu_startup_entry+0x38c/0x420
[<ffffffff81053373>] ? start_secondary+0x173/0x1e0
Because divide-by-zero error happens in function:
update_group_capacity()
update_cpu_capacity()
scale_rt_capacity()
{
...
total = sched_avg_period() + delta;
used = div_u64(avg, total);
...
}
To fix this issue, check user input value of sysctl_sched_time_avg, keep
it unchanged when hitting invalid input, and set the minimum limit of
sysctl_sched_time_avg to 1 ms.
Reported-by: James Puthukattukaran <james.puthukattukaran@oracle.com>
Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: efault@gmx.de
Cc: ethan.kernel@gmail.com
Cc: keescook@chromium.org
Cc: mcgrof@kernel.org
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/1504504774-18253-1-git-send-email-ethan.zhao@oracle.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Steve Muckle <smuckle@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2018-09-05 09:20:04 +02:00 |
| .. |
|
bpf
|
bpf: fix references to free_bpf_prog_info() in comments
|
2018-08-03 07:55:23 +02:00 |
|
configs
|
config: android: enable CONFIG_SECCOMP
|
2016-10-11 15:06:32 -07:00 |
|
debug
|
kdb: make "mdr" command repeat
|
2018-05-30 07:50:51 +02:00 |
|
events
|
perf/core: Fix perf_output_read_group()
|
2018-05-30 07:50:46 +02:00 |
|
gcov
|
gcov: support GCC 7.1
|
2017-09-02 07:07:53 +02:00 |
|
irq
|
genirq: Make force irq threading setup more robust
|
2018-08-09 12:17:57 +02:00 |
|
livepatch
|
livepatch/module: make TAINT_LIVEPATCH module-specific
|
2016-08-26 14:42:08 +02:00 |
|
locking
|
locking/lockdep: Do not record IRQ state within lockdep code
|
2018-08-24 13:12:31 +02:00 |
|
power
|
PM / hibernate: Fix oops at snapshot_write()
|
2018-07-17 11:37:54 +02:00 |
|
printk
|
printk: fix possible reuse of va_list variable
|
2018-07-03 11:23:10 +02:00 |
|
rcu
|
rcu: Call touch_nmi_watchdog() while printing stall warnings
|
2018-05-30 07:50:50 +02:00 |
|
sched
|
sched/wait: Remove the lockless swait_active() check in swake_up*()
|
2018-08-06 16:23:02 +02:00 |
|
time
|
nohz: Fix local_timer_softirq_pending()
|
2018-08-09 12:17:57 +02:00 |
|
trace
|
tracing: Use __printf markup to silence compiler
|
2018-08-24 13:12:35 +02:00 |
|
.gitignore
|
|
|
|
acct.c
|
kernel/acct.c: fix the acct->needcheck check in check_free_space()
|
2018-01-10 09:29:51 +01:00 |
|
async.c
|
kernel/async.c: revert "async: simplify lowest_in_progress()"
|
2018-02-17 13:21:18 +01:00 |
|
audit.c
|
audit: return on memory error to avoid null pointer dereference
|
2018-05-30 07:50:49 +02:00 |
|
audit.h
|
Merge branch 'stable-4.8' of git://git.infradead.org/users/pcmoore/audit
|
2016-07-29 17:54:17 -07:00 |
|
audit_fsnotify.c
|
|
|
|
audit_tree.c
|
audit: cleanup prune_tree_thread
|
2016-04-04 09:46:47 -04:00 |
|
audit_watch.c
|
audit: Fix use after free in audit_remove_watch_rule()
|
2017-08-24 17:12:18 -07:00 |
|
auditfilter.c
|
audit: allow not equal op for audit by executable
|
2018-08-03 07:55:25 +02:00 |
|
auditsc.c
|
audit: allow not equal op for audit by executable
|
2018-08-03 07:55:25 +02:00 |
|
backtracetest.c
|
|
|
|
bounds.c
|
|
|
|
capability.c
|
ptrace: Capture the ptracer's creds not PT_PTRACE_CAP
|
2017-01-06 10:40:13 +01:00 |
|
cgroup.c
|
cgroup: fix error return value from cgroup_subtree_control()
|
2017-08-11 08:49:28 -07:00 |
|
cgroup_freezer.c
|
|
|
|
cgroup_pids.c
|
cgroup/pids: remove spurious suspicious RCU usage warning
|
2017-03-26 13:05:58 +02:00 |
|
compat.c
|
|
|
|
configs.c
|
|
|
|
context_tracking.c
|
|
|
|
cpu.c
|
cpu/hotplug: Non-SMP machines do not make use of booted_once
|
2018-08-15 18:14:55 +02:00 |
|
cpu_pm.c
|
|
|
|
cpuset.c
|
sched/cpuset/pm: Fix cpuset vs. suspend-resume bugs
|
2017-10-12 11:51:25 +02:00 |
|
crash_dump.c
|
|
|
|
cred.c
|
cred: Reject inodes with invalid ids in set_create_file_as()
|
2016-06-30 18:05:09 -05:00 |
|
delayacct.c
|
|
|
|
dma.c
|
|
|
|
elfcore.c
|
|
|
|
exec_domain.c
|
|
|
|
exit.c
|
kernel/exit.c: avoid undefined behaviour when calling wait4()
|
2018-05-19 10:27:01 +02:00 |
|
extable.c
|
kernel/extable.c: mark core_kernel_text notrace
|
2017-07-21 07:42:21 +02:00 |
|
fork.c
|
fork: unconditionally clear stack on fork
|
2018-08-09 12:18:00 +02:00 |
|
freezer.c
|
freezer, oom: check TIF_MEMDIE on the correct task
|
2016-07-28 16:07:41 -07:00 |
|
futex.c
|
futex: futex_wake_op, fix sign_extend32 sign bits
|
2018-05-19 10:27:00 +02:00 |
|
futex_compat.c
|
|
|
|
groups.c
|
kernel: make groups_sort calling a responsibility group_info allocators
|
2018-01-10 09:29:52 +01:00 |
|
hung_task.c
|
hung_task: allow hung_task_panic when hung_task_warnings is 0
|
2016-10-11 15:06:33 -07:00 |
|
irq_work.c
|
|
|
|
jump_label.c
|
jump_label: Invoke jump_label_test() via early_initcall()
|
2017-12-14 09:28:24 +01:00 |
|
kallsyms.c
|
kallsyms: add support for relative offsets in kallsyms address table
|
2016-03-15 16:55:16 -07:00 |
|
kcmp.c
|
|
|
|
Kconfig.freezer
|
|
|
|
Kconfig.hz
|
|
|
|
Kconfig.locks
|
|
|
|
Kconfig.preempt
|
|
|
|
kcov.c
|
kcov: ensure irq code sees a valid area
|
2018-08-03 07:55:12 +02:00 |
|
kexec.c
|
kexec: allow architectures to override boot mapping
|
2016-08-02 19:35:27 -04:00 |
|
kexec_core.c
|
objtool, x86: Add several functions and files to the objtool whitelist
|
2018-06-05 10:28:57 +02:00 |
|
kexec_file.c
|
kexec: fix double-free when failing to relocate the purgatory
|
2016-09-01 17:52:01 -07:00 |
|
kexec_internal.h
|
|
|
|
kmod.c
|
|
|
|
kprobes.c
|
kprobes/x86: Fix to set RWX bits correctly before releasing trampoline
|
2018-04-08 12:12:43 +02:00 |
|
ksysfs.c
|
kexec: add a kexec_crash_loaded() function
|
2016-08-02 19:35:30 -04:00 |
|
kthread.c
|
kthread, tracing: Don't expose half-written comm when creating kthreads
|
2018-08-03 07:55:12 +02:00 |
|
latencytop.c
|
|
|
|
Makefile
|
kernel/watchdog.c: move hardlockup detector to separate file
|
2017-06-17 06:41:57 +02:00 |
|
membarrier.c
|
Fix: Disable sys_membarrier when nohz_full is enabled
|
2017-03-12 06:41:45 +01:00 |
|
memremap.c
|
mm: Fix devm_memremap_pages() collision handling
|
2018-02-28 10:18:34 +01:00 |
|
module-internal.h
|
|
|
|
module.c
|
module: extend 'rodata=off' boot cmdline parameter to module mappings
|
2018-04-08 12:12:52 +02:00 |
|
module_signing.c
|
KEYS: Move the point of trust determination to __key_link()
|
2016-04-11 22:43:43 +01:00 |
|
notifier.c
|
|
|
|
nsproxy.c
|
|
|
|
padata.c
|
padata: free correct variable
|
2017-05-20 14:28:40 +02:00 |
|
panic.c
|
kernel/panic.c: add missing \n
|
2017-07-05 14:40:24 +02:00 |
|
params.c
|
|
|
|
pid.c
|
pidns: disable pid allocation if pid_ns_prepare_proc() is failed in alloc_pid()
|
2018-04-13 19:47:53 +02:00 |
|
pid_namespace.c
|
pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes
|
2017-05-25 15:44:38 +02:00 |
|
profile.c
|
profile: Convert to hotplug state machine
|
2016-07-15 10:41:42 +02:00 |
|
ptrace.c
|
ptrace: Properly initialize ptracer_cred on fork
|
2017-06-14 15:05:54 +02:00 |
|
range.c
|
|
|
|
reboot.c
|
|
|
|
relay.c
|
kernel/relay.c: limit kmalloc size to KMALLOC_MAX_SIZE
|
2018-05-30 07:50:29 +02:00 |
|
resource.c
|
resource: fix integer overflow at reallocation
|
2018-04-24 09:34:09 +02:00 |
|
seccomp.c
|
seccomp: Move speculation migitation control to arch code
|
2018-05-22 16:58:02 +02:00 |
|
signal.c
|
kernel/signal.c: avoid undefined behaviour in kill_something_info
|
2018-05-30 07:50:18 +02:00 |
|
smp.c
|
cpu/hotplug: Fix SMT supported evaluation
|
2018-08-15 18:14:53 +02:00 |
|
smpboot.c
|
kthread/smpboot: do not park in kthread_create_on_cpu()
|
2016-10-11 15:06:33 -07:00 |
|
smpboot.h
|
|
|
|
softirq.c
|
Mark HI and TASKLET softirq synchronous
|
2018-08-15 18:14:42 +02:00 |
|
stacktrace.c
|
stacktrace, lockdep: Fix address, newline ugliness
|
2017-02-14 15:25:42 -08:00 |
|
stop_machine.c
|
stop_machine: Use raw spinlocks
|
2018-08-03 07:55:24 +02:00 |
|
sys.c
|
kernel/sys.c: fix potential Spectre v1 issue
|
2018-05-30 07:50:18 +02:00 |
|
sys_ni.c
|
x86/pkeys: Fix pkeys build breakage for some non-x86 arches
|
2016-09-13 14:41:36 +02:00 |
|
sysctl.c
|
sched/sysctl: Check user input value of sysctl_sched_time_avg
|
2018-09-05 09:20:04 +02:00 |
|
sysctl_binary.c
|
kernel/sysctl_binary.c: use generic UUID library
|
2016-05-20 17:58:30 -07:00 |
|
task_work.c
|
task_work: use READ_ONCE/lockless_dereference, avoid pi_lock if !task_works
|
2016-08-02 19:35:02 -04:00 |
|
taskstats.c
|
taskstats: fix the length of cgroupstats_cmd_get_policy
|
2016-11-03 16:55:58 -04:00 |
|
test_kprobes.c
|
|
|
|
torture.c
|
torture: Convert torture_shutdown() to hrtimer
|
2016-08-22 10:01:49 -07:00 |
|
tracepoint.c
|
tracepoint: Do not warn on ENOMEM
|
2018-05-09 09:50:20 +02:00 |
|
tsacct.c
|
|
|
|
ucount.c
|
kernel/ucount.c: mark user_header with kmemleak_ignore()
|
2017-06-17 06:41:51 +02:00 |
|
uid16.c
|
kernel: make groups_sort calling a responsibility group_info allocators
|
2018-01-10 09:29:52 +01:00 |
|
up.c
|
smp: Add function to execute a function synchronously on a CPU
|
2016-09-05 13:52:39 +02:00 |
|
user-return-notifier.c
|
|
|
|
user.c
|
|
|
|
user_namespace.c
|
Merge branch 'nsfs-ioctls' into HEAD
|
2016-09-22 20:00:36 -05:00 |
|
utsname.c
|
Merge branch 'nsfs-ioctls' into HEAD
|
2016-09-22 20:00:36 -05:00 |
|
utsname_sysctl.c
|
|
|
|
watchdog.c
|
kernel/watchdog: prevent false hardlockup on overloaded system
|
2017-06-17 06:41:57 +02:00 |
|
watchdog_hld.c
|
kernel/watchdog: prevent false hardlockup on overloaded system
|
2017-06-17 06:41:57 +02:00 |
|
workqueue.c
|
workqueue: use put_device() instead of kfree()
|
2018-05-30 07:50:36 +02:00 |
|
workqueue_internal.h
|
workqueue: Fix NULL pointer dereference
|
2017-11-15 15:53:17 +01:00 |